Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user feedback and block them from interacting with the UI while saved objects are being deleted #21575

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

cjcenizal
Copy link
Contributor

Fixes #21572

This is what the user sees until the objects have been deleted and the table updated:

image

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and confirmed that overlay shows while delete is in progress. LGTM!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@cjcenizal cjcenizal merged commit e92240a into elastic:master Aug 2, 2018
@cjcenizal cjcenizal deleted the bug/saved-object-cancel-button branch August 2, 2018 13:32
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 2, 2018
cjcenizal added a commit that referenced this pull request Aug 2, 2018
cjcenizal added a commit that referenced this pull request Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants