Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofocuses elements filter #24299

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Oct 19, 2018

Closes #23699.

This adds the initialFocus prop to EuiModal to auto focus on the filter search bar in the elements selection modal.

@cqliu1 cqliu1 added review v7.0.0 v6.5.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 19, 2018
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works as expected, LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cqliu1 cqliu1 merged commit 30e8553 into elastic:master Oct 22, 2018
@cqliu1 cqliu1 deleted the autofocus-elements-filter branch October 22, 2018 19:47
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Oct 22, 2018
@cqliu1
Copy link
Contributor Author

cqliu1 commented Oct 23, 2018

6.x: b58fa13

njd5475 pushed a commit to njd5475/kibana that referenced this pull request Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v6.5.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants