Adding option to always present the certificate when connecting to ES #24304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
legrego
reviewed
Oct 22, 2018
|
retest |
jbudz
reviewed
Oct 22, 2018
| @@ -42,7 +42,8 @@ export default function (kibana) { | |||
| certificateAuthorities: array().single().items(string()), | |||
| certificate: string(), | |||
| key: string(), | |||
| keyPassphrase: string() | |||
| keyPassphrase: string(), | |||
| alwaysPresentCertificate: boolean().default(false), | |||
There was a problem hiding this comment.
I think we'll need this in monitoring too, iirc it uses its own copy if url is set.
There was a problem hiding this comment.
Good call, thanks JBudz
|
Dearest Jenkins, please test this. |
jbudz
approved these changes
Oct 22, 2018
💚 Build Succeeded |
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Oct 23, 2018
…elastic#24304) * Adding option to always present the certificate when connecting to ES * Updating docs * Adding some more tests * Adding alwaysPresentCertificate option to monitoring
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
Oct 26, 2018
…ng to ES (elastic#24304)" This reverts commit 9e86a04.
kobelb
added
the
Team:Security
|
Pinging @elastic/kibana-security |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22643
"Release Note: Added option to always present certificate when connecting to Elasticsearch using
elasticsearch.ssl.alwaysPresentCertificate: true