Suggestion text needs to be a string #24526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed that you can get duplicates in the recent searches which causes another complaint from React. This happens if you have a search that is an object in your history and then type in the same string. You now have two items in the history, one is an object, the other is a string, but after toUser(), they are both the same string. I hope that makes sense. |
the same query could both exist in the persisted log, resulting in identical strings after toUser runs
|
Great catch, added deduplication as well |
💚 Build Succeeded |
💔 Build Failed |
lukasolson
approved these changes
Oct 24, 2018
|
Ah yeah that's pretty silly, and an easy fix, went ahead and changed it. |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Oct 24, 2018
* suggestion text needs to be a string * deduplicate after calling toUser since a string and object version of the same query could both exist in the persisted log, resulting in identical strings after toUser runs * don't put empty strings in the recent search history
Bargs
added a commit
that referenced
this pull request
Oct 24, 2018
* suggestion text needs to be a string * deduplicate after calling toUser since a string and object version of the same query could both exist in the persisted log, resulting in identical strings after toUser runs * don't put empty strings in the recent search history
|
Forgot to mention, that previous failure was unrelated to this PR and the build before that passed. |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue @trevan brought up here