Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion text needs to be a string #24526

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Suggestion text needs to be a string #24526

merged 3 commits into from
Oct 24, 2018

Commits on Oct 24, 2018

  1. suggestion text needs to be a string

    @Bargs
    Bargs committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    780b115 View commit details
    Browse the repository at this point in the history

  2. deduplicate after calling toUser since a string and object version of 

    the same query could both exist in the persisted log, resulting in
identical strings after toUser runs
    @Bargs
    Bargs committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    f0b58ae View commit details
    Browse the repository at this point in the history

  3. don't put empty strings in the recent search history

    @Bargs
    Bargs committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    ebdd208 View commit details
    Browse the repository at this point in the history