Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish 6.5 #24556

Merged
merged 10 commits into from
Oct 26, 2018
Merged

Polish 6.5 #24556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b6f7457
Updates waterfall item design for timeline rows
jasonrhodes Oct 25, 2018
5deb5b3
Adjusts span and tx flyouts and updates tooltips to EUI
jasonrhodes Oct 25, 2018
07718fa
Heading size fixes and clean up
jasonrhodes Oct 25, 2018
74615f1
Updates tooltip snapshots
jasonrhodes Oct 25, 2018
97576c3
Review tweaks and snapshot updates
jasonrhodes Oct 25, 2018
3c527bb
Revert experiment :)
sorenlouv Oct 25, 2018
bd861e7
Fixes bug with v1 waterfall state
jasonrhodes Oct 25, 2018
7920fdb
Fixes bug with timeline bar height
jasonrhodes Oct 25, 2018
c2d2c2f
Updates snapshot tests
jasonrhodes Oct 25, 2018
2e113de
Updated test so it doesn't mount and rely on EUI makeId() which is no…
jasonrhodes Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 13 additions & 20 deletions ...lugins/apm/public/components/app/ErrorGroupDetails/DetailView/__test__/DetailView.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,43 +7,36 @@
import React from 'react';
import DetailView from '../index';
import props from './props.json';
import { shallow } from 'enzyme';

import {
mountWithRouterAndStore,
mockMoment,
toJson
} from '../../../../../utils/testHelpers';
import { mockMoment } from '../../../../../utils/testHelpers';

describe('DetailView', () => {
let storeState;
beforeEach(() => {
// Avoid timezone issues
mockMoment();

storeState = {
location: { search: '' }
};
});

it('should render empty state', () => {
const wrapper = mountWithRouterAndStore(
<DetailView errorGroup={[]} urlParams={props.urlParams} location={{}} />,
storeState
const wrapper = shallow(
<DetailView
errorGroup={[]}
urlParams={props.urlParams}
location={{ state: '' }}
/>
);

expect(toJson(wrapper)).toMatchSnapshot();
expect(wrapper).toMatchSnapshot();
});

it('should render with data', () => {
const wrapper = mountWithRouterAndStore(
const wrapper = shallow(
<DetailView
errorGroup={props.errorGroup}
urlParams={props.urlParams}
location={{}}
/>,
storeState
location={{ state: '' }}
/>
);

expect(toJson(wrapper)).toMatchSnapshot();
expect(wrapper).toMatchSnapshot();
});
});
Loading