[ML] Adds support for kuery to job wizards #26094
Conversation
peteharverson
added
release_note:enhancement
review
v7.0.0
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
| import { addItemToRecentlyAccessed } from 'plugins/ml/util/recently_accessed'; | ||
| import { mlJobService } from 'plugins/ml/services/job_service'; | ||
|
|
||
|
|
||
| export function getQueryFromSavedSearch(formConfig) { |
There was a problem hiding this comment.
getQueryFromSavedSearch is no longer used anywhere, so could be removed.
| } else if (typeof q.query === 'object' && | ||
| typeof q.query.query_string === 'object' && q.query.query_string.query !== '') { | ||
| query.query_string.query = q.query.query_string.query; | ||
| function createSearchItemsFromRoute($route) { |
There was a problem hiding this comment.
as this function is now wrapped in a provider, $route doesn't need to be passed in here and can be added to the provider's parameters above.
The function's name change may also then not be necessary, it could go back to being createSearchItems
| // Takes the $route object to retrieve the indexPattern and savedSearch from the url | ||
| export function SearchItemsProvider(Private) { | ||
|
|
||
| const buildESQuery = Private(BuildESQueryProvider); |
There was a problem hiding this comment.
I'm happy to see this change, this a lot better than using the getQueryFromSavedSearch function that I had created.
When this was originally written is wasn't possible to include BuildESQueryProvider to create the query object as it was using relative links internally that caused issues. I think because we were then inside x-pack-kibana
| @@ -42,14 +42,16 @@ const module = uiModules.get('apps/ml'); | |||
| module.controller('MlNewJobStepJobType', | |||
| function ( | |||
| $scope, | |||
| $route) { | |||
| $route, | |||
There was a problem hiding this comment.
$route injection can be removed if you go with my suggestion above.
💚 Build Succeeded |
💔 Build Failed |
Summary
Adds support for saved searches created using Kuery to the job wizards:
Note the Data Visualizer does not yet support Kuery (would require a change to the search bar in the view to support Kuery as well as lucene syntax). If a Kuery based saved search is selected for the Data Visualizer a warning is shown to the user that Kuery is not supported.
The previous
createSearchItemsfunction injobs/new_job/utils/new_job_utils.jshas been replaced with a newSearchItemsProviderwhich builds the ES query for use in the job datafeed using the KibanaBuildESQueryProviderfrom the@kbn/es-querypackage.Checklist
For maintainers
Fixes #21062 and #22870