[APM] Add missing trace_id to transaction histogram #27591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui |
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
|
retest |
💔 Build Failed |
sorenlouv
force-pushed
the
add-missing-trace-id
branch
from
c5c5c76
to
ee73814
Compare
💚 Build Succeeded |
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Dec 27, 2018
* [APM] Add missing trace_id to transaction histogram * Handle 404 properly * Fix `unhandled` issue * Fix tests
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Dec 27, 2018
sorenlouv
added a commit
that referenced
this pull request
Dec 28, 2018
sorenlouv
added a commit
that referenced
this pull request
Dec 28, 2018
…[APM] StickyProperties should render components as values (#27814) | Revert changes to Monitoring accidentally introduced in #27591 (#278 (#27836) * [APM] Add missing trace_id to transaction histogram (#27591) * [APM] Add missing trace_id to transaction histogram * Handle 404 properly * Fix `unhandled` issue * Fix tests * [APM] StickyProperties should render components as values (#27814) * Revert changes to Monitoring accidentally introduced in #27591 (#27830)
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transaction_idis not globally unique but only unique within a given trace. To avoid collisions at scale it is therefore necessary to query transactions by bothtrace_idandtransaction_id.Additional changes:
This will not be backported to 6.6.