[Uptime] Remove beaker icon, update "help" copy #28018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
v7.0.0
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime |
💔 Build Failed |
💔 Build Failed |
|
I understand @dedemorton's concern about the use of the word "feedback." A feedback button does typically pop-up a form for the user to fill out. The word "Discuss" is commonly used with forums. It covers both the use case of asking a question and providing feedback. Either of these could work: Discuss |
|
++ to "Discuss" simply because of horizontal space concerns. |
|
|
💚 Build Succeeded |
💔 Build Failed |
andrewvc
approved these changes
Jan 8, 2019
|
jenkins test this |
💔 Build Failed |
💚 Build Succeeded |
31 tasks
|
@justinkambic still LGTM. Great work |
💔 Build Failed |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jan 11, 2019
* Add tooltip to beaker icon. Update help copy. * Remove beaker icon. * Change feedback link copy to say "Discuss". * Add target _blank to help link.
justinkambic
added a commit
that referenced
this pull request
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're removing the beaker icon from the overall app, since it will not be released as an alpha/experimental feature. We're also updating the copy on the link to the Heartbeat forum.
Resolves #27603
Testing the PR
Ensure the beaker icon is gone and the help text copy says "Heartbeat feedback".