Fix/license not passed in maps #28198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
nreese
reviewed
Jan 7, 2019
thomasneirynck
approved these changes
Jan 7, 2019
|
@thomasneirynck I'll tie in a fix in for #28119 along with my fix for #27832 per our recent conversation. Thanks! |
|
retest |
💔 Build Failed |
nreese
approved these changes
Jan 7, 2019
|
retest |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
nreese
added
the
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
kindsun
added a commit
to kindsun/kibana
that referenced
this pull request
Jan 9, 2019
* Add back in license wait for init routes and add license to ems client query params * Add back routes initialized check to prevent multiple initializations
kindsun
added a commit
that referenced
this pull request
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28117. For the latest ems client, the license wasn't being added to the query params. The license check has been updated to return the license uid if the license permits use of the Maps app. I've also added back in the logic originally used in #27943 before it was reverted (as it was believed license handling was being taken care of downstream, it wasn't!) which ensures routes are only initialized once.