Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick fix for service.name scripted field #28488

Merged
merged 3 commits into from
Jan 10, 2019
Merged

quick fix for service.name scripted field #28488

merged 3 commits into from
Jan 10, 2019

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Jan 10, 2019 •
edited
Loading

adds a guard to APM's view errors scripted field:L [context.]service.name name. Simliar to #26638.

fixes #27333

related to elastic/apm-server#1758

@graphaelli graphaelli added v7.0.0 Team:APM All issues that need APM UI Team support labels Jan 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@graphaelli
fix script syntax
f5b94e7 
thanks to @sqren for spotting it
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@graphaelli graphaelli merged commit 0487c07 into elastic:master Jan 10, 2019
@graphaelli graphaelli deleted the service-name-script branch January 10, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
Team:APM All issues that need APM UI Team support v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APM data shows painless scripted field error
3 participants
@graphaelli @elasticmachine @sorenlouv