[i18n] Translate angular-bootstrap #28650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
maryia-lapata
approved these changes
Jan 16, 2019
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
maryia-lapata
suggested changes
Jan 22, 2019
|
@maryia-lapata I've translated |
💚 Build Succeeded |
maryia-lapata
approved these changes
Jan 22, 2019
| @@ -183,8 +193,12 @@ angular.module('ui.bootstrap.pagination', []) | |||
|
|
|||
| .constant('pagerConfig', { | |||
| itemsPerPage: 10, | |||
| previousText: '« Previous', | |||
| nextText: 'Next »', | |||
| previousText: i18n.translate('common.ui.angularBootstrap.pagination.pagerConfig.previousLabel', { | |||
There was a problem hiding this comment.
Maybe we should move « out of translation label to exclude symbol order change:
previousText: '« ' + i18n.translate('common.ui.angularBootstrap.pagination.pagerConfig.previousLabel', {
defaultMessage: 'Previous'There was a problem hiding this comment.
Checked with pseudo locale
| currentText: 'Today', | ||
| clearText: 'Clear', | ||
| closeText: 'Done', | ||
| currentText: i18n.translate('common.ui.angularBootstrap.datepicker.datepickerPopupConfig.todayLabel', { |
There was a problem hiding this comment.
I've checked with pseudo locale
👍
💚 Build Succeeded |
| previousText: 'Previous', | ||
| nextText: 'Next', | ||
| lastText: 'Last', | ||
| firstText: i18n.translate('common.ui.angularBootstrap.pagination.paginationConfig.firstLabel', { |
There was a problem hiding this comment.
Checked with pseudo locale
pavel06081991
force-pushed
the
localize-angular-bootstrap
branch
from
3f7d5c5
to
a942578
Compare
💔 Build Failed |
|
retest |
💚 Build Succeeded |
pavel06081991
pushed a commit
to pavel06081991/kibana
that referenced
this pull request
Jan 28, 2019
localize angular-bootstrap/datepicker
pavel06081991
added a commit
that referenced
this pull request
Jan 28, 2019
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Jan 29, 2019
localize angular-bootstrap/datepicker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/ui/public/angular-bootstrapstrings inside
src/ui/public/angular-bootstrap/pagination/pagination.jsare not localized yet.