Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Index Management translate missing labels #28816

Merged

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Jan 16, 2019

Translate missing labels in :
x-pack -> plugins -> index_management -> public -> sections -> index_list -> components -> index_actions_context_menu -> index_actions_context_menu.js

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you!

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for doing this! I tested locally and everything looks great in the browser. I just had a few minor suggestions and then I think this will be ready for merge.

image

image

image

image

image

image

@cjcenizal cjcenizal added v7.0.0 Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jan 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit aef9562 into elastic:master Jan 21, 2019
@Nox911 Nox911 deleted the feature/index_management-missing_translations branch January 21, 2019 08:11
Nox911 added a commit to Nox911/kibana that referenced this pull request Jan 21, 2019
* Translate missing translations in index management

* Resolve review comments

* Refactor translations

* Resolve review comments
Nox911 added a commit that referenced this pull request Jan 21, 2019
* Translate missing translations in index management

* Resolve review comments

* Refactor translations

* Resolve review comments
@Nox911
Copy link
Contributor Author

Nox911 commented Jan 21, 2019

6.x/6.7.0: b522b29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:Index Management Index and index templates UI Project:i18n Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v6.7.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants