Localize strings in Rollup and ILM apps. #29034

cjcenizal · 2019-01-19T01:21:17Z

No description provided.

elasticmachine · 2019-01-19T01:21:19Z

Pinging @elastic/es-ui

cjcenizal · 2019-01-19T01:22:23Z

...ex_lifecycle_management/public/sections/policy_table/components/policy_table/policy_table.js

@@ -314,7 +314,6 @@ export class PolicyTableUi extends Component {
    const button = (
      <EuiButtonEmpty
        data-test-subj="policyActionsContextMenuButton"
-        aria-label="Policy options"


@bmcconaghy Do you think we still need this? I figure the text in the button itself is explanatory ("Actions"). Otherwise, I'd suggest we change this to be "Policy actions".

aria-label={intl.formatMessage({ id: 'xpack.indexLifecycleMgmt.policyTable.actionsButtonAriaLabel', defaultMessage: 'Policy actions', })}

cjcenizal · 2019-01-19T01:23:59Z

...ex_lifecycle_management/public/sections/policy_table/components/policy_table/policy_table.js

@@ -410,8 +409,11 @@ export class PolicyTableUi extends Component {
                  color="danger"
                  onClick={() => this.setState({ showDeleteConfirmation: true })}
                >
-                  Delete {numSelected} polic
-                  {numSelected > 1 ? 'ies' : 'y'}
+                  <FormattedMessage


@bmcconaghy This code implies you should be able to select multiple policies, but I'm not seeing checkboxes in the table. Did this bug ship originally, or is it a regression, or am I just missing something?

elasticmachine · 2019-01-19T01:58:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

maryia-lapata

@cjcenizal I just noticed that ILM wasn't added to .i18nrc.json config. It means that translations for ILM were not validated i18n tool (during CI) and labels weren't send to translation vendors.
We'll send labels to vendor on the 23rd of January. It'll the last time for v6.7.0.

Could you please add "xpack.indexLifecycleMgmt": "x-pack/plugins/index_lifecycle_management", to paths object of .i18nrc.json? It will required to fix some issue of i18n validation tool. To run it: node scripts/i18n_check.js --path x-pack/plugins/index_lifecycle_management/

maryia-lapata · 2019-01-21T08:16:30Z

...ex_lifecycle_management/public/sections/policy_table/components/policy_table/policy_table.js

-                  {numSelected > 1 ? 'ies' : 'y'}
+                  <FormattedMessage
+                    id="xpack.indexLifecycleMgmt.policyTable.sectionHeading"
+                    defaultMessage="Deleted {numSelected} {selectedIndexCount, plural, one {policy} other {policies}}"


selectedIndexCount wasn't defined:

Suggested change

defaultMessage="Deleted {numSelected} {selectedIndexCount, plural, one {policy} other {policies}}"

defaultMessage="Deleted {numSelected, plural, one {policy} other {policies}}"

cjcenizal · 2019-01-22T16:15:52Z

Retest

elasticmachine · 2019-01-22T16:54:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…ings

cjcenizal

@maryia-lapata Thanks for catching that! I've added index lifecycle management to the i18nrc file and fixed the validation errors. I also caught a few other things which required internationalization. Could you please take another look?

cjcenizal · 2019-01-22T19:36:10Z

...public/sections/policy_table/components/policy_table/add_policy_to_template_confirm_modal.js

@@ -37,7 +37,7 @@ export class AddPolicyToTemplateConfirmModalUi extends Component {
    const policyName = policy.name;
    if (!templateName) {
      this.setState({ templateError: i18n.translate(
-        'xpack.indexLifecycleMgmt.policyTable.addLifecyclePolicyConfirmModal.noTemplateSelectedErrorMessage',
+        'xpack.indexLifecycleMgmt.policyTable.addLifecyclePolicyToTemplateConfirmModal.noTemplateSelectedErrorMessage',


@maryia-lapata Please note I've changed a lot of the IDs in this file. Will this impact the translations?

Since all xpack.indexLifecycleMgmt message were not sent to translation vendors, so there is no impact.

cjcenizal · 2019-01-22T19:36:25Z

x-pack/plugins/index_lifecycle_management/server/lib/check_license/check_license.js

-        values: { pluginName }
-      })
+      message: i18n.translate(
+        'xpack.indexLifecycleMgmt.checkLicense.errorUnavailableMessage',


The IDs in this file have also changed.

elasticmachine · 2019-01-22T20:14:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-22T20:56:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-01-22T21:38:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

maryia-lapata

LGTM

maryia-lapata · 2019-01-23T13:14:17Z

x-pack/plugins/cross_cluster_replication/server/lib/check_license/check_license.js

@@ -14,7 +16,13 @@ export function checkLicense(xpackLicenseInfo) {
      isAvailable: false,
      showLinks: true,
      enableLinks: false,
-      message: `You cannot use ${pluginName} because license information is not available at this time.`,
+      message: i18n.translate(


Error messages from this file are not displayed on UI. Ordinary we don't translate such labels, but maybe these labels will be displayed on UI in the future...

maryia-lapata · 2019-01-23T13:30:23Z

...public/sections/policy_table/components/policy_table/add_policy_to_template_confirm_modal.js

@@ -37,7 +37,7 @@ export class AddPolicyToTemplateConfirmModalUi extends Component {
    const policyName = policy.name;
    if (!templateName) {
      this.setState({ templateError: i18n.translate(
-        'xpack.indexLifecycleMgmt.policyTable.addLifecyclePolicyConfirmModal.noTemplateSelectedErrorMessage',
+        'xpack.indexLifecycleMgmt.policyTable.addLifecyclePolicyToTemplateConfirmModal.noTemplateSelectedErrorMessage',


Since all xpack.indexLifecycleMgmt message were not sent to translation vendors, so there is no impact.

maryia-lapata · 2019-01-23T13:35:26Z

...ex_lifecycle_management/public/sections/policy_table/components/policy_table/policy_table.js

-                  {numSelected > 1 ? 'ies' : 'y'}
+                  <FormattedMessage
+                    id="xpack.indexLifecycleMgmt.policyTable.deletedPoliciesText"
+                    defaultMessage="Deleted {numSelected} {numSelected, plural, one {policy} other {policies}}"


The sorter version:

Suggested change

defaultMessage="Deleted {numSelected} {numSelected, plural, one {policy} other {policies}}"

defaultMessage="Deleted {numSelected, plural, one {# policy} other {# policies}}"

# means the number before plural

maryia-lapata · 2019-01-23T14:27:27Z

@cj we'll send the next bunch of labels to vendors on 24 January at 8 AM (GMT+3). It would be most appreciated, if this PR is merged and backported before this time. Please do not worry about changed IDs. Since xpack.indexLifecycleMgmt labels haven't got in json file earlier(because this plugin hasn't been configured correct), vendors will receive this plugin to translate for the first time.

bmcconaghy

LGTM

* Add ILM to i18nrc.json. Fix validation errors. * Localize CCR and Rollups checkLicense errors. * Fix bug in Remote Clusters checkLicense error. * Use rollupJobs namespace in checkLicense.

Localize strings in Rollup and ILM apps.

d2d446d

cjcenizal added Project:i18n v7.0.0 Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v6.7.0 labels Jan 19, 2019

cjcenizal requested review from bmcconaghy and maryia-lapata January 19, 2019 01:21

cjcenizal commented Jan 19, 2019

View reviewed changes

maryia-lapata reviewed Jan 21, 2019

View reviewed changes

cjcenizal added 5 commits January 22, 2019 10:21

Merge remote-tracking branch 'upstream/master' into i18n/localize-str…

072200a

…ings

Fix missing selectedIndexCount var.

9a1dd94

Add ILM to i18nrc.json. Fix validation errors.

2bfc1a4

Localize CCR and Rollups checkLicense errors.

b46711e

Fix bug in Remote Clusters checkLicense error.

c18f4fd

cjcenizal commented Jan 22, 2019

View reviewed changes

Update ILM snapshots.

851b4ca

Use rollupJobs namespace in checkLicense.

308b94d

maryia-lapata approved these changes Jan 23, 2019

View reviewed changes

bmcconaghy approved these changes Jan 23, 2019

View reviewed changes

cjcenizal merged commit bfa417c into elastic:master Jan 24, 2019

cjcenizal deleted the i18n/localize-strings branch January 24, 2019 00:36

cjcenizal mentioned this pull request Jan 24, 2019

[6.x] Localize strings in Rollup and ILM apps. (#29034) #29234

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Localize strings in Rollup and ILM apps. #29034

Localize strings in Rollup and ILM apps. #29034

cjcenizal commented Jan 19, 2019

elasticmachine commented Jan 19, 2019

cjcenizal Jan 19, 2019

cjcenizal Jan 19, 2019

elasticmachine commented Jan 19, 2019

maryia-lapata left a comment

maryia-lapata Jan 21, 2019

cjcenizal commented Jan 22, 2019

elasticmachine commented Jan 22, 2019

cjcenizal left a comment

cjcenizal Jan 22, 2019

maryia-lapata Jan 23, 2019

cjcenizal Jan 22, 2019

elasticmachine commented Jan 22, 2019

elasticmachine commented Jan 22, 2019

elasticmachine commented Jan 22, 2019

maryia-lapata left a comment

maryia-lapata Jan 23, 2019

maryia-lapata Jan 23, 2019

maryia-lapata Jan 23, 2019

maryia-lapata commented Jan 23, 2019

bmcconaghy left a comment

	defaultMessage="Deleted {numSelected} {selectedIndexCount, plural, one {policy} other {policies}}"
	defaultMessage="Deleted {numSelected, plural, one {policy} other {policies}}"

	defaultMessage="Deleted {numSelected} {numSelected, plural, one {policy} other {policies}}"
	defaultMessage="Deleted {numSelected, plural, one {# policy} other {# policies}}"

Localize strings in Rollup and ILM apps. #29034

Localize strings in Rollup and ILM apps. #29034

Conversation

cjcenizal commented Jan 19, 2019

elasticmachine commented Jan 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Jan 19, 2019

💔 Build Failed

maryia-lapata left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cjcenizal commented Jan 22, 2019

elasticmachine commented Jan 22, 2019

💔 Build Failed

cjcenizal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Jan 22, 2019

💔 Build Failed

elasticmachine commented Jan 22, 2019

💔 Build Failed

elasticmachine commented Jan 22, 2019

💚 Build Succeeded

maryia-lapata left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maryia-lapata commented Jan 23, 2019

bmcconaghy left a comment

Choose a reason for hiding this comment