[CCR] Integrate new follower index info ES API #29153

jen-huang · 2019-01-23T06:24:19Z

You may need to run a fresh ES instance to get the latest snapshot to test this PR! :)

This PR integrates the new follower index info ES API. Essentially, this allows:

Follower indices in a paused state to surface in the UI
Settings of active followers to surface in the UI

Note that there are two filed ES issues related to this API, which has affected some of this work:

[CCR] Follower info API doesn't return paused status elasticsearch#37738: Follower info API doesn't return paused status
[CCR] Follower info API doesn't return settings for paused indices elasticsearch#37740: Follower info API doesn't return settings for paused indices

Table view

Paused follower detail panel

Active follower detail panel

Resuming a paused follower

We are not able to read a paused follower's previous settings (can only retrieve what the settings are for an active follower), so copy was added to reflect that "quick resume" action will resume with default settings.

Editing a paused follower

Related to above ^ Editing always implies resuming.

Misc

Shortcut to Index Management from context menu:

Display default value under each advanced setting description (similar to Kibana Advanced Settings pattern):

* Collate data from follower stats and info apis when retrieving all followers and single follower * Add follower settings info to detail panel * Add paused/active UI state * Surface follower default settings to UI

elasticmachine · 2019-01-23T06:24:21Z

Pinging @elastic/es-ui

elasticmachine · 2019-01-23T07:04:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

yaronp68 · 2019-01-23T22:22:17Z

LGTM great work

sebelga · 2019-01-24T14:06:36Z

...ation/public/app/sections/home/follower_indices_list/components/context_menu/context_menu.js

@@ -22,6 +22,8 @@ import {
  FollowerIndexUnfollowProvider
 } from '../../../../../components';

+import { getIndexListUri } from '../../../../../../../../index_management/public/services/navigation';


Is this allowed? 😊 Maybe we should ask @bmcconaghy to expose everything that is public from the /index_management/index.js file?

Good point! We could even re-export internals from Index Management from a root-level "shared" directory, so we wouldn't need to move any files around. This would allow Index Management's modules to be organized in a way that makes the most sense to Index Management, while still exposing some select functionality to other plugins.

// index_management/public/shared/index.js export { getIndexListUri } from './services/navigation';

I will defer this for now as we are doing this deep traversal in other places too, but I think it's a great idea to export from index management root

sebelga · 2019-01-24T14:20:44Z

...ation/public/app/sections/home/follower_indices_list/components/detail_panel/detail_panel.js

+                  <EuiFlexItem>
+                    <EuiDescriptionListTitle>
+                      <EuiTitle size="xs">
+                        <FormattedMessage


Small note: this is a lot of duplication of translations with the form fields. Unless we don't care at all about the size of bytes sent to the client, we should be able to reuse those translations. It seems that we don't care too much about the size of our .bundle.js so maybe it doesn't matter but wanted to pointed it out. Thoughts @cjcenizal @bmcconaghy ?

If we're using the same string everywhere in the same context, e.g. "Max read request operation count" as a label for a section or field, then yes I agree. I think we could safely refer to a single instance of each string in multiple places without interfering with the translators' work. I also think it could be easy to follow while reading the code if we name the variables well.

I will change these labels so they use the same ones from form

sebelga · 2019-01-24T14:24:36Z

x-pack/plugins/cross_cluster_replication/server/lib/follower_index_serialization.js

+  leaderIndex: leader_index,
+
+  // TODO: Remove conditional when https://github.com/elastic/elasticsearch/issues/37738 is fixed
+  status: status === 'active' && shards ? 'active' : 'paused',


Seems that #37738 is fixed, can we remove the conditional?

sebelga · 2019-01-24T14:28:39Z

x-pack/plugins/cross_cluster_replication/server/routes/api/follower_index.js

-        const followerIndex = response.indices[0];
+        // TODO: Replace with single follower index info request when
+        // https://github.com/elastic/elasticsearch/issues/37738 is fixed
+        const {


I think we now can use the end point for single follower index

sebelga

Tested locally and works great! Good job. I added a few comments but no blocker.

What do you think about (can be addressed in a separate PR): when the user wants to pause a follower, we check if any of the advanced settings are different from the defaults. If some are, indicate to the user that he will lose his custom settings when pausing.

cjcenizal

Tested locally, code LGTM! I had a few UX suggestions which we could address in later PRs, as well as a few other small suggestions.

cjcenizal · 2019-01-24T17:17:20Z

...ck/plugins/cross_cluster_replication/public/app/components/follower_index_resume_provider.js

            <Fragment>
              <p>
                <FormattedMessage
                  id="xpack.crossClusterReplication.resumeFollowerIndex.confirmModal.multipleResumeDescription"
-                  defaultMessage="These follower indices will be resumed:"
+                  defaultMessage="These follower indices will be resumed using default settings. To resume using
+                    different settings, edit each follower index instead:"


If we're offering an alternative to the user in the modal, should we also add a button (perhaps with the empty style) for editing the index? This would require significant changes since we'd have to use regular EuiModal instead of EuiConfirmModal. Maybe we could just add this to the roadmap as a nice-to-have?

I will link edit this follower index to the follower form instead, so that we don't have to switch modal components 😄

^ this will be done in a followup PR to address more design feedback for this area

cjcenizal · 2019-01-24T17:21:22Z

...ation/public/app/sections/home/follower_indices_list/components/context_menu/context_menu.js

@@ -22,6 +22,8 @@ import {
  FollowerIndexUnfollowProvider
 } from '../../../../../components';

+import { getIndexListUri } from '../../../../../../../../index_management/public/services/navigation';


Good point! We could even re-export internals from Index Management from a root-level "shared" directory, so we wouldn't need to move any files around. This would allow Index Management's modules to be organized in a way that makes the most sense to Index Management, while still exposing some select functionality to other plugins.

// index_management/public/shared/index.js export { getIndexListUri } from './services/navigation';

cjcenizal · 2019-01-24T17:24:05Z

...ation/public/app/sections/home/follower_indices_list/components/context_menu/context_menu.js

@@ -109,7 +109,7 @@ export class ContextMenuUi extends PureComponent {

          {
            activeFollowerIndexNames.length ? (
-              <FollowerIndexPauseProvider>
+              <FollowerIndexPauseProvider onConfirm={this.closePopover}>


Can we close the popover as soon as any option is selected? It looks strange for it to still be available when the user's focus should be on the modal.

it's handy to have it open if the user clicks Cancel. however, I see that the z-index of the overlay does not block out the context menu in the detail panel (it does block it out for the context menu in the table, however). will investigate

cjcenizal · 2019-01-24T17:30:21Z

...ation/public/app/sections/home/follower_indices_list/components/context_menu/context_menu.js

+              >
+                <FormattedMessage
+                  id="xpack.crossClusterReplication.followerIndex.contextMenu.viewIndexManagementLabel"
+                  defaultMessage="View in Index Management"


What do you think of moving this into the form row actions menu and removing it from the "Manage" button in both the table and the detail panel? It seems awkward for a user to select a single row just to try to view it index management. I think it'd more natural to expect it to appear when looking inside the row's actions. Also, the word "Manage" implies you're doing something to the follower index, as opposed to viewing it in another app so it seems a bit incongruous.

In the detail panel, it's also redundant since we already have a link for viewing the index in Index Management. If we wanted to make it pop out more, we could move it into the footer but we could explore that later when we're polishing the UI.

good idea for both places!

^ will implement in followup

cjcenizal · 2019-01-24T17:34:35Z

...ation/public/app/sections/home/follower_indices_list/components/detail_panel/detail_panel.js

+                  <EuiFlexItem>
+                    <EuiDescriptionListTitle>
+                      <EuiTitle size="xs">
+                        <FormattedMessage


If we're using the same string everywhere in the same context, e.g. "Max read request operation count" as a label for a section or field, then yes I agree. I think we could safely refer to a single instance of each string in multiple places without interfering with the translators' work. I also think it could be easy to follow while reading the code if we name the variables well.

cjcenizal · 2019-01-24T17:36:33Z

...tions/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js

-            />
+        render: (isPaused) => {
+          return isPaused ? (
+            <EuiHealth color="warning">


What do you think of using gray instead? I used gray to indicate "Inactive" status of rollup jobs because it seemed the most inert. I usually would expect yellow to indicate a non-critical problem.

let's bring this up in design review - I think gray works for "stopped" in rollup jobs, but yellow reflects "paused" better to me (though the difference between "stopped" and "paused" is negligible..)

cjcenizal · 2019-01-24T17:37:28Z

x-pack/plugins/cross_cluster_replication/public/app/services/follower_index_default_settings.js

+
+export const getSettingDefault = (name) => {
+  if(!defaultSettings[name]) {
+    throw new Error(`Unknown setting ${name}`);


This string will probably be shown to the user eventually, e.g. within the fatal error screen, so I think we need to internationalize it.

to me, throw new Error() is for internal code usage, any messages meant for user consumption from thrown errors should be displayed via catch() blocks. I also don't think the fatal error screen necessarily needs to be internationalized because it's meant for last-resort debugging/stack trace

elasticmachine · 2019-01-24T21:39:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

jen-huang · 2019-01-24T21:45:10Z

retest

elasticmachine · 2019-01-24T22:32:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* [CCR] Refactor redux for Auto-follow pattern detail panel (elastic#27491) * [CCR] Refactor redux for Auto-follow pattern detail panel * [CCR] Small refactor * [CCR] Change to present tense * [CCR] Display auto-follow pattern name even if it does not exist * [CCR] Use href to edit auto-follow pattern + remove middelware to update "pattern" query params * [CCR] Fix navigation back bug + set 2 ids for detail and edit an auto-follow pattern * [CCR] Replace api middleware with redux-thunk action * [CCR] Show detail footer close button even when cluster is not valid * [CCR] Add endpoints for fetching and creating follower indices (elastic#27646) * Add GET /follower_indices endpoint with deserialization logic and tests. * Add POST /follower_indices endpoint with serialization logic and tests. * [CCR] Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable (elastic#27647) * Use componentDidUpdate instead of getDerivedStateFromProps. * Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable. * Add jest mock for eui `makeId()` utility and get deterministic aria IDs for snapshots * Update snapshot for Remote Cluster list test * [CCR] Follower indices table and detail panel (elastic#27804) * Store for follower indices * Initial work for follower indices table and detail panel * Fix load auto-follow stats load as middleware was removed * [CCR] Create follower index UI form (elastic#27864) * Initial setup Follower Index form * Working form without client validation * Add client side validation for follower index * Add client validation to check if index already exist * Improve error message when leader index does not exist * Remove update method for follower index * Clear api error on field change * Fix i18n error * Update snapshots * [CCR] Add pause, resume, and unfollow actions for follower indices (elastic#28305) * Add pause and resume follower index routes * Add unfollow route * Add api methods for new routes * Adjust routes to have bulk capabilities, add corresponding actions * Refresh list after pausing/resuming, remove items after unfollowing * First pass at UI for pause and unfollow (and resume, but that is not visible due to ES stats response) * Handle additional conditions needed for unfollowing leader index, add placeholder code to deduce paused status * PR feedback * [CCR] Advanced settings UI for follower indices (elastic#28267) * Add client side validation of advanced settings form * Move form entry row to separate component * Add server side serialization for advanced settings * Ignore advanced settings input when that section is hidden. - Cache and restore input when the section is shown again. * [CCR] Show remote cluster validation in CCR forms, and add edit follower index (elastic#28778) * [CCR] Advanced settings component * Remove preview active on toggle settings * Add client side validation of advanced settings form * Move form entry row to separate component * Add title to panel * Add i18n translation of advanced settings * Update Follower index form with toggle for advanced settings * Add server side serialisation for advanced settings * Make code review changes * Fix test: mock constant dependency * Add section to edit follower index * Show confirm modal before updating follower index * Add edit icon in table + update server endpoint to pause / resume * [CCR] Show remote cluster validation in follower index form & auto-follow pattern form * PR feedback, cleanup form sizes, add redirect to edit remote cluster * Fix routing, remove unused code, adjust auto follow pattern edit loading error page * Adjust error messages and make remote cluster not found edit page the same * Fix functionality as result of merge * Fix validation, reorder actions, fix tests, and address feedback * PR feedback and fix validation pt 2 * Adjust remote cluster validation * Fix i18n * Fix api error not showing on add follower form * [CCR] Integrate new follower index info ES API (elastic#29153) * Integrate new follower index info ES API * Collate data from follower stats and info apis when retrieving all followers and single follower * Add follower settings info to detail panel * Add paused/active UI state * Surface follower default settings to UI * Adjust tests * Address PR feedback * Update snapshots * [CCR] Surface license errors in-app and refine permissions error UI. (elastic#29228) * Fix camelcasing bug in XPackInfo. * Silently swallow API error when checking for index name availability. * Fix typo in followerIndexForm fatal error. * Add permissions check before allowing user to access the app. * Refine wording of CCR permission denied page, to specify cluster privileges. (elastic#29533) * [CCR] Improve form error handling and general UX (elastic#29419) * Remove unnecessary eslint disable-line * [CCR] Implement Advanced Settings design feedback (elastic#29543) * Use EuiSwitch to toggle advanced settings in Create Follower Index form. * Move 'optional' from each Advanced Setting field to the section heading. * Change Advanced Settings switch label and description to emphasize that you can customize them or use the defaults. * Prepopulate Advanced Settings fields with default values. * When editing a follower index, check if advanced settings have been edited and open them if so. * Add 'Reset to default' button below advanced settings fields if their values are different than the default. * Remove 'Default' copy from Advanced Settings descriptions. * Simplify toggleAdvancedSettings function, add comments, and fix React console error. * [CCR] Follower index list fixes from design feedback (elastic#29484) * Delete remote cluster settings before updating * Fix detail panel z-index * Remove default descriptor from follower index detail panel setting values * Follower index confirm action copy adjustments * Change z-index styling to use EUI vars * [CCR] Improve remote clusters test coverage (elastic#29487) * Add Jest test for RemoteClusterForm validation state. * Extract validation functions out of RemoteClusterForm and add unit tests. - Return null instead of undefined from validators. * Add unit tests for different types of remote clusters in RemoteClusterTable. * Add unit test for RemoteClusterList empty prompt. * Add tests verifying behavior for row link, row delete button, and detail panel delete button. - Use getRouterLinkProps to assign onClick and href to edit buttons in row and detail panel. * [CCR] Adjust spacing around descriptions in list views, link to transport port docs, etc (elastic#29789) * Adjust spacing around description around descriptions in list views so that it's even on top and bottom. * Add link to transport port docs from Remote Cluster form. * Move 'View in Index Management' link from the detail panel body into the footer. * Re-order follower index form sections: remote cluster, leader index, follower index. (elastic#29885) * Fix deep-linking to follower index after creating/updating it. (elastic#29865) * [CCR] Copy edits (elastic#29676) * Use 'Resume/pause data replication' in context menu and row actions. * Update copy of 'Update' confirm modal for a paused follower index. * Update copy of 'Update' confirm modal for an active follower index. * Update copy of 'Pause data replication' confirm modal. * Update copy of 'Resume data replication' confirm modal. * Update copy for permissions check. * Update copy of table empty state. * Update copy around tables. * Update form copy. * Update copy for RemoteClustersFormField callouts. * Convert 'data replication' -> 'replication'. * Update copy for Unfollow confirm modal. * Update copy for form API error and Auto-follow Patterns table. * Update form save button labels to be 'Create' and 'Update'. * Move API errors to bottom of form, into same position as sync validation errors. Remove spacer from SectionError implementation. * [CCR] Open index after unfollowing leader (elastic#29887) * Open index after unfollowing leader, fix some variable names * Fix typo * Add comment * [CCR] IE and Screen reader accesibility (elastic#29731) * Fix api endpoit for auto-follow stats * Prevent letter wrapping in IE for the Remote cluster "connection" table column * Move inline style to CSS class to fix IE flex bug * [CCR] Add callout to paused follower index detail panel (elastic#30013) * Add callout to paused follower index detail panel * Update copy * Skip call to ccr stats api if follower index is paused (elastic#30027) * [CCR] Add integration tests for follower indices (elastic#30064) * [CCR] Add integration tests for follower indices * Import advanced settings value from app constants

* [CCR] Refactor redux for Auto-follow pattern detail panel (#27491) * [CCR] Refactor redux for Auto-follow pattern detail panel * [CCR] Small refactor * [CCR] Change to present tense * [CCR] Display auto-follow pattern name even if it does not exist * [CCR] Use href to edit auto-follow pattern + remove middelware to update "pattern" query params * [CCR] Fix navigation back bug + set 2 ids for detail and edit an auto-follow pattern * [CCR] Replace api middleware with redux-thunk action * [CCR] Show detail footer close button even when cluster is not valid * [CCR] Add endpoints for fetching and creating follower indices (#27646) * Add GET /follower_indices endpoint with deserialization logic and tests. * Add POST /follower_indices endpoint with serialization logic and tests. * [CCR] Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable (#27647) * Use componentDidUpdate instead of getDerivedStateFromProps. * Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable. * Add jest mock for eui `makeId()` utility and get deterministic aria IDs for snapshots * Update snapshot for Remote Cluster list test * [CCR] Follower indices table and detail panel (#27804) * Store for follower indices * Initial work for follower indices table and detail panel * Fix load auto-follow stats load as middleware was removed * [CCR] Create follower index UI form (#27864) * Initial setup Follower Index form * Working form without client validation * Add client side validation for follower index * Add client validation to check if index already exist * Improve error message when leader index does not exist * Remove update method for follower index * Clear api error on field change * Fix i18n error * Update snapshots * [CCR] Add pause, resume, and unfollow actions for follower indices (#28305) * Add pause and resume follower index routes * Add unfollow route * Add api methods for new routes * Adjust routes to have bulk capabilities, add corresponding actions * Refresh list after pausing/resuming, remove items after unfollowing * First pass at UI for pause and unfollow (and resume, but that is not visible due to ES stats response) * Handle additional conditions needed for unfollowing leader index, add placeholder code to deduce paused status * PR feedback * [CCR] Advanced settings UI for follower indices (#28267) * Add client side validation of advanced settings form * Move form entry row to separate component * Add server side serialization for advanced settings * Ignore advanced settings input when that section is hidden. - Cache and restore input when the section is shown again. * [CCR] Show remote cluster validation in CCR forms, and add edit follower index (#28778) * [CCR] Advanced settings component * Remove preview active on toggle settings * Add client side validation of advanced settings form * Move form entry row to separate component * Add title to panel * Add i18n translation of advanced settings * Update Follower index form with toggle for advanced settings * Add server side serialisation for advanced settings * Make code review changes * Fix test: mock constant dependency * Add section to edit follower index * Show confirm modal before updating follower index * Add edit icon in table + update server endpoint to pause / resume * [CCR] Show remote cluster validation in follower index form & auto-follow pattern form * PR feedback, cleanup form sizes, add redirect to edit remote cluster * Fix routing, remove unused code, adjust auto follow pattern edit loading error page * Adjust error messages and make remote cluster not found edit page the same * Fix functionality as result of merge * Fix validation, reorder actions, fix tests, and address feedback * PR feedback and fix validation pt 2 * Adjust remote cluster validation * Fix i18n * Fix api error not showing on add follower form * [CCR] Integrate new follower index info ES API (#29153) * Integrate new follower index info ES API * Collate data from follower stats and info apis when retrieving all followers and single follower * Add follower settings info to detail panel * Add paused/active UI state * Surface follower default settings to UI * Adjust tests * Address PR feedback * Update snapshots * [CCR] Surface license errors in-app and refine permissions error UI. (#29228) * Fix camelcasing bug in XPackInfo. * Silently swallow API error when checking for index name availability. * Fix typo in followerIndexForm fatal error. * Add permissions check before allowing user to access the app. * Refine wording of CCR permission denied page, to specify cluster privileges. (#29533) * [CCR] Improve form error handling and general UX (#29419) * Remove unnecessary eslint disable-line * [CCR] Implement Advanced Settings design feedback (#29543) * Use EuiSwitch to toggle advanced settings in Create Follower Index form. * Move 'optional' from each Advanced Setting field to the section heading. * Change Advanced Settings switch label and description to emphasize that you can customize them or use the defaults. * Prepopulate Advanced Settings fields with default values. * When editing a follower index, check if advanced settings have been edited and open them if so. * Add 'Reset to default' button below advanced settings fields if their values are different than the default. * Remove 'Default' copy from Advanced Settings descriptions. * Simplify toggleAdvancedSettings function, add comments, and fix React console error. * [CCR] Follower index list fixes from design feedback (#29484) * Delete remote cluster settings before updating * Fix detail panel z-index * Remove default descriptor from follower index detail panel setting values * Follower index confirm action copy adjustments * Change z-index styling to use EUI vars * [CCR] Improve remote clusters test coverage (#29487) * Add Jest test for RemoteClusterForm validation state. * Extract validation functions out of RemoteClusterForm and add unit tests. - Return null instead of undefined from validators. * Add unit tests for different types of remote clusters in RemoteClusterTable. * Add unit test for RemoteClusterList empty prompt. * Add tests verifying behavior for row link, row delete button, and detail panel delete button. - Use getRouterLinkProps to assign onClick and href to edit buttons in row and detail panel. * [CCR] Adjust spacing around descriptions in list views, link to transport port docs, etc (#29789) * Adjust spacing around description around descriptions in list views so that it's even on top and bottom. * Add link to transport port docs from Remote Cluster form. * Move 'View in Index Management' link from the detail panel body into the footer. * Re-order follower index form sections: remote cluster, leader index, follower index. (#29885) * Fix deep-linking to follower index after creating/updating it. (#29865) * [CCR] Copy edits (#29676) * Use 'Resume/pause data replication' in context menu and row actions. * Update copy of 'Update' confirm modal for a paused follower index. * Update copy of 'Update' confirm modal for an active follower index. * Update copy of 'Pause data replication' confirm modal. * Update copy of 'Resume data replication' confirm modal. * Update copy for permissions check. * Update copy of table empty state. * Update copy around tables. * Update form copy. * Update copy for RemoteClustersFormField callouts. * Convert 'data replication' -> 'replication'. * Update copy for Unfollow confirm modal. * Update copy for form API error and Auto-follow Patterns table. * Update form save button labels to be 'Create' and 'Update'. * Move API errors to bottom of form, into same position as sync validation errors. Remove spacer from SectionError implementation. * [CCR] Open index after unfollowing leader (#29887) * Open index after unfollowing leader, fix some variable names * Fix typo * Add comment * [CCR] IE and Screen reader accesibility (#29731) * Fix api endpoit for auto-follow stats * Prevent letter wrapping in IE for the Remote cluster "connection" table column * Move inline style to CSS class to fix IE flex bug * [CCR] Add callout to paused follower index detail panel (#30013) * Add callout to paused follower index detail panel * Update copy * Skip call to ccr stats api if follower index is paused (#30027) * [CCR] Add integration tests for follower indices (#30064) * [CCR] Add integration tests for follower indices * Import advanced settings value from app constants

* [CCR] Follower index CRUD (#27936) * [CCR] Refactor redux for Auto-follow pattern detail panel (#27491) * [CCR] Refactor redux for Auto-follow pattern detail panel * [CCR] Small refactor * [CCR] Change to present tense * [CCR] Display auto-follow pattern name even if it does not exist * [CCR] Use href to edit auto-follow pattern + remove middelware to update "pattern" query params * [CCR] Fix navigation back bug + set 2 ids for detail and edit an auto-follow pattern * [CCR] Replace api middleware with redux-thunk action * [CCR] Show detail footer close button even when cluster is not valid * [CCR] Add endpoints for fetching and creating follower indices (#27646) * Add GET /follower_indices endpoint with deserialization logic and tests. * Add POST /follower_indices endpoint with serialization logic and tests. * [CCR] Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable (#27647) * Use componentDidUpdate instead of getDerivedStateFromProps. * Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable. * Add jest mock for eui `makeId()` utility and get deterministic aria IDs for snapshots * Update snapshot for Remote Cluster list test * [CCR] Follower indices table and detail panel (#27804) * Store for follower indices * Initial work for follower indices table and detail panel * Fix load auto-follow stats load as middleware was removed * [CCR] Create follower index UI form (#27864) * Initial setup Follower Index form * Working form without client validation * Add client side validation for follower index * Add client validation to check if index already exist * Improve error message when leader index does not exist * Remove update method for follower index * Clear api error on field change * Fix i18n error * Update snapshots * [CCR] Add pause, resume, and unfollow actions for follower indices (#28305) * Add pause and resume follower index routes * Add unfollow route * Add api methods for new routes * Adjust routes to have bulk capabilities, add corresponding actions * Refresh list after pausing/resuming, remove items after unfollowing * First pass at UI for pause and unfollow (and resume, but that is not visible due to ES stats response) * Handle additional conditions needed for unfollowing leader index, add placeholder code to deduce paused status * PR feedback * [CCR] Advanced settings UI for follower indices (#28267) * Add client side validation of advanced settings form * Move form entry row to separate component * Add server side serialization for advanced settings * Ignore advanced settings input when that section is hidden. - Cache and restore input when the section is shown again. * [CCR] Show remote cluster validation in CCR forms, and add edit follower index (#28778) * [CCR] Advanced settings component * Remove preview active on toggle settings * Add client side validation of advanced settings form * Move form entry row to separate component * Add title to panel * Add i18n translation of advanced settings * Update Follower index form with toggle for advanced settings * Add server side serialisation for advanced settings * Make code review changes * Fix test: mock constant dependency * Add section to edit follower index * Show confirm modal before updating follower index * Add edit icon in table + update server endpoint to pause / resume * [CCR] Show remote cluster validation in follower index form & auto-follow pattern form * PR feedback, cleanup form sizes, add redirect to edit remote cluster * Fix routing, remove unused code, adjust auto follow pattern edit loading error page * Adjust error messages and make remote cluster not found edit page the same * Fix functionality as result of merge * Fix validation, reorder actions, fix tests, and address feedback * PR feedback and fix validation pt 2 * Adjust remote cluster validation * Fix i18n * Fix api error not showing on add follower form * [CCR] Integrate new follower index info ES API (#29153) * Integrate new follower index info ES API * Collate data from follower stats and info apis when retrieving all followers and single follower * Add follower settings info to detail panel * Add paused/active UI state * Surface follower default settings to UI * Adjust tests * Address PR feedback * Update snapshots * [CCR] Surface license errors in-app and refine permissions error UI. (#29228) * Fix camelcasing bug in XPackInfo. * Silently swallow API error when checking for index name availability. * Fix typo in followerIndexForm fatal error. * Add permissions check before allowing user to access the app. * Refine wording of CCR permission denied page, to specify cluster privileges. (#29533) * [CCR] Improve form error handling and general UX (#29419) * Remove unnecessary eslint disable-line * [CCR] Implement Advanced Settings design feedback (#29543) * Use EuiSwitch to toggle advanced settings in Create Follower Index form. * Move 'optional' from each Advanced Setting field to the section heading. * Change Advanced Settings switch label and description to emphasize that you can customize them or use the defaults. * Prepopulate Advanced Settings fields with default values. * When editing a follower index, check if advanced settings have been edited and open them if so. * Add 'Reset to default' button below advanced settings fields if their values are different than the default. * Remove 'Default' copy from Advanced Settings descriptions. * Simplify toggleAdvancedSettings function, add comments, and fix React console error. * [CCR] Follower index list fixes from design feedback (#29484) * Delete remote cluster settings before updating * Fix detail panel z-index * Remove default descriptor from follower index detail panel setting values * Follower index confirm action copy adjustments * Change z-index styling to use EUI vars * [CCR] Improve remote clusters test coverage (#29487) * Add Jest test for RemoteClusterForm validation state. * Extract validation functions out of RemoteClusterForm and add unit tests. - Return null instead of undefined from validators. * Add unit tests for different types of remote clusters in RemoteClusterTable. * Add unit test for RemoteClusterList empty prompt. * Add tests verifying behavior for row link, row delete button, and detail panel delete button. - Use getRouterLinkProps to assign onClick and href to edit buttons in row and detail panel. * [CCR] Adjust spacing around descriptions in list views, link to transport port docs, etc (#29789) * Adjust spacing around description around descriptions in list views so that it's even on top and bottom. * Add link to transport port docs from Remote Cluster form. * Move 'View in Index Management' link from the detail panel body into the footer. * Re-order follower index form sections: remote cluster, leader index, follower index. (#29885) * Fix deep-linking to follower index after creating/updating it. (#29865) * [CCR] Copy edits (#29676) * Use 'Resume/pause data replication' in context menu and row actions. * Update copy of 'Update' confirm modal for a paused follower index. * Update copy of 'Update' confirm modal for an active follower index. * Update copy of 'Pause data replication' confirm modal. * Update copy of 'Resume data replication' confirm modal. * Update copy for permissions check. * Update copy of table empty state. * Update copy around tables. * Update form copy. * Update copy for RemoteClustersFormField callouts. * Convert 'data replication' -> 'replication'. * Update copy for Unfollow confirm modal. * Update copy for form API error and Auto-follow Patterns table. * Update form save button labels to be 'Create' and 'Update'. * Move API errors to bottom of form, into same position as sync validation errors. Remove spacer from SectionError implementation. * [CCR] Open index after unfollowing leader (#29887) * Open index after unfollowing leader, fix some variable names * Fix typo * Add comment * [CCR] IE and Screen reader accesibility (#29731) * Fix api endpoit for auto-follow stats * Prevent letter wrapping in IE for the Remote cluster "connection" table column * Move inline style to CSS class to fix IE flex bug * [CCR] Add callout to paused follower index detail panel (#30013) * Add callout to paused follower index detail panel * Update copy * Skip call to ccr stats api if follower index is paused (#30027) * [CCR] Add integration tests for follower indices (#30064) * [CCR] Add integration tests for follower indices * Import advanced settings value from app constants * Disable flaky follower indices API integration tests.

jen-huang added 2 commits January 22, 2019 21:38

Integrate new follower index info ES API

0dda060

* Collate data from follower stats and info apis when retrieving all followers and single follower * Add follower settings info to detail panel * Add paused/active UI state * Surface follower default settings to UI

Adjust tests

a2e35a2

jen-huang added Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jan 23, 2019

jen-huang requested review from cjcenizal and sebelga January 23, 2019 06:24

sebelga reviewed Jan 24, 2019

View reviewed changes

sebelga approved these changes Jan 24, 2019

View reviewed changes

cjcenizal approved these changes Jan 24, 2019

View reviewed changes

Address PR feedback

e4391cf

jen-huang merged commit b7501de into elastic:feature/ccr Jan 24, 2019

jen-huang deleted the feature/ccr-follower_info branch January 24, 2019 22:52

cjcenizal mentioned this pull request Feb 5, 2019

[CCR] Follower index CRUD #27936

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CCR] Integrate new follower index info ES API #29153

[CCR] Integrate new follower index info ES API #29153

jen-huang commented Jan 23, 2019

elasticmachine commented Jan 23, 2019

elasticmachine commented Jan 23, 2019

yaronp68 commented Jan 23, 2019

sebelga Jan 24, 2019

cjcenizal Jan 24, 2019

jen-huang Jan 24, 2019

sebelga Jan 24, 2019

cjcenizal Jan 24, 2019

jen-huang Jan 24, 2019

sebelga Jan 24, 2019

sebelga Jan 24, 2019

sebelga left a comment

cjcenizal left a comment

cjcenizal Jan 24, 2019

jen-huang Jan 24, 2019

jen-huang Jan 24, 2019

cjcenizal Jan 24, 2019

cjcenizal Jan 24, 2019

jen-huang Jan 24, 2019

cjcenizal Jan 24, 2019

jen-huang Jan 24, 2019 •

edited

Loading

jen-huang Jan 24, 2019

cjcenizal Jan 24, 2019

cjcenizal Jan 24, 2019

jen-huang Jan 24, 2019

cjcenizal Jan 24, 2019

jen-huang Jan 24, 2019

elasticmachine commented Jan 24, 2019

jen-huang commented Jan 24, 2019

elasticmachine commented Jan 24, 2019

[CCR] Integrate new follower index info ES API #29153

[CCR] Integrate new follower index info ES API #29153

Conversation

jen-huang commented Jan 23, 2019

Table view

Paused follower detail panel

Active follower detail panel

Resuming a paused follower

Editing a paused follower

Misc

elasticmachine commented Jan 23, 2019

elasticmachine commented Jan 23, 2019

💚 Build Succeeded

yaronp68 commented Jan 23, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebelga left a comment

Choose a reason for hiding this comment

cjcenizal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jen-huang Jan 24, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Jan 24, 2019

💔 Build Failed

jen-huang commented Jan 24, 2019

elasticmachine commented Jan 24, 2019

💚 Build Succeeded

jen-huang Jan 24, 2019 •

edited

Loading