[Watcher] Add Webhook Action type on client #29818

sebelga · 2019-02-01T11:06:56Z

This PR adds the missing action types on the Watcher UI client. Currently, we have an issue related to the Webhook action missing but there are other action types missing.

To unblock #29787 this PR could be merged for the Webhook action that was missing. I will add though the other missing action types to avoid future bugs.

Note: There are several static properties defined on each action class but I can't seem to find where in the UI they are actually used. I put a comment at the bottom of the webhook.action.js file about it.

How to test

Start by creating a watcher with a webhook action in the dev console

PUT _watcher/watch/my-watch
{
  "trigger" : {
    "schedule" : { "cron" : "0/5 * * * * ?" }
  },
  "input" : {
    "search" : {
      "request" : {
        "indices" : [
          "kibana_sample_data_flights"
        ],
        "body" : {
          "query" : {
            "bool" : {
              "must" : {
                "match": {
                   "Carrier": "Kibana Airlines"
                }
              }
            }
          }
        }
      }
    }
  },
  "condition" : {
    "compare" : { "ctx.payload.hits.total" : { "gt" : 0 }}
  },
  "actions" : {
    "my_webhook" : { 
      "webhook" : {
        "method" : "POST", 
        "host" : "localhost", 
        "port" : 3000, 
        "path": ":/{{ctx.watch_id}}", 
        "body" : "id={{ctx.watch_id}}, hits={{ctx.payload.hits.total}}" 
      }
    }
  }
}

Got to the Watcher app and click on "edit" on the row of the created watcher

What we want to test is making sure that the body of the HTTP request contains the corresonding values that we have defined in the JSON editor (and of course that the application does not crash) when saving the watcher.

elasticmachine · 2019-02-01T11:07:39Z

Pinging @elastic/es-ui

elasticmachine · 2019-02-01T11:54:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

bmcconaghy

Tested locally, code LGTM

This reverts commit f3aadc0.

elasticmachine · 2019-02-01T16:45:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

sebelga · 2019-02-01T17:40:55Z

retest

elasticmachine · 2019-02-01T18:20:12Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cjcenizal

Tested locally, fixed the bug reported by the user. Code LGTM! Just found a couple typos in comments. Great work acting on this so quickly, Seb!

cjcenizal · 2019-02-01T19:22:36Z

x-pack/plugins/watcher/public/models/action/webhook.action.js

+   * is where it seems that this is read. But I can't access that component navigatint the UI
+   *
+   */
+  // static typeName = i18n.translate('xpack.watcher.models.webhookAction.typeName', {


Is this commented-out code needed?

I was hoping the reviewer(s) to be able to answer this commented code. 😊 Because it has been copied from other watcher action but those static variables don't seem to be used anywhere in the UI.
@bmcconaghy do you know if there used to be a UI form to define the watcher actions? (instead of the advanced JSON editor that we have now). It seems that those static properties were there for that purpose.

I think there was a draft of such a feature but AFAICR it never made it into an actual release. @chrisronline may remember differently/better.

I am not familiar with those comments at all unfortunately

Ok thanks @chrisronline

cjcenizal · 2019-02-01T19:22:53Z

x-pack/plugins/watcher/public/models/action/webhook.action.js

+   * the "advanced watcher" creation through the JSON editor.
+   *
+   * ---> ./components/watch_actions/components/watch_action/watch_actions.html
+   * is where it seems that this is read. But I can't access that component navigatint the UI


Typo: navigatint -> in

cjcenizal · 2019-02-01T19:23:05Z

x-pack/plugins/watcher/public/models/action/webhook.action.js

+  /**
+   * NOTE:
+   *
+   * I don't seem to find in the UI where those static properties are actuall used.


Typo: actuall -> actually

Don' look at the typo, look at the text! 😄 hahaha. This will be eventually removed.

cjcenizal · 2019-02-01T19:55:46Z

Retest

elasticmachine · 2019-02-01T20:34:47Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cjcenizal · 2019-02-01T20:49:38Z

Looks like these CI failures are the same ones intermittently occurring on master. Kibana team will have to fix this in master before we merge. I believe Spencer is looking into this.

cjcenizal · 2019-02-02T22:52:33Z

CI has been fixed in master so now this branch just needs to merge those changes in.

…ok-action

elasticmachine · 2019-02-04T12:02:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

sebelga · 2019-02-04T12:10:52Z

I am going to merge this PR so we have a fix for the #29787 bug. I will create a separate PR for the other missing Watcher actions.

* Add missing Webhook action on client

* Add missing Webhook action on client. Fixes #29787

* Add missing Webhook action on client Fixes #29787

cjcenizal · 2019-02-05T15:03:18Z

Follow-up PR with other actions is here: #30043

cjcenizal · 2019-02-08T17:41:35Z

This is a step towards addressing #18059.

elasticmachine · 2019-02-14T21:41:04Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

bhavyarm · 2019-02-14T22:54:27Z

@sebelga @cjcenizal when I try to test this PR - I get error. I am using the watch in description. This is on BC1 of 6.6.1. Can you please tell me whats happening?

Logs:

 error  [22:27:22.409] [warning][process] UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'reject' of undefined
    at heap.(anonymous function).onFunctionNotFound.then.catch.e (/Users/bhavyarajumandya/Desktop/release_6.6.1/kibana-6.6.1-darwin-x86_64/src/legacy/core_plugins/interpreter/server/lib/route_expression/thread/index.js:56:38)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at emitWarning (internal/process/promises.js:81:15)
    at emitPromiseRejectionWarnings (internal/process/promises.js:120:9)
    at process._tickCallback (internal/process/next_tick.js:69:34)
 error  [22:27:22.409] [warning][process] TypeError: Cannot read property 'reject' of undefined
    at heap.(anonymous function).onFunctionNotFound.then.catch.e (/Users/bhavyarajumandya/Desktop/release_6.6.1/kibana-6.6.1-darwin-x86_64/src/legacy/core_plugins/interpreter/server/lib/route_expression/thread/index.js:56:38)
    at process._tickCallback (internal/process/next_tick.js:68:7)

cjcenizal · 2019-02-14T22:57:45Z

@bhavyarm I believe this only made it into 6.6.1.

bhavyarm · 2019-02-15T12:44:55Z

@cjcenizal apologies 6.6.1. Sorry too many releases. The error I am seeing is on 6.6.1. I have corrected my comment.

bhavyarm · 2019-02-15T16:23:29Z

This works fine apart from a copy bug. Logging it in a bit. Thanks @sebelga

[Watcher] Add missing Webhook action on client

baee3e7

sebelga requested review from cjcenizal and jen-huang February 1, 2019 11:07

sebelga added bug Fixes for quality problems that affect the customer experience Feature:Watcher Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Feb 1, 2019

Small refactor

8360b5a

bmcconaghy approved these changes Feb 1, 2019

View reviewed changes

sebelga added 2 commits February 1, 2019 17:03

[Watcher] Add missing Index action on client

f3aadc0

Revert "[Watcher] Add missing Index action on client"

560058c

This reverts commit f3aadc0.

cjcenizal approved these changes Feb 1, 2019

View reviewed changes

cjcenizal added v7.0.0 v6.7.0 v6.6.1 labels Feb 2, 2019

Merge remote-tracking branch 'upstream/master' into fix/watcher-webho…

108a2ab

…ok-action

sebelga merged commit 2c257df into elastic:master Feb 4, 2019

sebelga mentioned this pull request Feb 4, 2019

[6.x] [Watcher] Add missing Action types on client (#29818) #29941

Merged

sebelga added a commit to sebelga/kibana that referenced this pull request Feb 4, 2019

[Watcher] Add missing Action types on client (elastic#29818)

c085ffa

* Add missing Webhook action on client

sebelga mentioned this pull request Feb 4, 2019

[6.6] [Watcher] Add missing Action types on client (#29818) #29942

Merged

sebelga added a commit to sebelga/kibana that referenced this pull request Feb 4, 2019

[Watcher] Add missing Action types on client (elastic#29818)

10fce2f

* Add missing Webhook action on client

sebelga added a commit that referenced this pull request Feb 4, 2019

[Watcher] Add missing Action types on client (#29818) (#29942)

6b3170a

* Add missing Webhook action on client. Fixes #29787

sebelga added a commit that referenced this pull request Feb 4, 2019

[Watcher] Add missing Action types on client (#29818) (#29941)

7c64159

* Add missing Webhook action on client Fixes #29787

cjcenizal changed the title ~~[Watcher] Add missing Action types on client~~ [Watcher] Add missing Action types on client (webhook) Feb 5, 2019

cjcenizal mentioned this pull request Feb 5, 2019

Unable to save any watcher with an action of webhook as of Kibana 6.6 #29759

Closed

sebelga deleted the fix/watcher-webhook-action branch February 5, 2019 07:29

cjcenizal changed the title ~~[Watcher] Add missing Action types on client (webhook)~~ [Watcher] Add Webhook Action type on client Feb 8, 2019

vpavlushkov mentioned this pull request Feb 12, 2019

Error: “Attempted to create unknown action type pagerduty.” when trying to update a watcher in Kibana #30804

Closed

cjcenizal mentioned this pull request Mar 26, 2019

Watcher UI Create Advanced Watch with Webhook doesn't "Save" #32913

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Watcher] Add Webhook Action type on client #29818

[Watcher] Add Webhook Action type on client #29818

sebelga commented Feb 1, 2019 •

edited by cjcenizal

elasticmachine commented Feb 1, 2019

elasticmachine commented Feb 1, 2019

bmcconaghy left a comment

elasticmachine commented Feb 1, 2019

sebelga commented Feb 1, 2019

elasticmachine commented Feb 1, 2019

cjcenizal left a comment •

edited

cjcenizal Feb 1, 2019

sebelga Feb 4, 2019 •

edited

bmcconaghy Feb 4, 2019

chrisronline Feb 4, 2019

sebelga Feb 5, 2019

cjcenizal Feb 1, 2019

cjcenizal Feb 1, 2019

sebelga Feb 4, 2019

cjcenizal commented Feb 1, 2019

elasticmachine commented Feb 1, 2019

cjcenizal commented Feb 1, 2019

cjcenizal commented Feb 2, 2019

elasticmachine commented Feb 4, 2019

sebelga commented Feb 4, 2019

cjcenizal commented Feb 5, 2019

cjcenizal commented Feb 8, 2019

elasticmachine commented Feb 14, 2019

bhavyarm commented Feb 14, 2019 •

edited

cjcenizal commented Feb 14, 2019

bhavyarm commented Feb 15, 2019

bhavyarm commented Feb 15, 2019

[Watcher] Add Webhook Action type on client #29818

[Watcher] Add Webhook Action type on client #29818

Conversation

sebelga commented Feb 1, 2019 • edited by cjcenizal

How to test

elasticmachine commented Feb 1, 2019

elasticmachine commented Feb 1, 2019

💚 Build Succeeded

bmcconaghy left a comment

Choose a reason for hiding this comment

elasticmachine commented Feb 1, 2019

💔 Build Failed

sebelga commented Feb 1, 2019

elasticmachine commented Feb 1, 2019

💔 Build Failed

cjcenizal left a comment • edited

Choose a reason for hiding this comment

cjcenizal Feb 1, 2019

Choose a reason for hiding this comment

sebelga Feb 4, 2019 • edited

Choose a reason for hiding this comment

bmcconaghy Feb 4, 2019

Choose a reason for hiding this comment

chrisronline Feb 4, 2019

Choose a reason for hiding this comment

sebelga Feb 5, 2019

Choose a reason for hiding this comment

cjcenizal Feb 1, 2019

Choose a reason for hiding this comment

cjcenizal Feb 1, 2019

Choose a reason for hiding this comment

sebelga Feb 4, 2019

Choose a reason for hiding this comment

cjcenizal commented Feb 1, 2019

elasticmachine commented Feb 1, 2019

💔 Build Failed

cjcenizal commented Feb 1, 2019

cjcenizal commented Feb 2, 2019

elasticmachine commented Feb 4, 2019

💚 Build Succeeded

sebelga commented Feb 4, 2019

cjcenizal commented Feb 5, 2019

cjcenizal commented Feb 8, 2019

elasticmachine commented Feb 14, 2019

💔 Build Failed

bhavyarm commented Feb 14, 2019 • edited

cjcenizal commented Feb 14, 2019

bhavyarm commented Feb 15, 2019

bhavyarm commented Feb 15, 2019

sebelga commented Feb 1, 2019 •

edited by cjcenizal

cjcenizal left a comment •

edited

sebelga Feb 4, 2019 •

edited

bhavyarm commented Feb 14, 2019 •

edited