Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Port unit tests to master #29876

Merged
merged 18 commits into from Feb 4, 2019
Merged

[Uptime] Port unit tests to master #29876

merged 18 commits into from Feb 4, 2019

Conversation

justinkambic
Copy link
Contributor

Summary

This PR seeks to introduce Uptime's unit tests to master.

@justinkambic justinkambic added WIP Work in progress v7.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Feb 1, 2019
@justinkambic justinkambic self-assigned this Feb 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@elasticmachine
Copy link
Contributor

💔 Build Failed

@justinkambic
Uptime unit tests6.x (elastic#29280)
3770ce4 
* Add API functional tests for uptime graphQL.

* Remove obsolete code.

* Add CI group for UI functional tests.

* Delete obsolete code, rename heartbeat es archive.

* Refactor adapter methods.

* Refactor adapter methods.

* Attempt to fix ci-group tag error.

* Skip functional app tests until later PR.

* Remove unused code.

* Add unit tests for ping list and snapshot components.

* Add additional unit tests.

* Remove unused variable.
@justinkambic
Update tests for EmptyState component.
cd197fb
@justinkambic
Update ErrorList component tests.
47b781d
@justinkambic
Update monitor list unit test.
5c055ae
@justinkambic
Add tests for EmptyStatusBar component.
a17e661
@justinkambic
Write test for FilterBar component.
d1799c7
@justinkambic
Update PingList test to work with 7.x data.
010e170
@justinkambic
Delete obsolete snapshot.
3f5abf4
@justinkambic
Add test for Snapshot component.
bd08feb
@justinkambic
Update types.
bad5385
@justinkambic
Add snapshot histogram test.
18c3426
@justinkambic
Write tests and improve histogram data formatting function.
9ad26be
@justinkambic
Fix bug and add test to data format function.
61a5ac0
@justinkambic justinkambic force-pushed the uptime_port-unit-tests-from-6.x branch from 59d082c to 61a5ac0 Compare February 3, 2019 04:49
@justinkambic justinkambic added review and removed WIP Work in progress labels Feb 3, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

andrewvc
andrewvc approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinkambic
Copy link
Contributor Author

@andrewvc latergram - this won't affect anything and the code is tested, but the commit was added after your review 916bf3b.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic merged commit e9d0f1b into elastic:master Feb 4, 2019
@justinkambic justinkambic deleted the uptime_port-unit-tests-from-6.x branch February 4, 2019 22:05
@justinkambic
Copy link
Contributor Author

No backport necessary as these tests exist in 6.x already and use different data shapes; it requires dedicated mock data due to breaking changes in HB 6.7 and 7.0.

@justinkambic justinkambic mentioned this pull request Feb 6, 2019
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees

@justinkambic justinkambic

Labels
review Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinkambic @elasticmachine @andrewvc