Populate scope with country name, not only country codes. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate scope with country name, not only country codes. Some firewalls give the country name with the event. Maps use only country code.
redirectTo changed
rashidkpc
pushed a commit
that referenced
this pull request
Oct 6, 2014
Move test server to port 8001
rashidkpc
pushed a commit
that referenced
this pull request
Oct 6, 2014
Move test server to port 8001
abh1nav
pushed a commit
to crowdriff/kibana
that referenced
this pull request
Jan 23, 2015
Mutation fix
lukasolson
added a commit
that referenced
this pull request
Feb 19, 2015
tweak style, add info to propularity
spalger
pushed a commit
that referenced
this pull request
Mar 3, 2016
Makes agg autocomplete rules up to date with ES 2.0 Closes #3
Closed
jbudz
pushed a commit
to jbudz/kibana
that referenced
this pull request
Jun 27, 2016
[npm] update makelogs to version supporting latest es master
Closed
This was referenced Feb 14, 2017
Closed
kimjoar
referenced
this pull request
in kimjoar/kibana
Jul 9, 2017
upgrade deps in preperation for babel6 transition
stacey-gammon
added a commit
that referenced
this pull request
Sep 26, 2017
* Initial check-in to replace gridster with react-grid-layout and reactify panels * # This is a combination of 3 commits. # This is the 1st commit message: Add margin of error to test determining panel widths # This is the commit message #2: use real kibana version when creating panel data. Will make future conversions easier. # This is the commit message #3: Fix lint errors * Add margin of error to test determining panel widths use real kibana version when creating panel data. Will make future conversions easier. Move default height and width to dashboard_constants so those that need it don't end up including extra stuff like ui/chrome * Remove unnecessary _.once when creating react directives in dashboard.js * Remove unnecessary constructors * Use componentDidMount instead of componentWillMount bc of async calls, and handle case where destroyEmbeddable is not defined. * Remove unnecessary null in classNames * Use loads defaultsDeep instead of Object.assign * use render* instead of get* for functions returning an element * use relative css paths * Use local import path * Switch to local imports and remove need for plugins path in jest tests * Improve accessibility of max/min panel toggle icon * remove unused css Had to implement this via code * disable eslint rule for setState in componentDidMount Am not aware of a better way to handle this, aside from switching to redux, since it’s recommended not to put async calls in componentWillMount. Since I plan to investigate redux next, disabling for now. Open to other’s opinions on the matter. * Use native map instead of lodash * Have the grid handle setting the z-indexes of the right reactgriditem * Make the draggable handle the title, not the whole heading Otherwise the drag event often takes over click events when trying to open the panel options menu and it gets really annoying. * Change from click to mouse down detector in KuiOutsideClickDector so drags also close pop ups. * Fix mistaken commit Code from the redux PR snuck into this one. * Run getEditPath and getTitle async calls in parallel - no need to wait on the return value of one before starting the others. * Fix tests: update snapshots, add promise returns. * version being added to panelData in the wrong spot caused isDirty flag to be true when it shouldn't be * Fix unmounting/mounting problem with panels due to view/edit mode switch * Fix bug where panels get squashed to one side when view mode is changed while a panel is expanded. * Update snapshots to match wrong view mode comparison * Improve naming of a variable * Fix issue with pop over hiding behind tile maps * Previous panel.js included ui/doc_table and ui/visualize - needed to include them in the chain for Dash only mode but not in that file. * Fix bad merge: remove baseline screenshots
stacey-gammon
added a commit
that referenced
this pull request
Oct 2, 2017
* Initial check-in to replace gridster with react-grid-layout and reactify panels * # This is a combination of 3 commits. # This is the 1st commit message: Add margin of error to test determining panel widths # This is the commit message #2: use real kibana version when creating panel data. Will make future conversions easier. # This is the commit message #3: Fix lint errors * Add margin of error to test determining panel widths use real kibana version when creating panel data. Will make future conversions easier. Move default height and width to dashboard_constants so those that need it don't end up including extra stuff like ui/chrome * Remove unnecessary _.once when creating react directives in dashboard.js * Remove unnecessary constructors * Use componentDidMount instead of componentWillMount bc of async calls, and handle case where destroyEmbeddable is not defined. * Remove unnecessary null in classNames * Use loads defaultsDeep instead of Object.assign * use render* instead of get* for functions returning an element * use relative css paths * Use local import path * Switch to local imports and remove need for plugins path in jest tests * Improve accessibility of max/min panel toggle icon * remove unused css Had to implement this via code * disable eslint rule for setState in componentDidMount Am not aware of a better way to handle this, aside from switching to redux, since it’s recommended not to put async calls in componentWillMount. Since I plan to investigate redux next, disabling for now. Open to other’s opinions on the matter. * Use native map instead of lodash * Have the grid handle setting the z-indexes of the right reactgriditem * Make the draggable handle the title, not the whole heading Otherwise the drag event often takes over click events when trying to open the panel options menu and it gets really annoying. * Change from click to mouse down detector in KuiOutsideClickDector so drags also close pop ups. * Fix mistaken commit Code from the redux PR snuck into this one. * Run getEditPath and getTitle async calls in parallel - no need to wait on the return value of one before starting the others. * Fix tests: update snapshots, add promise returns. * version being added to panelData in the wrong spot caused isDirty flag to be true when it shouldn't be * Fix unmounting/mounting problem with panels due to view/edit mode switch * Fix bug where panels get squashed to one side when view mode is changed while a panel is expanded. * Update snapshots to match wrong view mode comparison * Improve naming of a variable * Fix issue with pop over hiding behind tile maps * Previous panel.js included ui/doc_table and ui/visualize - needed to include them in the chain for Dash only mode but not in that file. * Fix bad merge: remove baseline screenshots
chrisronline
referenced
this pull request
in chrisronline/kibana
Nov 20, 2017
* Initial check-in to replace gridster with react-grid-layout and reactify panels * # This is a combination of 3 commits. # This is the 1st commit message: Add margin of error to test determining panel widths # This is the commit message #2: use real kibana version when creating panel data. Will make future conversions easier. # This is the commit message #3: Fix lint errors * Add margin of error to test determining panel widths use real kibana version when creating panel data. Will make future conversions easier. Move default height and width to dashboard_constants so those that need it don't end up including extra stuff like ui/chrome * Remove unnecessary _.once when creating react directives in dashboard.js * Remove unnecessary constructors * Use componentDidMount instead of componentWillMount bc of async calls, and handle case where destroyEmbeddable is not defined. * Remove unnecessary null in classNames * Use loads defaultsDeep instead of Object.assign * use render* instead of get* for functions returning an element * use relative css paths * Use local import path * Switch to local imports and remove need for plugins path in jest tests * Improve accessibility of max/min panel toggle icon * remove unused css Had to implement this via code * disable eslint rule for setState in componentDidMount Am not aware of a better way to handle this, aside from switching to redux, since it’s recommended not to put async calls in componentWillMount. Since I plan to investigate redux next, disabling for now. Open to other’s opinions on the matter. * Use native map instead of lodash * Have the grid handle setting the z-indexes of the right reactgriditem * Make the draggable handle the title, not the whole heading Otherwise the drag event often takes over click events when trying to open the panel options menu and it gets really annoying. * Change from click to mouse down detector in KuiOutsideClickDector so drags also close pop ups. * Fix mistaken commit Code from the redux PR snuck into this one. * Run getEditPath and getTitle async calls in parallel - no need to wait on the return value of one before starting the others. * Fix tests: update snapshots, add promise returns. * version being added to panelData in the wrong spot caused isDirty flag to be true when it shouldn't be * Fix unmounting/mounting problem with panels due to view/edit mode switch * Fix bug where panels get squashed to one side when view mode is changed while a panel is expanded. * Update snapshots to match wrong view mode comparison * Improve naming of a variable * Fix issue with pop over hiding behind tile maps * Previous panel.js included ui/doc_table and ui/visualize - needed to include them in the chain for Dash only mode but not in that file. * Fix bad merge: remove baseline screenshots
chrisronline
referenced
this pull request
in chrisronline/kibana
Dec 1, 2017
* Initial check-in to replace gridster with react-grid-layout and reactify panels * # This is a combination of 3 commits. # This is the 1st commit message: Add margin of error to test determining panel widths # This is the commit message #2: use real kibana version when creating panel data. Will make future conversions easier. # This is the commit message #3: Fix lint errors * Add margin of error to test determining panel widths use real kibana version when creating panel data. Will make future conversions easier. Move default height and width to dashboard_constants so those that need it don't end up including extra stuff like ui/chrome * Remove unnecessary _.once when creating react directives in dashboard.js * Remove unnecessary constructors * Use componentDidMount instead of componentWillMount bc of async calls, and handle case where destroyEmbeddable is not defined. * Remove unnecessary null in classNames * Use loads defaultsDeep instead of Object.assign * use render* instead of get* for functions returning an element * use relative css paths * Use local import path * Switch to local imports and remove need for plugins path in jest tests * Improve accessibility of max/min panel toggle icon * remove unused css Had to implement this via code * disable eslint rule for setState in componentDidMount Am not aware of a better way to handle this, aside from switching to redux, since it’s recommended not to put async calls in componentWillMount. Since I plan to investigate redux next, disabling for now. Open to other’s opinions on the matter. * Use native map instead of lodash * Have the grid handle setting the z-indexes of the right reactgriditem * Make the draggable handle the title, not the whole heading Otherwise the drag event often takes over click events when trying to open the panel options menu and it gets really annoying. * Change from click to mouse down detector in KuiOutsideClickDector so drags also close pop ups. * Fix mistaken commit Code from the redux PR snuck into this one. * Run getEditPath and getTitle async calls in parallel - no need to wait on the return value of one before starting the others. * Fix tests: update snapshots, add promise returns. * version being added to panelData in the wrong spot caused isDirty flag to be true when it shouldn't be * Fix unmounting/mounting problem with panels due to view/edit mode switch * Fix bug where panels get squashed to one side when view mode is changed while a panel is expanded. * Update snapshots to match wrong view mode comparison * Improve naming of a variable * Fix issue with pop over hiding behind tile maps * Previous panel.js included ui/doc_table and ui/visualize - needed to include them in the chain for Dash only mode but not in that file. * Fix bad merge: remove baseline screenshots
timroes
added a commit
that referenced
this pull request
Jun 19, 2018
timroes
added a commit
that referenced
this pull request
Jun 19, 2018
kobelb
added a commit
that referenced
this pull request
Sep 12, 2018
* Splitting to a client and a wrapper, integation tests are passing without spaces * Adding the spaces wrapper back in the mix using a priority collection * Restructuring the secure wrapper as we don't need to switch between repositories * Checking authorization at the current space * Beginning to make the rbac api integration tests run against spaces * Adding identical data to the rbac esArchives for two more spaces * Adding some space tests for find * Beginning to work on the spaces client * Fixing find and filtering out unrequested privileges from response * Adding get code and test * Introducing an RBAC Auth Scope * Exposing the spacesClient a bit better * Moving the server.expose to the security plugin init * Moving checkPrivilegesAtAllResources to it's own thing * No longer using the auth scope for RBAC, dashboard mode didn't work with it * Securing the create space method * Adding secure update method * Adding secured delete endpoints * Restructuring some code in the spaces client * Adding tests for the select endpoint * Spaces can't be managed via the SavedObjectsClient now * Creating separate space_all and space_read privileges * Splitting out the spaces and global privileges * Fixing edit role screen after API changes * Revising comment, there is a Set in JavaScript now, but lodash can't equal them * Using authorization mode to log deprecation warning on login * Changing the signature of checkPrivileges We're now using the legacy fallback when there are no application privileges. This improves performance at the sake of legacy 403s being displayed to users who have no application privileges. * Refactoring the way we specify resources when checking privileges * Exposing the space service more intuitively * Fixing comments * Security defines all actions * Renaming `response` returned by the checkPrivileges function * Hard-coding the kibana app privileges teporarily * Adding Authenticator authorization mode tests * Adding actions.manageSpaces tests * Adding check privileges tests * Fixing checkPrivileges test snapshots * Making sure tests fail until I correct this deficiency * Adding stubbed out authorization mode tests * Fixing tests for RegisterPrivilegesWithCluster * Fixing service AuthorizationService tests * Addinng serializer tests * Adding validateEsResponse tests * We don't need the SecureSavedObjectsClient anymore! * Adding SecureSavedObjectsClientWrapper tests... * Fixing a few stray tests * Fixing issue when user isn't authenticated and check useRbacForRequest * Validating spaces we're adding to roles * Reusing hasAnyPrivileges from hasAnyResourcePrivileges * Better variable name * toArray -> toPrioritizedArray * Using Space throughout the SpacesClient * GetActiveSpace uses the SpacesClient now * Squashed commit of the following: commit 23515b1 Author: kobelb <brandon.kobel@elastic.co> Date: Mon Sep 10 06:57:58 2018 -0400 Adding more users to the spaces tests commit 4bbde73 Author: kobelb <brandon.kobel@elastic.co> Date: Mon Sep 10 06:09:35 2018 -0400 Adding not space aware get tests commit 5d11bef Author: kobelb <brandon.kobel@elastic.co> Date: Sat Sep 8 14:06:20 2018 -0400 Adding not space aware test to find commit f9383fd Author: kobelb <brandon.kobel@elastic.co> Date: Sat Sep 8 13:49:04 2018 -0400 Adding bulk create tests and testing non space aware type with bulkGet commit 5388b5a Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 16:18:04 2018 -0400 Adding bulk create test commit 0674263 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 15:58:21 2018 -0400 Ignoring some modules commit 6b011d3 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 15:55:58 2018 -0400 Making the users match for saved objects security and spaces commit de2f994 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 14:18:53 2018 -0400 Making the space suites define their own test expectations commit 5407866 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 13:15:46 2018 -0400 Removing redundant spaces folder commit 9913923 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 13:14:45 2018 -0400 Removing unneeded objects from the esarchive commit bc602b1 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 13:08:12 2018 -0400 Moving some tests around commit 7fec308 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 12:38:23 2018 -0400 Deleting rbac_api_integration tests, they've been migrated elsewhere commit 29c018e Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 10:01:16 2018 -0400 Importing SuperTest where needed commit 38d2e74 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 08:44:53 2018 -0400 Removing the "saved_objects" folder commit 70eada4 Merge: 1b2708f 9023431 Author: Brandon Kobel <brandon.kobel@gmail.com> Date: Fri Sep 7 10:04:03 2018 -0400 Merge pull request #4 from legrego/spaces-api-tests Initial round of spaces api testing commit 9023431 Merge: 6410f72 1b2708f Author: Larry Gregory <larry.gregory@elastic.co> Date: Fri Sep 7 09:37:57 2018 -0400 Merge remote-tracking branch 'kobelb/spaces/securing-api-tests' into spaces-api-tests commit 1b2708f Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 08:17:25 2018 -0400 Even more typescript commit 369a429 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 08:08:28 2018 -0400 Typescriptifying Get commit f53f2ab Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 08:01:48 2018 -0400 Typescriptifying Find commit f707e03 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 07:55:10 2018 -0400 Typescriptifying Create commit 485d983 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 07:31:54 2018 -0400 Changing the namespace agnostic type name commit 71c2122 Author: kobelb <brandon.kobel@elastic.co> Date: Fri Sep 7 07:25:15 2018 -0400 Adding update tests commit f60e953 Author: kobelb <brandon.kobel@elastic.co> Date: Thu Sep 6 15:53:34 2018 -0400 Delete tests commit 94682e5 Author: kobelb <brandon.kobel@elastic.co> Date: Thu Sep 6 12:07:39 2018 -0400 Adding get security and spaces tests commit 481943f Author: kobelb <brandon.kobel@elastic.co> Date: Thu Sep 6 11:58:42 2018 -0400 Generalizing bulk get commit 14d9058 Merge: 6627127 fc5f7fa Author: Brandon Kobel <brandon.kobel@gmail.com> Date: Thu Sep 6 10:46:07 2018 -0400 Merge pull request #3 from legrego/remove-privs-api Remove privs api and hardcoded privs list commit 6410f72 Author: Larry Gregory <larry.gregory@elastic.co> Date: Thu Sep 6 09:35:30 2018 -0400 add missing superagent type commit 4afacc0 Author: Larry Gregory <larry.gregory@elastic.co> Date: Wed Sep 5 20:19:15 2018 -0400 initial round of spaces api testing commit 6627127 Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 17:29:37 2018 -0400 Adding GET test suite commit 68a5537 Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 13:32:49 2018 -0400 Copying find to security and spaces commit fc5f7fa Author: Larry Gregory <larry.gregory@elastic.co> Date: Wed Sep 5 12:36:30 2018 -0400 move es privilege tests to api_integration commit 189fbe6 Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 12:24:41 2018 -0400 Switching approach to dynamically enabling security commit c72200f Author: Larry Gregory <larry.gregory@elastic.co> Date: Wed Sep 5 11:57:26 2018 -0400 remove get privileges api commit 1607f80 Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 11:47:19 2018 -0400 Dynamically supplying users so we reduce some duplication commit 9deec1b Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 09:32:36 2018 -0400 Security and Spaces create tests commit a8232dd Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 07:22:10 2018 -0400 Using a create "test suite" commit f07f668 Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 05:54:46 2018 -0400 Using the spaces esArchive always now commit b2021ad Merge: d3babea 7b4575b Author: kobelb <brandon.kobel@elastic.co> Date: Wed Sep 5 05:43:48 2018 -0400 Merge branch 'spaces/securing' into spaces/securing-api-tests commit d3babea Author: kobelb <brandon.kobel@elastic.co> Date: Tue Sep 4 17:43:38 2018 -0400 Moving over the spaces only saved objects tests commit 94054a2 Author: kobelb <brandon.kobel@elastic.co> Date: Tue Sep 4 17:26:43 2018 -0400 Copying over the security only saved object api tests * update public api to use SpacesClient * fix * test and api fixes * fix tests * Disallowing use of Spaces with the SpacesSavedObjectsClientWrapper * Adding spaces audit logging * Updating snapshots * Adding get and getAll tests for the spaces client * Adding update tests * Adding create tests * Adding SpacesClient delete tests * Fixing authenticate tests * Making tests more consistent * Fixing kibana privileges tests * Fixing a few type issues * Making typescript ignore the .only test suites * Switching to beforeEach and afterEach and removing the mocha types * Switching to our own expect.js definitions The definitions in @types/expect have expect being globally defined which conflicts with the jest definitions, and expect isn't globally defined in the mocha tests and we must use the module value * Fixing more linting rules * Removing test stubs and replacing with TODOs. Updating snapshots * No longer shadowing application for the put role API * Relying on the errors thrown by the SpacedClient when determining active space * Back to after/before... mocha doesn't have beforeAll/afterAll * We got them types, thanks Spencer!!! * Ignoring space type from the secure saved objects client find with no type
njd5475
pushed a commit
to njd5475/kibana
that referenced
this pull request
Oct 18, 2018
…eturn-taskdoc-to-caller add default client module, more wrapper methods
lizozom
pushed a commit
that referenced
this pull request
Mar 3, 2022
* Client side execution app level context propagation * context$ + apm rum integration * invert the context parent \ child relationship (cc @mikhail) move more things to top level context * Pass down context to apm on server * types * eslint * parent <> child * docs + eslint + jest * execution context mock * eslint * jest * jest * server jest * check * jest * storybook * jest * report the current space * fix server side context container * Remove spaces for now * docssss * jest * lint * test * docs * revert file * doc * all context params are optional * clear on page change * lint * ts * skipped test again * testing fixes * oops * code review #1 * code review #2 * getAsLabels * maps inherit dashboard context * docs * ts * Give common context to all vis editors * fix test * ts \ es \ tests * labels * missing types * docsy docs * cr #3 * improve jest * Use editor name * Update src/plugins/visualizations/public/visualize_app/components/visualize_editor.tsx Co-authored-by: Marco Liberati <dej611@users.noreply.github.com> * fix maps context * jest tests for maps * cr * docs * Update execution_context.test.ts * docs * lint Co-authored-by: Marco Liberati <dej611@users.noreply.github.com> (cherry picked from commit d5416ed) # Conflicts: # src/plugins/discover/public/application/context/context_app.tsx # x-pack/plugins/lens/public/app_plugin/app.tsx
lucasfcosta
pushed a commit
to lucasfcosta/kibana
that referenced
this pull request
Mar 8, 2022
* Client side execution app level context propagation * context$ + apm rum integration * invert the context parent \ child relationship (cc @mikhail) move more things to top level context * Pass down context to apm on server * types * eslint * parent <> child * docs + eslint + jest * execution context mock * eslint * jest * jest * server jest * check * jest * storybook * jest * report the current space * fix server side context container * Remove spaces for now * docssss * jest * lint * test * docs * revert file * doc * all context params are optional * clear on page change * lint * ts * skipped test again * testing fixes * oops * code review elastic#1 * code review elastic#2 * getAsLabels * maps inherit dashboard context * docs * ts * Give common context to all vis editors * fix test * ts \ es \ tests * labels * missing types * docsy docs * cr elastic#3 * improve jest * Use editor name * Update src/plugins/visualizations/public/visualize_app/components/visualize_editor.tsx Co-authored-by: Marco Liberati <dej611@users.noreply.github.com> * fix maps context * jest tests for maps * cr * docs * Update execution_context.test.ts * docs * lint Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
lucasfcosta
pushed a commit
to lucasfcosta/kibana
that referenced
this pull request
Mar 8, 2022
* Client side execution app level context propagation * context$ + apm rum integration * invert the context parent \ child relationship (cc @mikhail) move more things to top level context * Pass down context to apm on server * types * eslint * parent <> child * docs + eslint + jest * execution context mock * eslint * jest * jest * server jest * check * jest * storybook * jest * report the current space * fix server side context container * Remove spaces for now * docssss * jest * lint * test * docs * revert file * doc * all context params are optional * clear on page change * lint * ts * skipped test again * testing fixes * oops * code review elastic#1 * code review elastic#2 * getAsLabels * maps inherit dashboard context * docs * ts * Give common context to all vis editors * fix test * ts \ es \ tests * labels * missing types * docsy docs * cr elastic#3 * improve jest * Use editor name * Update src/plugins/visualizations/public/visualize_app/components/visualize_editor.tsx Co-authored-by: Marco Liberati <dej611@users.noreply.github.com> * fix maps context * jest tests for maps * cr * docs * Update execution_context.test.ts * docs * lint Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kqualters-elastic
referenced
this pull request
in kqualters-elastic/kibana
Mar 8, 2022
Sync with upstream
pmuellr
pushed a commit
to pmuellr/kibana
that referenced
this pull request
Mar 17, 2022
mike feedback for X
opauloh
pushed a commit
to opauloh/kibana
that referenced
this pull request
Mar 29, 2022
…-with-details-flyout [Security Solution][Investigations] - Integrate details flyout with session view
2 tasks
breehall
added a commit
that referenced
this pull request
Sep 22, 2022
…List, EuiButton, and EuiBadge Emotion conversions. Updated snapshots for EuiTooltip as if now contains the new EuiTooltipAnchor component that replaced the tooltop anchor styles
5 tasks
mistic
pushed a commit
that referenced
this pull request
Nov 7, 2022
* Updated EUI to version 67.1.2. Updated instaces of ButtonColor from EUI to EuiButtonColor. * Updated to EuiCard instances that utilize the betaBadgeProps object to return an empty string instead of undefined when the label is unavailable * Removed two instances of the deprecated internetExplorerOnly() mixin * Updated two instances of the ButtonColor import to EuiButtonColor as is was renamed in PR #6150 * Updated snapshots in Jest Test Suite #1 to account for EuiButton and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles * Updated snapshots in Jest Test Suite #2 to account forEuiButton, EuiDescriptionList, EuiButtonIcon, and EuiBadge Emotion conversions. * Updated snapshots in Jest Test Suite #3 to account for EuiDescriptionList, EuiButton, and EuiBadge Emotion conversions. Updated snapshots for EuiTooltip as if now contains the new EuiTooltipAnchor component that replaced the tooltop anchor styles * Updated snapshots in Jest Test Suite #4 to account for EuiButton Emotion conversion. * Updated snapshots in Jest Test Suite #5 to account for EuiButton Emotion conversion. * Updated snapshots in Jest Test Suite #8 to account for EuiButtonIcon and EuiButton Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles. * Updated snapshots in Jest Test Suite #9 to account for EuiFlyout and EuiButton Emotion conversions. * Updated snapshots in Jest Test Suite #10 to account for EuiButton, EuiBadge, EuiButtonIcon, and EuiCard Emotion conversions. Updated snapshots for EuiToolTtip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles * Updated instances of EuiButtonIconColor to use EuiButtonIconProps['color'] as it was removed in PR #6150 * Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors * Updated snapshots in Jest Test Suite #1 to account for EuiButton and EuiCard Emotion conversions * Added the EuiFlyout mixins and variables to Lens Sass file as EuiFlyout has been converted to Emotion and the Sass styles are no longer available in EUI * Added the EuiCallOutTypes variable to Step Progress Sass file as EuiCallOut has been converted to Emotion and the Sass styles are no longer available in EUI * Updated snapshots in Jest Test Suite #2 to account for recent Emotion conversions. Updated snapshots in server_status.test.tsx to render EuiBadge before checking the snapshots to reduce the snapshot churn caused by Emotion. Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Added imports for the added flyout mixin. Removed references to EuiCallOut mixin as the component has been converted to Emotion and is no longer available for use. * Updated unit tests and snapshots in Jest Test Suite #10. Updated snaphshots to account for EuiBadge, EuiDescriptionList, EuiFlyout, and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles. Updated tests that target EuiButton to simulate click events to target a generic button element to prevent undefined click event errors * Updated unit tests in Jest Test Suite #11 that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors * Updated unit tests in Jest Test Suite #12 by updating tests that target EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors * Updated unit tests in Jest Test Suite #1 by updating tests that target EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors * Updated unit tests in Jest Test Suite #2 by updating tests that use EuiButton to simulate click events. Instead, these test have been updated to target a button element to prevent undefined click event errors. * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Updated reference to mixins Sass file. Updated snapshots for Jest Test Suite #5 to account for EuiButton Emotion conversion. Updated unit tests that target EuiButton to simulate click events. These tests have been updated to target a button element to prevent undefined click event errors * Updated unit tests in Jest Test Suites 3, 7, 8, 13, and 14. Updated snapshot to account for EuiButton Emotion conversion. Updated tests that target EuiButton to simulate click events. These tests now target a generic button element to prevent undefined click event errors. Updated a few snapshots by adding .render() before checking the snapshot. This will prevent large snapshots coming from recent Emotion conversions * Updated snapshots in Jest Test Suite #10 to account for the recent EuiButton Emotion conversion * Updated unit tests in Jest Test Suite #2 by editing tests that target EuiButton to simulate click events. These tests now target a button element in order to prevent undefinde click event errors * Updated snapshots in Jest Test Suite #10 to account for EuiButton and EuiDescriptionList Emotion conversions * Updated test cases in Jest Test Suites 3, 7, and 8. Updated snapshots to account for EuiButton and EuiPagination Emotion conversions. Updated tests that target EuiButton to simulate click events. These tests now target a button element to prevent undefined click errors * Updated test cases in Jest Test Suite 14. Updated snapshots to account for EuiButton Emotion conversion. Opted to use .render() when updating a few snapshots to reduce the large length of snapshots caused by Emotion * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Revised a change to betaBadgeProps to ensure that the label is available. If not, the value for the badge with be set to undefined. * Resolved two linting errors * Resolved two linting errors * Updated Jest unit tests in various suites. Updated snapshots to account for EuiButton Emotion conversion. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles. * Updated EuiFlyout in query_flyout.tsx to remove the onClick function from maskProps as it is no longer available. Updated this flyout to use ownFocus and not to close when the overlay mask is clicked. * Removed the use of EuiButtonIconColor in favor of EuiButtonIconProps['color'] * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Updated Cypress test looking for strict equality on EuiPaginationButton class names to match a substring of the Emotion generated class name * Removed unneeded debugging code. Updated snapshots for various test suites to account for the recent EuiButton Emotion conversion * Updated a few EuiButton, EuiButtonEmpty, and EuiText components that set the color as ghost. The ghost color mode has been deprecated as of PR #6150. These components now are wrapped in EuiThemeProvider with a dark colorMode to create the previous ghost color. * Resolved TS error with EuiCard betaBadgeProps * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Remove references to now-removed EuiFlyout CSS classes/vars * Remove now-removed euiBadge className references - Convert directly to EuiBadge instead of using CSS - Remove confusing and now-possibly-irrelevant CSS badge overrides - left/right icons are now set via JSX and not via flex-direction * Pre-emptively fix various euiOverlayMask CSS overrides - this data attr isn't technically in yet but will be once elastic/eui#6289 merges - at the very least this isn't breaking any more than it currently already is! * Update to v67.1.3 * v67.1.4 * Resolved test failing test case in Security/Manage/Blocklist. The test did not remove focus from the last combo box in the form, which didn't allow the disbaled attribute to be removed from the flyout submit button. I've updated the mock file for Blocklist to return focus to the first form element in the flyout to allow the disabled attribute to be removed. * Updated snapshots to account for the recent EuiText Emotion conversion * Fix Log's custom tooltips relying on EuiTooltip classNames that no longer exist * Fix Vega vis custom tooltips relying on EuiTooltip classNames that no longer exist - this one is trickier than Log's as it's not using React, so we need to use Emotion's Global to set a static className * Convert remaining vega_vis.scss to Emotion - as an example of how other global + non global styles could be handled in the future * Fix references to removed `euiPaginationButton-isActive` className - use aria-current attribute instead * Added missing EuiFlyoutAnimation keyframes for EuiFlyout. This resolved test that failed because they used onAnimationEnd because the FlyoutAnimation could not be found. * Reolved Jest Tests in suites 1 and 5. Updated snapshots to account for the recent EuiButton Emotion conversion. Updated snapshots for EuiToolTip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles. * iterate on rules_list.test.tsx * bump eui to v67.1.5 * Updatde snapshots for jest test suites to account for the recent EuiButton, EuiOverlayMask, EuiTooltip, and EuiBadge Emotion conversions * Resolved failing security test by updating the target element for CONNECTOR_TITLE. EuiCard has recently been converted to Emotion and the card title is no longer wrapper in a span. * Resolved failing test case in Runtime Fields. The modify runtime field test was failing because the combobox responsbible for adding and updating scripts was not appearing. The textbox did not appear because the shared setFieldScript function targets and toggles the script textbox when opening the flyout. When a runtime field is being modified, the toggle is already active and using the shared function will trigger the toggle again (losing access to the script textbox). Also resolved an issue that prevented the warning EuiCallout to appear when changing the type of a runtime field from its original type. Resolved this by adding an enter keypress at the end of setFieldType function to confirm the type selection, thus triggering the EuiCallout * Resolved two tests that were failing in Lens. These test were failing because they were checking for equality in class names that no longer exist within EuiButtonGroup as it was recently converted to Emotion. These tests were updated to check for a substring of the new and longer class name * Quick fix in test case failing because of misspelling in data-test-sub * Updated snapshot for Jest test case as EuiButton as recently been converted to Emotion * Removed console.log statement. Oops! * Resolved a failing test case in Lens. They were failing because they were checking for equality in class names that no longer exist within EuiButtonGroup as it was recently converted to Emotion. These tests were updated to check for a substring of the new and longer class name. Updated a Security test case by giving a target button the data-test-subj attribute for easier querying * Removed reference to EuiFlyout mixin as it has been converted to Emotion. Updated the reference to an interal copy of EuiFlyout styles * Corrected spelling error in EuiFlyout animation in Lens app * Update EUI with latest backport * Update button snapshots * fix another button snapshot * More snapshot fixes * [EuiButton][Security] Fix button relying on now-removed `euiButton__text` CSS - replace removed CSS with `eui-textTruncate` util instead - combine/DRY out unnecessary span - was affecting min-width of truncation util + increase screenshot diff limit - this was smaller than updating the actual baseline screenshots for whatever reason (likely render diff between local and CI) * Fix remaining Jest tests affected by Emotion conversions - because Emotion creates its own wrapper, `.first()` can no longer be used - prefer `.last()` instead * Fix Jest test affected by EuiButton Emotion conversion + removed modifier class - targeting the native DOM node + filtering by disabled true/false gets us back to the 'correct' lengths * Fix + improve flyout test - `.last()` changes to account for EuiButton Emotion conversion is needed, but the last onClose assertion still fails due to us having modified inputs, and the confirm modal being displayed - split test into two separate tests - one testing the onClose call, and the other testing the confirm modal * derpin * Skip rules_list Jest suite * Update new EuiButton snapshot * Upgraded EUI version to 67.1.7 * [EuiCard] Update snapshots * [EuiPopover] Update snapshots * [QA] Fix missing Vega warn/error message colors ;_; * [CI] Auto-commit changed files from 'node scripts/generate codeowners' * Fix Lens kbnToolbarButton regressions - Caused by flattening of EUI button CSS specificity - background-color was previously relying on isDisabled CSS specificity to override its #fff color - `text` color modifier & `!important` is no longer needed and overrides Emotion CSS flatly - isDisabled class is no longer needed - euiButton no longer sets `pointer-events: none` on disabled buttons (fixes tooltip bug in webkit as well) * Backport EUI 67.1.8 fixes * Update EuiCard snapshots * Fix EuiModal form wrapper causing overflow issues - see https://elastic.github.io/eui/#/layout/modal#forms-in-a-modal * Workaround for `.kbnOverlayMountWrapper` mount point causing overflow issues - not sure what all is using this modal service to be honest, but the wrapper is causing issues with the modal layout, this fixes overflow issues but will not fix any mask-image issues as a result * more snapshot updates * EuiButton - added textProps to EuiButton to prevent very long button names from spilling over outside of the container * EuiButton - Update EuiButton related snapshots. Updated tests that target EuiButton directly to use a data-telementary-id for more specific element querying required by Emotion * QA - Removed unnecessary comment in code * Temporary fix for EuiCard[selectable][layout=horizontal] instances on security solutions' rule page * Temporary fix for EuiCard[selectable][layout=horizontal] instances on osquery live query and canvas's datasource selector * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Fix CSS specificity, where canvas's solutionToolbarButton's background-color now takes precedence over EuiButton's primary styles * Removed update to search_marker_tooltip that removed the euiTooltip styles and replaced then with Emotion styling. Added EuiTooltip Sass styles for the component to rely on to test for a styling bug that is causing the tooltip and the tooltip arrow to be out of sync with each other. * Lint Sass file * Lint Sass file * Removed overflow:hidden style from .vgaVis_view as it was causing euiScrollStyles not to present the scroll bars in Vega Vis * Remove typo from EuiButton textProps object. 'className' should not have been included in the actual class name * Revert tooltip Sass This reverts commit 20e6ead, a5cd2de, and c605cbd * Fix Emotion tooltip arrows Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Constance Chen <constance.chen@elastic.co> Co-authored-by: Chandler Prall <chandler.prall@elastic.co>
juliaElastic
added a commit
that referenced
this pull request
Dec 8, 2022
## Summary Related to #144161 Found that on a bulk update tags task failure, the task didn't stop after 3 retries (should be over in less then a minute), the retries kept happening for 2 hours. This change removes the retry task if 3 retries are reached. Also testing in cloud deployment to see if the tags error can be reproduced with this fix. I could reproduce the reported error locally, and seeing it goes away with this fix. To verify: - Add at least 50k agents with the `create_agents` script in kibana repo - open Kibana, select the 50k agents, and open Actions / Add tags - Try this in a few seconds: add 2 new tags, and remove one of them - Wait about 30s, the agents should reflect the changes - Check the logs to see that the tasks are removed after 3rd retry is reached or successful. - Check that there are no more running tasks. Any running task can be found in Kibana Console by running this query: `GET .kibana_task_manager/_search?q=task.taskType:"fleet:update_agent_tags:retry"` Locally simulated an error to test that the retry (and check) task is removed: ``` [2022-12-07T15:52:16.415+01:00][ERROR][plugins.fleet] Retry #3 of task fleet:update_agent_tags:retry:848984ab-c11d-4ebe-8d1f-606143dd656b failed: failing task [2022-12-07T15:52:16.416+01:00][WARN ][plugins.fleet] Stopping after 3rd retry. Error: failing task [2022-12-07T15:52:16.416+01:00][INFO ][plugins.fleet] Removing task fleet:update_agent_tags:retry:check:848984ab-c11d-4ebe-8d1f-606143dd656b [2022-12-07T15:52:16.416+01:00][INFO ][plugins.fleet] Removing task fleet:update_agent_tags:retry:848984ab-c11d-4ebe-8d1f-606143dd656b ```
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 8, 2022
## Summary Related to elastic#144161 Found that on a bulk update tags task failure, the task didn't stop after 3 retries (should be over in less then a minute), the retries kept happening for 2 hours. This change removes the retry task if 3 retries are reached. Also testing in cloud deployment to see if the tags error can be reproduced with this fix. I could reproduce the reported error locally, and seeing it goes away with this fix. To verify: - Add at least 50k agents with the `create_agents` script in kibana repo - open Kibana, select the 50k agents, and open Actions / Add tags - Try this in a few seconds: add 2 new tags, and remove one of them - Wait about 30s, the agents should reflect the changes - Check the logs to see that the tasks are removed after 3rd retry is reached or successful. - Check that there are no more running tasks. Any running task can be found in Kibana Console by running this query: `GET .kibana_task_manager/_search?q=task.taskType:"fleet:update_agent_tags:retry"` Locally simulated an error to test that the retry (and check) task is removed: ``` [2022-12-07T15:52:16.415+01:00][ERROR][plugins.fleet] Retry elastic#3 of task fleet:update_agent_tags:retry:848984ab-c11d-4ebe-8d1f-606143dd656b failed: failing task [2022-12-07T15:52:16.416+01:00][WARN ][plugins.fleet] Stopping after 3rd retry. Error: failing task [2022-12-07T15:52:16.416+01:00][INFO ][plugins.fleet] Removing task fleet:update_agent_tags:retry:check:848984ab-c11d-4ebe-8d1f-606143dd656b [2022-12-07T15:52:16.416+01:00][INFO ][plugins.fleet] Removing task fleet:update_agent_tags:retry:848984ab-c11d-4ebe-8d1f-606143dd656b ``` (cherry picked from commit 431c32b)
kibanamachine
added a commit
that referenced
this pull request
Dec 8, 2022
# Backport This will backport the following commits from `main` to `8.6`: - [[Fleet] cancel tasks when 3rd retry failed (#147190)](#147190) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-12-08T08:14:33Z","message":"[Fleet] cancel tasks when 3rd retry failed (#147190)\n\n## Summary\r\n\r\nRelated to #144161 that on a bulk update tags task failure, the task didn't stop\r\nafter 3 retries (should be over in less then a minute), the retries kept\r\nhappening for 2 hours.\r\nThis change removes the retry task if 3 retries are reached.\r\n\r\nAlso testing in cloud deployment to see if the tags error can be\r\nreproduced with this fix.\r\nI could reproduce the reported error locally, and seeing it goes away\r\nwith this fix.\r\n\r\nTo verify:\r\n- Add at least 50k agents with the `create_agents` script in kibana repo\r\n- open Kibana, select the 50k agents, and open Actions / Add tags\r\n- Try this in a few seconds: add 2 new tags, and remove one of them\r\n- Wait about 30s, the agents should reflect the changes\r\n- Check the logs to see that the tasks are removed after 3rd retry is\r\nreached or successful.\r\n- Check that there are no more running tasks. Any running task can be\r\nfound in Kibana Console by running this query: `GET\r\n.kibana_task_manager/_search?q=task.taskType:\"fleet:update_agent_tags:retry\"`\r\n\r\nLocally simulated an error to test that the retry (and check) task is\r\nremoved:\r\n\r\n```\r\n[2022-12-07T15:52:16.415+01:00][ERROR][plugins.fleet] Retry #3 of task fleet:update_agent_tags:retry:848984ab-c11d-4ebe-8d1f-606143dd656b failed: failing task\r\n[2022-12-07T15:52:16.416+01:00][WARN ][plugins.fleet] Stopping after 3rd retry. Error: failing task\r\n[2022-12-07T15:52:16.416+01:00][INFO ][plugins.fleet] Removing task fleet:update_agent_tags:retry:check:848984ab-c11d-4ebe-8d1f-606143dd656b\r\n[2022-12-07T15:52:16.416+01:00][INFO ][plugins.fleet] Removing task fleet:update_agent_tags:retry:848984ab-c11d-4ebe-8d1f-606143dd656b\r\n```","sha":"431c32b894077fc5910380252086442083734fce","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.7.0","v8.6.1"],"number":147190,"url":"#147190 cancel tasks when 3rd retry failed (#147190)\n\n## Summary\r\n\r\nRelated to #144161 that on a bulk update tags task failure, the task didn't stop\r\nafter 3 retries (should be over in less then a minute), the retries kept\r\nhappening for 2 hours.\r\nThis change removes the retry task if 3 retries are reached.\r\n\r\nAlso testing in cloud deployment to see if the tags error can be\r\nreproduced with this fix.\r\nI could reproduce the reported error locally, and seeing it goes away\r\nwith this fix.\r\n\r\nTo verify:\r\n- Add at least 50k agents with the `create_agents` script in kibana repo\r\n- open Kibana, select the 50k agents, and open Actions / Add tags\r\n- Try this in a few seconds: add 2 new tags, and remove one of them\r\n- Wait about 30s, the agents should reflect the changes\r\n- Check the logs to see that the tasks are removed after 3rd retry is\r\nreached or successful.\r\n- Check that there are no more running tasks. Any running task can be\r\nfound in Kibana Console by running this query: `GET\r\n.kibana_task_manager/_search?q=task.taskType:\"fleet:update_agent_tags:retry\"`\r\n\r\nLocally simulated an error to test that the retry (and check) task is\r\nremoved:\r\n\r\n```\r\n[2022-12-07T15:52:16.415+01:00][ERROR][plugins.fleet] Retry #3 of task fleet:update_agent_tags:retry:848984ab-c11d-4ebe-8d1f-606143dd656b failed: failing task\r\n[2022-12-07T15:52:16.416+01:00][WARN ][plugins.fleet] Stopping after 3rd retry. Error: failing task\r\n[2022-12-07T15:52:16.416+01:00][INFO ][plugins.fleet] Removing task fleet:update_agent_tags:retry:check:848984ab-c11d-4ebe-8d1f-606143dd656b\r\n[2022-12-07T15:52:16.416+01:00][INFO ][plugins.fleet] Removing task fleet:update_agent_tags:retry:848984ab-c11d-4ebe-8d1f-606143dd656b\r\n```","sha":"431c32b894077fc5910380252086442083734fce"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#147190 cancel tasks when 3rd retry failed (#147190)\n\n## Summary\r\n\r\nRelated to #144161 that on a bulk update tags task failure, the task didn't stop\r\nafter 3 retries (should be over in less then a minute), the retries kept\r\nhappening for 2 hours.\r\nThis change removes the retry task if 3 retries are reached.\r\n\r\nAlso testing in cloud deployment to see if the tags error can be\r\nreproduced with this fix.\r\nI could reproduce the reported error locally, and seeing it goes away\r\nwith this fix.\r\n\r\nTo verify:\r\n- Add at least 50k agents with the `create_agents` script in kibana repo\r\n- open Kibana, select the 50k agents, and open Actions / Add tags\r\n- Try this in a few seconds: add 2 new tags, and remove one of them\r\n- Wait about 30s, the agents should reflect the changes\r\n- Check the logs to see that the tasks are removed after 3rd retry is\r\nreached or successful.\r\n- Check that there are no more running tasks. Any running task can be\r\nfound in Kibana Console by running this query: `GET\r\n.kibana_task_manager/_search?q=task.taskType:\"fleet:update_agent_tags:retry\"`\r\n\r\nLocally simulated an error to test that the retry (and check) task is\r\nremoved:\r\n\r\n```\r\n[2022-12-07T15:52:16.415+01:00][ERROR][plugins.fleet] Retry #3 of task fleet:update_agent_tags:retry:848984ab-c11d-4ebe-8d1f-606143dd656b failed: failing task\r\n[2022-12-07T15:52:16.416+01:00][WARN ][plugins.fleet] Stopping after 3rd retry. Error: failing task\r\n[2022-12-07T15:52:16.416+01:00][INFO ][plugins.fleet] Removing task fleet:update_agent_tags:retry:check:848984ab-c11d-4ebe-8d1f-606143dd656b\r\n[2022-12-07T15:52:16.416+01:00][INFO ][plugins.fleet] Removing task fleet:update_agent_tags:retry:848984ab-c11d-4ebe-8d1f-606143dd656b\r\n```","sha":"431c32b894077fc5910380252086442083734fce"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Closed
5 tasks
1 task
5 tasks
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Oct 30, 2023
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Nov 2, 2023
1 task
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Feb 6, 2024
Ai playground chat
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some firewalls give the country name with the event. Maps use only country code.