Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EUI to 0.0.53 #20005

Merged
merged 6 commits into from
Jun 19, 2018
Merged

Update EUI to 0.0.53 #20005

merged 6 commits into from
Jun 19, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Jun 18, 2018 •
edited
Loading

Updates EUI to 0.0.53, updates some broken snapshot tests, and fix #19927

One of the major changes in that version is, that all EuiFlyout now have by default a close button in the top right corner. That might mean (or not depending on your use-case - in question of doubt consult the design team), that you might want to remove existing "Close" footers, or other Close buttons.

I saw, that these teams are using EuiFlyout and might to look over their existing close solution:

@timroes timroes added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.4.0 labels Jun 18, 2018
@timroes timroes requested a review from nreese June 18, 2018 17:18
@nreese
Copy link
Contributor

nreese commented Jun 18, 2018 •
edited
Loading

Dashboard "add panel" already places a close button on the top right. Can you remove this? Here are the required changes - nreese@cf18931. For some reason I can not create a PR against your PR that has a clean history

@timroes
Copy link
Contributor Author

timroes commented Jun 18, 2018

I actually wanted to leave that Flyout changes to individual PRs after that has been merged, since as in your PR it might require some test changes, and I would rather not have them all in one big PR. Would it be okay, if you open another PR after that one? (Would still ping every FlyOut owner.)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented Jun 19, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented Jun 19, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented Jun 19, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor Author

timroes commented Jun 19, 2018

Jenkins, test this - just to get a second pass

ppisljar
ppisljar approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me

nreese
nreese approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review and tested input controls in chrome

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit 58257c2 into elastic:master Jun 19, 2018
@timroes timroes deleted the eui-update branch June 19, 2018 15:43
@timroes timroes mentioned this pull request Jun 19, 2018
Merged
timroes added a commit to timroes/kibana that referenced this pull request Jun 19, 2018
@timroes
Update EUI to 0.0.53 (elastic#20005)
ff10bc0 
* Update to EUI 0.0.53

* Remove input vis specific styling

* remove double close button in dashboard add panel flyout (#2)

* Fix functional tests

* fix x-pack snapshots

* EUI 0.0.53 no longer closes combo box when clear btn is pressed (#3)
@ycombinator ycombinator mentioned this pull request Jun 19, 2018
Closed
timroes added a commit that referenced this pull request Jun 19, 2018
@timroes
Update EUI to 0.0.53 (#20005) (#20042)
508df9e 
* Update to EUI 0.0.53

* Remove input vis specific styling

* remove double close button in dashboard add panel flyout (#2)

* Fix functional tests

* fix x-pack snapshots

* EUI 0.0.53 no longer closes combo box when clear btn is pressed (#3)
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal mentioned this pull request Jun 19, 2018
Merged
@ycombinator ycombinator mentioned this pull request Jun 19, 2018
Merged
@pickypg pickypg mentioned this pull request Jun 19, 2018
Merged
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
@timroes @maryia-lapata
Update EUI to 0.0.53 (elastic#20005)
8c28a4e 
* Update to EUI 0.0.53

* Remove input vis specific styling

* remove double close button in dashboard add panel flyout (#2)

* Fix functional tests

* fix x-pack snapshots

* EUI 0.0.53 no longer closes combo box when clear btn is pressed (#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove styles on euiAccordion__childWrapper when EUI is upgraded to 0.0.53
4 participants
@timroes @nreese @elasticmachine @ppisljar