Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configPrefix to Index Management, License Management, Rollup Jobs, and Upgrade Assistant #30149

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Add configPrefix to Index Management, License Management, Rollup Jobs, and Upgrade Assistant #30149

merged 1 commit into from
Feb 5, 2019

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Feb 5, 2019 •
edited
Loading

Fixes #25616.

This is a breaking change to kibana.yml settings. It changes the settings names for Index Management, License Management, Rollup Jobs, and Upgrade Assistant by adding the xpack prefix to them:

  • index_management -> xpack.index_management
  • license_management -> xpack.license_management
  • rollup -> xpack.rollup
  • upgrade_assistant -> xpack.upgrade_assistant

@cjcenizal cjcenizal added release_note:breaking v7.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Feb 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

jen-huang
jen-huang approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit 2f92df5 into elastic:master Feb 5, 2019
@cjcenizal cjcenizal mentioned this pull request Feb 6, 2019
Merged
@cjcenizal cjcenizal deleted the break/config-prefix branch February 8, 2019 19:41
This was referenced Feb 8, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang approved these changes

@bmcconaghy bmcconaghy Awaiting requested review from bmcconaghy

Assignees
No one assigned
Labels
release_note:breaking Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add x-pack configPrefix to Index Management and Rollups
3 participants
@cjcenizal @elasticmachine @jen-huang