[UA] Support previously re-indexed ML/Watcher indices #31046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were comparing the start of the indices to determine if ML/Watcher should be stopped before re-indexing. Since we are now pre-pending the index name we should compare the index names without the re-indexed portion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added
WIP
|
Pinging @elastic/kibana-operations |
This comment has been minimized.
This comment has been minimized.
jbudz
reviewed
Feb 14, 2019
x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
|
@joshdover @jbudz this is ready for review now. |
This comment has been minimized.
This comment has been minimized.
added 2 commits
February 22, 2019 08:15
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
This comment has been minimized.
This comment has been minimized.
joshdover
approved these changes
Feb 22, 2019
|
retest |
jbudz
approved these changes
Feb 22, 2019
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Feb 22, 2019
* [UA] Support previously re-indexed ML/Watcher indices Previously we were comparing the start of the indices to determine if ML/Watcher should be stopped before re-indexing. Since we are now pre-pending the index name we should compare the index names without the re-indexed portion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Feb 22, 2019
* [UA] Support previously re-indexed ML/Watcher indices Previously we were comparing the start of the indices to determine if ML/Watcher should be stopped before re-indexing. Since we are now pre-pending the index name we should compare the index names without the re-indexed portion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Feb 23, 2019
Previously we were comparing the start of the indices to determine if ML/Watcher should be stopped before re-indexing. Since we are now pre-pending the index name we should compare the index names without the re-indexed portion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Feb 23, 2019
Previously we were comparing the start of the indices to determine if ML/Watcher should be stopped before re-indexing. Since we are now pre-pending the index name we should compare the index names without the re-indexed portion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Feb 23, 2019
* [UA] Support previously re-indexed ML/Watcher indices Previously we were comparing the start of the indices to determine if ML/Watcher should be stopped before re-indexing. Since we are now pre-pending the index name we should compare the index names without the re-indexed portion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Feb 25, 2019
Previously we were comparing the start of the indices to determine if ML/Watcher should be stopped before re-indexing. Since we are now pre-pending the index name we should compare the index names without the re-indexed portion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Feb 26, 2019
Previously we were comparing the start of the indices to determine if ML/Watcher should be stopped before re-indexing. Since we are now pre-pending the index name we should compare the index names without the re-indexed portion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were comparing the start of the indices to determine if ML/Watcher
should be stopped before re-indexing. Since we are now prepending the index
name we should compare the index names without the re-indexed portion.
Fixes #30849