Use embeddable registry in add panel #31400

flash1293 · 2019-02-18T09:04:24Z

Use embeddable registry in add panel
Use EuiListGroup instead of table

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

flash1293 · 2019-03-04T15:09:14Z

Jenkins, test this.

elasticmachine · 2019-03-04T16:17:54Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

src/legacy/ui/public/saved_objects/components/saved_object_finder.scss

elasticmachine · 2019-03-04T16:35:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-04T17:16:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-05T11:07:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-05T16:41:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-05T18:34:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

src/legacy/ui/public/saved_objects/components/saved_object_finder.tsx

src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

...acy/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable_factory_provider.ts

timroes · 2019-03-06T14:02:29Z

Another comment. I think the way the second part of the new wizard dialog used a bit more width was also nicer beforehand. But I am unfortunately able to figure out what's exactly causing the old dialog to have that higher width, since I don't see any min-width in there either. @cchaos do you have any idea how we could keep that behavior?

flash1293 · 2019-03-06T14:14:06Z

This touched x-pack because I improved typings for UiRegistry which has to be updated in a few places.

…eddable-layer-add-panel

elasticmachine · 2019-03-08T19:57:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cchaos

🥇 Fantastic! TY!

elasticmachine · 2019-03-08T21:11:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-11T07:25:51Z

Pinging @elastic/kibana-app

timroes

Retested UI, and those changes look awesome. Everything still seems to work.

elasticmachine · 2019-03-11T09:29:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-11T09:59:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-03-11T11:24:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

timroes · 2019-03-11T11:27:05Z

Ignoring Security CODEOWNER review, since we only removed one @ts-ignore in a file owned by the security team.

* Prepare control flow to use embeddable factories in add panel * Rewrite saved object finder and add tests * Fix usages of new saved object finder * fix test failures * fix some functional tests and re-introduce makeUrl * fix tests * remove direct hrefs in saved_object_lists * PR review fixes * update snapshot * overwrite width of viz dialog * Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <email@johannes-reuter.de> * fix tests * review fixes #1 * review fixes #2 * dont use classname in functional test * remove call to action button prop * align buttons correctly * fix tests * remove debugging statement * Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js Co-Authored-By: flash1293 <email@johannes-reuter.de> * review fixes #3 * improve filter behavior and enable it for search wizard * adjust functional tests for new filter behavior * Change translation id due to string change * Update Jest snapshot

nreese · 2019-03-11T14:51:25Z

Question about sorting, How do you return to the original sort order (relevancy returned from elasticsearch) after applying sort?

timroes · 2019-03-11T14:54:01Z

If you query for something, that "Sort" dialog should have a "Best match" option, that allows sorting by the order ES returned to you (and also should by default sort by best match. If you're not searching for anything that order is anyway "arbitrary" so if you're not searching by default we search ascending alphabetically.

flash1293 force-pushed the 27985/feature-embeddable-layer-add-panel branch 2 times, most recently from 445b172 to 4d91ae4 Compare February 22, 2019 11:00

flash1293 force-pushed the 27985/feature-embeddable-layer-add-panel branch from d7a572f to 739deda Compare March 4, 2019 07:28

flash1293 changed the title ~~[wip] [skip ci] Use embeddable registry in add panel~~ [wip] Use embeddable registry in add panel Mar 4, 2019

flash1293 requested a review from a team as a code owner March 4, 2019 15:38

Prepare control flow to use embeddable factories in add panel

658fd45

flash1293 force-pushed the 27985/feature-embeddable-layer-add-panel branch from e1f891f to 962cc49 Compare March 4, 2019 16:15

cchaos reviewed Mar 4, 2019

View reviewed changes

src/legacy/ui/public/saved_objects/components/saved_object_finder.scss Outdated Show resolved Hide resolved

flash1293 added 2 commits March 4, 2019 17:31

Rewrite saved object finder and add tests

d3b2759

Fix usages of new saved object finder

501f38a

flash1293 force-pushed the 27985/feature-embeddable-layer-add-panel branch from 962cc49 to 501f38a Compare March 4, 2019 16:31

fix test failures

bcb630c

fix some functional tests and re-introduce makeUrl

7b2fee1

flash1293 added 2 commits March 5, 2019 17:54

fix tests

21736ae

remove direct hrefs in saved_object_lists

0747c53

flash1293 changed the title ~~[wip] Use embeddable registry in add panel~~ Use embeddable registry in add panel Mar 6, 2019

flash1293 requested a review from timroes March 6, 2019 08:35

timroes mentioned this pull request Mar 6, 2019

Popover doesn't work in modal elastic/eui#1685

Closed

timroes suggested changes Mar 6, 2019

View reviewed changes

PR review fixes

6acb88e

flash1293 requested a review from a team as a code owner March 6, 2019 14:11

Merge remote-tracking branch 'upstream/master' into 27985/feature-emb…

c365aec

…eddable-layer-add-panel

cchaos approved these changes Mar 8, 2019

View reviewed changes

adjust functional tests for new filter behavior

64a273e

timroes added release_note:enhancement Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 :AppArch v7.2.0 labels Mar 11, 2019

timroes added 2 commits March 11, 2019 09:48

Merge branch 'master' into pr/31400

1f49af1

Change translation id due to string change

ac16449

timroes approved these changes Mar 11, 2019

View reviewed changes

Update Jest snapshot

7ddce1d

timroes merged commit f935c14 into elastic:master Mar 11, 2019

timroes mentioned this pull request Mar 11, 2019

[7.x] Use embeddable registry in add panel (#31400) #32885

Merged

flash1293 deleted the 27985/feature-embeddable-layer-add-panel branch March 12, 2019 22:32

This was referenced Mar 17, 2019

Replace table in SavedObjectFinder by EuiListGroup #30532

Closed

Have dashboard add panel use the embeddable layer #27985

Closed

markov00 mentioned this pull request Jun 27, 2019

Kibana 7.2 add visualization to new dashboard js error #39782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use embeddable registry in add panel #31400

Use embeddable registry in add panel #31400

flash1293 commented Feb 18, 2019

flash1293 commented Mar 4, 2019

elasticmachine commented Mar 4, 2019

elasticmachine commented Mar 4, 2019

elasticmachine commented Mar 4, 2019

elasticmachine commented Mar 5, 2019

elasticmachine commented Mar 5, 2019

elasticmachine commented Mar 5, 2019

timroes commented Mar 6, 2019

flash1293 commented Mar 6, 2019

elasticmachine commented Mar 8, 2019

cchaos left a comment

elasticmachine commented Mar 8, 2019

elasticmachine commented Mar 11, 2019

timroes left a comment

elasticmachine commented Mar 11, 2019

elasticmachine commented Mar 11, 2019

elasticmachine commented Mar 11, 2019

timroes commented Mar 11, 2019

nreese commented Mar 11, 2019

timroes commented Mar 11, 2019

Use embeddable registry in add panel #31400

Use embeddable registry in add panel #31400

Conversation

flash1293 commented Feb 18, 2019

Summary

Checklist

For maintainers

flash1293 commented Mar 4, 2019

elasticmachine commented Mar 4, 2019

💔 Build Failed

elasticmachine commented Mar 4, 2019

💔 Build Failed

elasticmachine commented Mar 4, 2019

💔 Build Failed

elasticmachine commented Mar 5, 2019

💔 Build Failed

elasticmachine commented Mar 5, 2019

💔 Build Failed

elasticmachine commented Mar 5, 2019

💚 Build Succeeded

timroes commented Mar 6, 2019

flash1293 commented Mar 6, 2019

elasticmachine commented Mar 8, 2019

💔 Build Failed

cchaos left a comment

Choose a reason for hiding this comment

elasticmachine commented Mar 8, 2019

💚 Build Succeeded

elasticmachine commented Mar 11, 2019

timroes left a comment

Choose a reason for hiding this comment

elasticmachine commented Mar 11, 2019

💚 Build Succeeded

elasticmachine commented Mar 11, 2019

💔 Build Failed

elasticmachine commented Mar 11, 2019

💚 Build Succeeded

timroes commented Mar 11, 2019

nreese commented Mar 11, 2019

timroes commented Mar 11, 2019