Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate CONFIG_PATH and DATA_PATH #32049

Merged
merged 12 commits into from
Apr 22, 2019
Merged

deprecate CONFIG_PATH and DATA_PATH #32049

merged 12 commits into from
Apr 22, 2019

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Feb 26, 2019 •
edited
Loading

CONFIG_PATH and DATA_PATH environment variables were added as a way to set the default path.data and config file.

CONFIG_PATH is ambiguous. It has been replaced with KIBANA_PATH_CONF to be consistent with elasticsearch.

DATA_PATH is ambiguous. path.data should be set in kibana.yml

@jbudz jbudz added review Team:Operations Team label for Operations Team v8.0.0 v7.2.0 labels Feb 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jbudz
Copy link
Member Author

jbudz commented Feb 26, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

mistic
mistic approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work 👍

@jbudz
Copy link
Member Author

jbudz commented Mar 26, 2019

Dropping the label, and removing docs in this PR. This is just the deprecation.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz jbudz added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 27, 2019
@jbudz jbudz mentioned this pull request Mar 29, 2019
Closed
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger
spalger approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbudz jbudz merged commit 8044305 into elastic:master Apr 22, 2019
jbudz added a commit to jbudz/kibana that referenced this pull request Apr 22, 2019
@jbudz
deprecate CONFIG_PATH and DATA_PATH (elastic#32049)
110dccf 
* rm default config from environment variable

* add deprecation logs

* fix path

* folder

* redo docs

* fix &&

* remove newline

* rm newline
jbudz added a commit that referenced this pull request Apr 22, 2019
@jbudz
[7.x] deprecate CONFIG_PATH and DATA_PATH (#32049) (#35405)
97b6b0e 
* deprecate CONFIG_PATH and DATA_PATH (#32049)

* rm default config from environment variable

* add deprecation logs

* fix path

* folder

* redo docs

* fix &&

* remove newline

* rm newline

* fix backport
@jbudz jbudz mentioned this pull request Aug 19, 2019
Merged
@jasontedor jasontedor mentioned this pull request Aug 19, 2019
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
non-issue Indicates to automation that a pull request should not appear in the release notes review Team:Operations Team label for Operations Team v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbudz @elasticmachine @spalger @mistic