[UA] Add reindex warning for mapping type changes #32081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations |
joshdover
changed the title
joshdover
commented
Feb 26, 2019
| @@ -173,37 +173,6 @@ export class WarningsFlyoutStep extends React.Component< | |||
| documentationUrl="https://www.elastic.co/guide/en/apm/get-started/master/apm-release-notes.html" | |||
| /> | |||
| )} | |||
|
|
|||
| {warnings.includes(ReindexWarning.booleanFields) && ( | |||
There was a problem hiding this comment.
Doesn't apply to 7.0 so I removed this and the allField warnings.
joshdover
force-pushed
the
ua-typename-warning
branch
from
b20a627
to
b8c4867
Compare
|
@gchaps Do you have any feedback on the copy here? For reference, here are the other warnings we've added in prior versions:
|
💔 Build Failed |
joshdover
force-pushed
the
ua-typename-warning
branch
from
b8c4867
to
621ff70
Compare
💚 Build Succeeded |
|
@joshdover Can we use the same text as in the first warning on the page: This index requires destructive changes that can't be undone Back up your index, then proceed with the reindex by accepting each breaking change. |
joshdover
force-pushed
the
ua-typename-warning
branch
from
621ff70
to
38cfa1f
Compare
💔 Build Failed |
💚 Build Succeeded |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Mar 13, 2019
tylersmalley
pushed a commit
that referenced
this pull request
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a warning to the reindex process that will display when the user is reindexing an index that does not use a type name of
_docfor the 7.x -> 8.x upgrade.Test data:
https://drive.google.com/file/d/1DNdzUgeNwsWKaDwaWQOiOzEwibouqov3/view?usp=sharing