Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UA] Add reindex warning for mapping type changes #32081

Merged
merged 2 commits into from Mar 13, 2019

Conversation

Projects
None yet
4 participants
@joshdover
Copy link
Member

joshdover commented Feb 26, 2019

Summary

This adds a warning to the reindex process that will display when the user is reindexing an index that does not use a type name of _doc for the 7.x -> 8.x upgrade.

image

Test data:
https://drive.google.com/file/d/1DNdzUgeNwsWKaDwaWQOiOzEwibouqov3/view?usp=sharing

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 26, 2019

@joshdover joshdover changed the title Add reindex warning for mapping type changes [UA] Add reindex warning for mapping type changes Feb 26, 2019

@@ -173,37 +173,6 @@ export class WarningsFlyoutStep extends React.Component<
documentationUrl="https://www.elastic.co/guide/en/apm/get-started/master/apm-release-notes.html"
/>
)}

{warnings.includes(ReindexWarning.booleanFields) && (

This comment has been minimized.

@joshdover

joshdover Feb 26, 2019

Author Member

Doesn't apply to 7.0 so I removed this and the allField warnings.

@joshdover joshdover force-pushed the joshdover:ua-typename-warning branch from b20a627 to b8c4867 Feb 26, 2019

@joshdover

This comment has been minimized.

Copy link
Member Author

joshdover commented Feb 26, 2019

@gchaps Do you have any feedback on the copy here? For reference, here are the other warnings we've added in prior versions:

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 26, 2019

@joshdover joshdover force-pushed the joshdover:ua-typename-warning branch from b8c4867 to 621ff70 Feb 26, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 26, 2019

@gchaps

This comment has been minimized.

Copy link
Contributor

gchaps commented Feb 27, 2019

@joshdover Can we use the same text as in the first warning on the page:

This index requires destructive changes that can't be undone

Back up your index, then proceed with the reindex by accepting each breaking change.

@joshdover joshdover force-pushed the joshdover:ua-typename-warning branch from 621ff70 to 38cfa1f Mar 12, 2019

@joshdover joshdover requested a review from elastic/kibana-operations Mar 12, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2019

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 12, 2019

@tylersmalley
Copy link
Member

tylersmalley left a comment

LGTM, tested

@joshdover joshdover merged commit 2c28d30 into elastic:7.x Mar 13, 2019

2 checks passed

CLA All commits in pull request signed
Details
kibana-ci Build finished.
Details

@joshdover joshdover deleted the joshdover:ua-typename-warning branch Mar 13, 2019

joshdover added a commit to joshdover/kibana that referenced this pull request Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.