-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BeatsCM] Paginate beats and tags on the API #32667
[BeatsCM] Paginate beats and tags on the API #32667
Conversation
💔 Build Failed |
💔 Build Failed |
…e additional complexity
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
…testing_framework_adapter.ts Co-Authored-By: mattapperson <me@mattapperson.com>
💔 Build Failed |
@justinkambic for the access issue, try clearing browser cache and optimize folder. This was an issue before I made a change to rendering. That change might not be making it through an old optimizer build |
…hub.com/mattapperson/kibana into beats/after-return-type/page-beats-tags
💔 Build Failed |
EDIT: I accidentally conducted this test on So, everything I tried when doing a functional review worked ok. My process was to:
Something worth mentioning - buttons required double-clicks in some cases (I know this has been an issue in the past, so it may be the same one), and the beats list didn't update after I enrolled beats, only if I navigated to a different page/view and back to it, seen below. Note
Aside from that this looks like it's working ok! |
💔 Build Failed |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
Pinging @elastic/beats |
💚 Build Succeeded |
LGTM, need rebase. |
Let's rebase and merge this @mattapperson |
💚 Build Succeeded |
Is this feature stalled? Or still planed for merge? |
💔 Build Failed |
Currently CM paginates beats and tags but it does so in-memory in the browser. Each API request returns ALL beats and tags.
This PR paginates these items on an API level for drastically improved perf on large scale deployments.
Note: Depends on
#31660
Also fixes:
And adds a new feature of: