[intepreter][Canvas] Dedupe server functions in batched requests #32712
Conversation
clintandrewhall
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
💔 Build Failed |
|
|
||
| // Check to see if this is a duplicate server function. | ||
| const duplicate = Object.values(batch).find(batchedRequest => | ||
| _.isMatch(batchedRequest.request, request) |
There was a problem hiding this comment.
Looks like you're using isMatch here instead of isEqual because you're trying to ignore the id param. Is that right?
There was a problem hiding this comment.
Yes, that's right.
|
@w33ble Here's the difference with YDYW: about 600k savings overall. Seems like a good fix... it would be amazing if we could batch that across requests. Had we not decided to start loading pages separately, we probably could have done that. I'll add some tests.
|
|
Batching the pages saved another 600k. But the interface got clunky. So caching similar requests from other pages would have the same sized savings as this fix.
|
You might be able to find a sweet spot by tweaking that timeout in the batched fetch code. 10ms is pretty small, maybe something like 25, 50, or 100 would let you de-dupe more without a noticable lag. It still wouldn't help across multiple pages, but it may speed up inital loading for each one. Just a guess though. |
💚 Build Succeeded |
…stic#32712) * [intepreter][Canvas] Dedupe server functions in batched requests * Add and correct tests
…stic#32712) * [intepreter][Canvas] Dedupe server functions in batched requests * Add and correct tests
…stic#32712) * [intepreter][Canvas] Dedupe server functions in batched requests * Add and correct tests
#32712) (#32833) * [intepreter][Canvas] Dedupe server functions in batched requests (#32712) * [intepreter][Canvas] Dedupe server functions in batched requests * Add and correct tests * Update interpreter.test.js Fix merge error * Delete batched_fetch.test.js This file was not present in the branch and is failing.
) (#32830) * [intepreter][Canvas] Dedupe server functions in batched requests * Add and correct tests
…stic#32712) * [intepreter][Canvas] Dedupe server functions in batched requests * Add and correct tests
…stic#32712) * [intepreter][Canvas] Dedupe server functions in batched requests * Add and correct tests
…stic#32712) * [intepreter][Canvas] Dedupe server functions in batched requests * Add and correct tests
Summary
Currently, if a set of batched function calls are identical, they are all called. For example, if a page calls for
demodatain a number of elements,demodatais requested and returned for each element, (ballooning the size of the response).This PR dedupes the server calls, greatly reducing the payload size.
Before:
After: