[APM] [7.0] Moving the date picker into APM (#31311) #32729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
jasonrhodes
changed the title
* WIP moving the date picker into APM * Stable version of EUI date picker controls, still needs layout * Flex layout for kuery bar and date picker * Removes angular time picker logic and layout * Fixes snapshot test * Adds integration tests for date picker * Simplifies refresh cycle with setTimeout over requestAnimationFrame * Removes rison and local state from APM date picker flow * Adds refresh tests, fixes some refresh logic * Moves temporary EUI types out of component * Moves toBoolean helper and fixes TS error * Removes unused Link import * Types for datepicker (WIP) * Updates default date picker values after merging in Søren's type changes * Streamlines new APM query types to prevent duplication * Uses jest fake timers for refresh tests * Updates url handling to remove Rison from APM URLs, keeps Rison in outgoing Kibana links * Move filter bar up and out from within a react-redux-request to avoid catch-22 circular dependency * Separates rison encoding from regular url handling * Sets start and end defaults in urlParams reducer * Adds IUrlParams type to initial state with correct typing * Updated rison-related snapshots * Resolves failing tests related to query param management * Adds more tests for Kibana Link and Kibana Rison Link components * Re-enables the update button for the EUI super date picker * Adds more Discover link tests * Moved getRenderedHref to testHelpers, switched Discover Links integration tests to TS, and added ML link integration test * Changes how getRenderedHref works to make it clearer where location state is coming from * Updates obsolete snapshot * Fixes typescript-discovered errors and type errors * Finishes up url_helpers tests, removes dead commented tests * Removes temporary date picker types from APM * Fixes common case for an existing URL bug by not encoding range params
jasonrhodes
force-pushed
the
backport/7.0/pr-31311
branch
from
e3a6328
to
ad701f1
Compare
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #31311 into 7.0
WIP moving the date picker into APM
Stable version of EUI date picker controls, still needs layout
Flex layout for kuery bar and date picker
Removes angular time picker logic and layout
Fixes snapshot test
Adds integration tests for date picker
Simplifies refresh cycle with setTimeout over requestAnimationFrame
Removes rison and local state from APM date picker flow
Adds refresh tests, fixes some refresh logic
Moves temporary EUI types out of component
Moves toBoolean helper and fixes TS error
Removes unused Link import
Types for datepicker (WIP)
Updates default date picker values after merging in Søren's type changes
Streamlines new APM query types to prevent duplication
Uses jest fake timers for refresh tests
Updates url handling to remove Rison from APM URLs, keeps Rison in outgoing Kibana links
Move filter bar up and out from within a react-redux-request to avoid catch-22 circular dependency
Separates rison encoding from regular url handling
Sets start and end defaults in urlParams reducer
Adds IUrlParams type to initial state with correct typing
Updated rison-related snapshots
Resolves failing tests related to query param management
Adds more tests for Kibana Link and Kibana Rison Link components
Re-enables the update button for the EUI super date picker
Adds more Discover link tests
Moved getRenderedHref to testHelpers, switched Discover Links integration tests to TS, and added ML link integration test
Changes how getRenderedHref works to make it clearer where location state is coming from
Updates obsolete snapshot
Fixes typescript-discovered errors and type errors
Finishes up url_helpers tests, removes dead commented tests
Removes temporary date picker types from APM
Fixes common case for an existing URL bug by not encoding range params