Add percentile ranks metric support

[drej82]

Added support for percentile rank metric to kibana. issue #3330
I've never used node.js before, so chosen approach might be wrong.

[rashidkpc]

it would appear that the email you've signed the CLA with does not match your github profile. Can you double check that so we can review this pull?

Also it appear the tests are failing

[drej82]

Thanks, Rashid. I saw the test error, for some reason I didn't spot it on my box, maybe I didn't delete old file after renaming. I will fix it. CLA seems to be fine.

[drej82]

Apparently, not all unit tests are run on my dev box. Maybe because it's Windows setup.

[spalger]

Would you mind moving the valueBoundaries argument into the attributes of the element where values-list is specified?

Something like:

<input type="text" value-list="some.property" value-list-min="0" value-list-max="100">

and

link: function ($scope, $el, attrs) {
  var min = _.parseInt(attrs.valueListMin);
  if (isNaN(min)) throw new TypeError('invalid value-list-min: ' + attrs.valueListMin);

  var max = _.parseInt(attrs.valueListMax);
  if (isNaN(max)) throw new TypeError('invalid value-list-max: ' + attrs.valueListMax);
}

[spalger]

Left some comments inline, but can you do me a favor and explain how you plan to use the percentile_rank metric? 😅

[drej82]

@spalger,
RE: how you plan to use the percentile_rank metric

I want to have SLA in form - xx% request should complete within yy sec, to see whether my service satisfies SLA I want to use percentile_rank metric. Of course, I could create a lot of percentiles and see how many secs request takes on different %tiles, but I want to have one number to see how far the service from SLA. Does it make sense?

[spalger]

@drej82 sweet! that totally makes sense.

Here is an image of a percentile_rank agg showing that:

• 3.675% of requests in the selected time range were less than 100 bytes
• 9.479% were less than 1,000 bytes
• 94.748% were less than 10,000 bytes
• 100% were less than 100,000 bytes

[spalger]

LGTM! Thanks @drej82! 🍻

[drej82]

Cool, thanks!