Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes getConnections log in new platform #34934

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Apr 11, 2019

This log is extremely noisy when running with verbose logging. I remember someone mentioning it's no longer needed and would like to remove if that is still the case.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc non-issue Indicates to automation that a pull request should not appear in the release notes v8.0.0 v7.2.0 labels Apr 11, 2019
@tylersmalley tylersmalley requested a review from a team as a code owner April 11, 2019 14:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember someone mentioning it's no longer needed and would like to remove if that is still the case.

Yeah, thanks for removing this! It meant to be used only during developing of "new platform hapi proxy", but then it slipped under my radar.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tylersmalley tylersmalley merged commit c1ce349 into elastic:master Apr 11, 2019
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Apr 11, 2019
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
chandlerprall pushed a commit to chandlerprall/kibana that referenced this pull request Apr 15, 2019
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Apr 25, 2019
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue Indicates to automation that a pull request should not appear in the release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants