-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for time-based interval index patterns #35173
Remove support for time-based interval index patterns #35173
Conversation
Pinging @elastic/kibana-app-arch |
c9f0c09
to
8cc9f9b
Compare
💔 Build Failed |
💔 Build Failed |
@lukasolson You'll need to add this change to the breaking changes doc. The 8.0 breaking changes doc is here. The content should be in this format: Support for time-based index patterns was removed Details: Time-based interval index patterns were deprecated in 5.x. In 6.x, you could no longer create time-based interval index patterns, but they continued to function as expected. Support for these index patterns has been removed in 8.0. Impact: You must migrate your time_based index patterns to a wildcard pattern, for example, logstash-*. Instructions on how to migrate would be helpful here Let me know if you'd like any help with this. |
Breaking changes added here: #35314 |
8cc9f9b
to
09be961
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
Code looks good to me and regular index patterns still functional normally. One question though. If I have an interval based index pattern in 8.0 now there is no indication whatsoever that support for them has been removed. They stop working in Discover, Visualize, etc, but if I look at the management screen it looks totally fine. Should we still display some sort of error so the user knows what's going on? Or are we going to add steps to the migration assistant to ensure that interval based patterns cannot exist in 8.0? |
@Bargs The hope here is to add some steps to the migration assistant. Ideally no one would get into a situation where they have one of these index patterns in 8.0. |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I do think we should definitely have this in the upgrade assistant.
Time-based interval index patterns were deprecated in 5.x. In 6.x, you could no longer create time-based interval index patterns, but they continued to function as expected. Support for these index patterns has been removed.