Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for time-based interval index patterns #35173

Merged
merged 6 commits into from
May 2, 2019

Conversation

lukasolson
Copy link
Member

Time-based interval index patterns were deprecated in 5.x. In 6.x, you could no longer create time-based interval index patterns, but they continued to function as expected. Support for these index patterns has been removed.

@lukasolson lukasolson added release_note:breaking Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 :AppArch labels Apr 16, 2019
@lukasolson lukasolson self-assigned this Apr 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lukasolson lukasolson force-pushed the removeIntervalIndexPatterns branch 2 times, most recently from c9f0c09 to 8cc9f9b Compare April 16, 2019 18:11
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@gchaps
Copy link
Contributor

gchaps commented Apr 17, 2019

@lukasolson You'll need to add this change to the breaking changes doc. The 8.0 breaking changes doc is here.

The content should be in this format:

Support for time-based index patterns was removed

Details: Time-based interval index patterns were deprecated in 5.x. In 6.x, you could no longer create time-based interval index patterns, but they continued to function as expected. Support for these index patterns has been removed in 8.0.

Impact: You must migrate your time_based index patterns to a wildcard pattern, for example, logstash-*. Instructions on how to migrate would be helpful here

Let me know if you'd like any help with this.

@lukasolson
Copy link
Member Author

lukasolson commented Apr 18, 2019

Breaking changes added here: #35314

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lukasolson lukasolson requested a review from Bargs April 25, 2019 19:05
@Bargs
Copy link
Contributor

Bargs commented Apr 26, 2019

Code looks good to me and regular index patterns still functional normally. One question though. If I have an interval based index pattern in 8.0 now there is no indication whatsoever that support for them has been removed. They stop working in Discover, Visualize, etc, but if I look at the management screen it looks totally fine. Should we still display some sort of error so the user knows what's going on? Or are we going to add steps to the migration assistant to ensure that interval based patterns cannot exist in 8.0?

@lukasolson
Copy link
Member Author

@Bargs The hope here is to add some steps to the migration assistant. Ideally no one would get into a situation where they have one of these index patterns in 8.0.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I do think we should definitely have this in the upgrade assistant.

@lukasolson lukasolson merged commit e7b018e into elastic:master May 2, 2019
@lukasolson lukasolson deleted the removeIntervalIndexPatterns branch December 2, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:breaking v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants