Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused indexPattern:fieldMapping:lookBack advanced setting #58147

Merged
merged 3 commits into from
Feb 24, 2020

Conversation

lukasolson
Copy link
Member

Summary

The advanced setting, indexPattern:fieldMapping:lookBack, was used only when creating time-based interval index patterns. It would allow you to specify how far back to look for matching indices. However, support for these types of index patterns was removed in #35173 and #35262. Since this setting is no longer used, this PR removes it (and its documentation).

For testers

No changes to test as part of this PR.

@lukasolson lukasolson added Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 20, 2020
@lukasolson lukasolson self-assigned this Feb 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukasolson lukasolson requested a review from a team February 20, 2020 16:43
@lukasolson lukasolson added this to In progress in kibana-app-arch via automation Feb 20, 2020
@lukasolson lukasolson moved this from In progress to Review in progress in kibana-app-arch Feb 20, 2020
@lukasolson
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukasolson lukasolson merged commit 7e08763 into elastic:master Feb 24, 2020
kibana-app-arch automation moved this from Review in progress to Done in current release Feb 24, 2020
lukasolson added a commit to lukasolson/kibana that referenced this pull request Feb 24, 2020
…astic#58147)

* Remove unused indexPattern:fieldMapping:lookBack advanced setting

* Remove unused translations

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@lukasolson
Copy link
Member Author

7.x (7.7.0): 2065ac5

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 58147 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 25, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 58147 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 58147 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0
Projects
kibana-app-arch
  
Done in current release
Development

Successfully merging this pull request may close these issues.

None yet

5 participants