Add columns from doc table #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 7, 2015 07:22
rashidkpc
force-pushed
the
experiment/add-column-from-doc
branch
2 times, most recently
from
425053b
to
542638f
Compare
| <span ng-click="sort(name)" class="table-header-name" tooltip="{{tooltip(name)}}"> | ||
| {{name | shortDots}} <i ng-class="headerClass(name)"></i> | ||
| <span class="table-header-name"> | ||
| {{name | shortDots}} <i ng-class="headerClass(name)" ng-click="sort(name)" tooltip="{{tooltip(name)}}" tooltip-append-to-body="1"></i> |
There was a problem hiding this comment.
I moved the click out to the sort icon and away from the entire header. There were enough icons up there that it was getting confusing.
|
I am currently able to get discover into a state where no columns are selected. Reproducing it is tricky, but both rashid and myself were able to reproduce it.
|
|
Should be fixed. |
|
An extra history entry is being created when discover is initialized, if you click the discover navbar tab to refresh the app state the columns are reset properly to just _source, but now you can't use the back button. |
|
Pretty sure this is a problem in the grid, but if you use the back button to remove a column from the data table in the dashboard, the entire dashboard is rebuilt. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3277
Advanced apologies for size. Most of the red comes from removing functionality from the discover controller (yay!) and moving it out to the doc_table.
Enhancements:
Changes:
$scope.fieldsstructure has been removed from discover and is now built as a reaction to the columns array changing. Thus it is not passed into the fieldChooser directive, rather $scope.columns is passed in.