Moved query bar into data plugin #35390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch |
💔 Build Failed |
|
rebuild |
|
I'm curious why kibana-intake is failing. |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
added 2 commits
April 24, 2019 13:39
|
@elastic/kibana-design only moved css |
💚 Build Succeeded |
cchaos
approved these changes
Apr 24, 2019
lukeelmers
reviewed
Apr 26, 2019
There was a problem hiding this comment.
LGTM - would you mind updating the dev docs entry since we are actually moving the query bar here?
src/legacy/core_plugins/data/public/index_patterns/index_patterns_service.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
added 2 commits
April 29, 2019 13:18
…newplatform/data-plugin/query-bar
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Apr 30, 2019
* moved query bar to data plugin
lizozom
pushed a commit
that referenced
this pull request
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved query bar to data plugin.
This is split from #35300
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility