[ML] Set noopener feature when opening non-Kibana custom URLs #36205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
:ml
Feature:ml-results
|
Pinging @elastic/ml-ui |
peteharverson
added
release_note:skip
| @@ -119,7 +119,11 @@ export const LinksMenu = injectI18n(class LinksMenu extends Component { | |||
| // Replace any tokens in the configured url_value with values from the source record, | |||
| // and then open link in a new tab/window. | |||
| const urlPath = replaceStringTokens(customUrl.url_value, record, true); | |||
| window.open(urlPath, '_blank'); | |||
| if (isKibanaUrl(customUrl) === true) { | |||
There was a problem hiding this comment.
this block of code is repeated a few times, would it be worth moving it to a function in custom_url_utils.js called openURL or something similar?
💔 Build Failed |
peteharverson
force-pushed
the
ml-custom-url-noopener
branch
from
36e869c
to
39e7a46
Compare
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
May 8, 2019
…c#36205) * [ML] Set noopener feature when opening non Kibana custom URLs * [ML] Refactor calls to open window into separate utils function
peteharverson
added a commit
that referenced
this pull request
May 8, 2019
#36272) * [ML] Set noopener feature when opening non Kibana custom URLs * [ML] Refactor calls to open window into separate utils function
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
May 8, 2019
…c#36205) * [ML] Set noopener feature when opening non Kibana custom URLs * [ML] Refactor calls to open window into separate utils function
peteharverson
added a commit
that referenced
this pull request
May 8, 2019
#36279) * [ML] Set noopener feature when opening non Kibana custom URLs * [ML] Refactor calls to open window into separate utils function
This was referenced May 8, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
noopenerandnoreferreras window features to the popup window opened for custom URLs thatuse third party domains.
Checklist