Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas - adding quick range Today #36698

Merged
merged 2 commits into from
May 22, 2019
Merged

Canvas - adding quick range Today #36698

merged 2 commits into from
May 22, 2019

Conversation

EnnioRC
Copy link
Contributor

@EnnioRC EnnioRC commented May 20, 2019

Canvas - Adding quick range Today

@EnnioRC EnnioRC requested a review from a team as a code owner May 20, 2019 15:45
@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@shaunmcgough shaunmcgough added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label May 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

Copy link
Contributor

@w33ble w33ble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, filter seems to be applied correctly:

Last 24 Hours (includes records from yesterday)

Screenshot 2019-05-20 13 22 06

Today so far (only includes records from today)

Screenshot 2019-05-20 13 22 16

@w33ble w33ble requested a review from cqliu1 May 20, 2019 20:24
@w33ble
Copy link
Contributor

w33ble commented May 20, 2019

jenkins test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@EnnioRC
Copy link
Contributor Author

EnnioRC commented May 21, 2019

Do I need to do anything else to merge?

@shaunmcgough
Copy link

LGTM, thanks for reviewing @w33ble !

@w33ble
Copy link
Contributor

w33ble commented May 22, 2019

@EnnioRC nope, I'm on it. Thanks for the submission!

FYI, you'll see this in 7.2.0.

Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cqliu1 cqliu1 merged commit 66bdb10 into elastic:master May 22, 2019
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request May 22, 2019
* Update time_picker.js

* Adding quick range Today
cqliu1 added a commit that referenced this pull request May 22, 2019
* Update time_picker.js

* Adding quick range Today
@EnnioRC
Copy link
Contributor Author

EnnioRC commented May 23, 2019

Thank you guys! @w33ble @cqliu1 @shaunmcgough
God bless you all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants