Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KQL in TSVB #36784

Merged
merged 25 commits into from Jun 5, 2019
Merged

KQL in TSVB #36784

merged 25 commits into from Jun 5, 2019

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented May 21, 2019

Summary

Using KQL with the autocomplete it offers makes it easier to create a query without the need to remember the exact field name and it assists with operators and values.

This PR replaces the text input fields for filters in the Visual Builder with QueryBarInput components that update as a query is entered with the option of using Kuery syntax with autocomplete or Lucene syntax.

A migration was needed to transform the filter strings in visualizations to filter query objects, containing the original string and the query language. We assume that if the query language is not present, it is Lucene syntax.
References #29790, #30177

PR in favor of #36175

References Support KQL in TSVB Filter aggregations
Adds KQL to Visual Builder (TSVB)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

  • This was checked for breaking API changes and was labeled appropriately - no breaking changes are introduced.
    - [ ] This includes a feature addition or change that requires a release note and was labeled appropriately
    KQL_in_TSVB_low

@TinaHeiligers TinaHeiligers requested review from a team and Bargs May 21, 2019 15:15
@elasticmachine
Copy link
Contributor

💔 Build Failed

@TinaHeiligers
Copy link
Contributor Author

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@TinaHeiligers
Copy link
Contributor Author

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@TinaHeiligers TinaHeiligers force-pushed the KQL_in_TSVB branch 2 times, most recently from 1f9ae36 to 6a91b0c Compare May 24, 2019 18:24
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@TinaHeiligers TinaHeiligers force-pushed the KQL_in_TSVB branch 2 times, most recently from aa27c84 to 352e227 Compare May 24, 2019 21:58
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple other things in addition to the inline comments:

  • I think we should update the saved objects in the sample data sets and change the queries to use KQL where possible
  • The current use of screenTitle on the QueryBarInput creates non-sensical aria-labels like “You are on search box of TimeseriesPanelConfigQuery page. Start typing to search and filter the VisEditor”. My filters agg PR makes this prop optional. It also updates the query_bar_input to pass down the ID EUI creates to the underlying input element so that screenreaders will automatically read the correct label for the input (although passing the id explicitly won't be necessary if you end up passing all unknown props to the input element, as I suggested in one of the inline comments). You could cherry-pick the commit where I did that, or simply merge in master if my PR gets merged first.

I've mainly looked at the code so far. I'd like to get some time with you to go through the functionality. I'm having issues getting TSVB to display data, but this is an issue for me in master as well, so I think I'm doing something wrong.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@TinaHeiligers TinaHeiligers requested a review from Bargs June 4, 2019 23:58
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just a couple things that I noticed:

  • One of the sample saved objects that has a filter string still needs updated: "[eCommerce] Sold Products per Day”
  • Still need to remove screenTitle prop everywhere now that it's optional

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@TinaHeiligers TinaHeiligers merged commit 84b595e into elastic:master Jun 5, 2019
@TinaHeiligers TinaHeiligers deleted the KQL_in_TSVB branch June 5, 2019 23:07
simianhacker pushed a commit to simianhacker/kibana that referenced this pull request Jun 6, 2019
* Squashed commit of the following:

commit 0cff824
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Mon May 20 16:16:15 2019 -0700

    Adds ignore_lobal_filter YesNo component back

    Deletes fixtures file

commit e54e169
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Mon May 20 14:39:21 2019 -0700

    squash-merges adding KQL with the full QueryBar and SavedObject migrations

Debugging

Adds filter defaults

Updates index pattern for the QueryBar on componentDidUpdate

squash-merges adding KQL with the full QueryBar and SavedObject migrations required

Adds ignore_lobal_filter YesNo component back

Deletes fixtures file

Updates migration test number

* Changes QueryBar to QueryBarInput in TimeseriesPanelConfigUi

Replaces QueryBar with QueryBarInput in Timeseries

Changes QueryBar to QueryBarInput in TSVB Metric

Changes QueryBar to QueryBarInput in other TSVB visualisation editors

Removes async from componentWillMount

changes indexPattern to indexPatternObject in series and table query request processors

* Squashed commit of the following:

commit 2c3107963cff20b2d24323fddfaf80c848b86848
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 15:15:06 2019 -0700

    Cleans up comments

commit 943150d4b9b71183e9d5b26c95449ea4519aad4c
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 14:09:53 2019 -0700

    Cleans up parser check more

commit d31de88525595720556440ae71515f5772774eaa
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 14:01:02 2019 -0700

    Cleans up parser check

commit b592071b1d939ec2df9b9c921d57a22dac54e703
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 13:16:55 2019 -0700

    skips server call on invalid kuery queries

Cleans up

Deletes duplicate migration function

Adds 's' to split_by_filters method

Resolves issues after rebase

* Removes quotes around index pattern strings passed into fetch_index_patterns, adds comments on reasoning

* queryBar to queryBarInput

Adds transformFilterStringToQueryObject back to visualizations migrations that was lost during rebase

* Deletes unused code

* Fixes migrations test

* compiles visualizations migrations for version 7.3.0

* temporary change to query_bar_input fetch_index_patterns file

formatting

Includes code from PR#37413

Clean up

* Formatting

* Uses series index pattern when override_index_pattern is selected and an index pattern is provided

* Removes empty object as alternative to localStorage

* Removes handelQueryChange from where it is not needed

* extracts retrieval of the default query language from uiSettings into a helper method

* Resolves some PR comments

* Handles Query Error from an invalid syntax query

* Converts string queries into objects with kuery as the language in saved_objects data for ecommerce, flights and logs TSVB visualizations

* Deletes unused translation items

* Adds optional id prop to the query_bar_input and makes the screenTitle optional

* Updates [eCommerce] Sold Products per Day

* Removes screenTitle from component QueryBarInput

* Wraps index pattern strings in a double quote to allow for names such as 'logstash-*'
TinaHeiligers added a commit to TinaHeiligers/kibana that referenced this pull request Jun 6, 2019
* Squashed commit of the following:

commit 0cff824
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Mon May 20 16:16:15 2019 -0700

    Adds ignore_lobal_filter YesNo component back

    Deletes fixtures file

commit e54e169
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Mon May 20 14:39:21 2019 -0700

    squash-merges adding KQL with the full QueryBar and SavedObject migrations

Debugging

Adds filter defaults

Updates index pattern for the QueryBar on componentDidUpdate

squash-merges adding KQL with the full QueryBar and SavedObject migrations required

Adds ignore_lobal_filter YesNo component back

Deletes fixtures file

Updates migration test number

* Changes QueryBar to QueryBarInput in TimeseriesPanelConfigUi

Replaces QueryBar with QueryBarInput in Timeseries

Changes QueryBar to QueryBarInput in TSVB Metric

Changes QueryBar to QueryBarInput in other TSVB visualisation editors

Removes async from componentWillMount

changes indexPattern to indexPatternObject in series and table query request processors

* Squashed commit of the following:

commit 2c3107963cff20b2d24323fddfaf80c848b86848
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 15:15:06 2019 -0700

    Cleans up comments

commit 943150d4b9b71183e9d5b26c95449ea4519aad4c
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 14:09:53 2019 -0700

    Cleans up parser check more

commit d31de88525595720556440ae71515f5772774eaa
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 14:01:02 2019 -0700

    Cleans up parser check

commit b592071b1d939ec2df9b9c921d57a22dac54e703
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 13:16:55 2019 -0700

    skips server call on invalid kuery queries

Cleans up

Deletes duplicate migration function

Adds 's' to split_by_filters method

Resolves issues after rebase

* Removes quotes around index pattern strings passed into fetch_index_patterns, adds comments on reasoning

* queryBar to queryBarInput

Adds transformFilterStringToQueryObject back to visualizations migrations that was lost during rebase

* Deletes unused code

* Fixes migrations test

* compiles visualizations migrations for version 7.3.0

* temporary change to query_bar_input fetch_index_patterns file

formatting

Includes code from PR#37413

Clean up

* Formatting

* Uses series index pattern when override_index_pattern is selected and an index pattern is provided

* Removes empty object as alternative to localStorage

* Removes handelQueryChange from where it is not needed

* extracts retrieval of the default query language from uiSettings into a helper method

* Resolves some PR comments

* Handles Query Error from an invalid syntax query

* Converts string queries into objects with kuery as the language in saved_objects data for ecommerce, flights and logs TSVB visualizations

* Deletes unused translation items

* Adds optional id prop to the query_bar_input and makes the screenTitle optional

* Updates [eCommerce] Sold Products per Day

* Removes screenTitle from component QueryBarInput

* Wraps index pattern strings in a double quote to allow for names such as 'logstash-*'
TinaHeiligers added a commit that referenced this pull request Jun 7, 2019
* Squashed commit of the following:

commit 0cff824
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Mon May 20 16:16:15 2019 -0700

    Adds ignore_lobal_filter YesNo component back

    Deletes fixtures file

commit e54e169
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Mon May 20 14:39:21 2019 -0700

    squash-merges adding KQL with the full QueryBar and SavedObject migrations

Debugging

Adds filter defaults

Updates index pattern for the QueryBar on componentDidUpdate

squash-merges adding KQL with the full QueryBar and SavedObject migrations required

Adds ignore_lobal_filter YesNo component back

Deletes fixtures file

Updates migration test number

* Changes QueryBar to QueryBarInput in TimeseriesPanelConfigUi

Replaces QueryBar with QueryBarInput in Timeseries

Changes QueryBar to QueryBarInput in TSVB Metric

Changes QueryBar to QueryBarInput in other TSVB visualisation editors

Removes async from componentWillMount

changes indexPattern to indexPatternObject in series and table query request processors

* Squashed commit of the following:

commit 2c3107963cff20b2d24323fddfaf80c848b86848
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 15:15:06 2019 -0700

    Cleans up comments

commit 943150d4b9b71183e9d5b26c95449ea4519aad4c
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 14:09:53 2019 -0700

    Cleans up parser check more

commit d31de88525595720556440ae71515f5772774eaa
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 14:01:02 2019 -0700

    Cleans up parser check

commit b592071b1d939ec2df9b9c921d57a22dac54e703
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 13:16:55 2019 -0700

    skips server call on invalid kuery queries

Cleans up

Deletes duplicate migration function

Adds 's' to split_by_filters method

Resolves issues after rebase

* Removes quotes around index pattern strings passed into fetch_index_patterns, adds comments on reasoning

* queryBar to queryBarInput

Adds transformFilterStringToQueryObject back to visualizations migrations that was lost during rebase

* Deletes unused code

* Fixes migrations test

* compiles visualizations migrations for version 7.3.0

* temporary change to query_bar_input fetch_index_patterns file

formatting

Includes code from PR#37413

Clean up

* Formatting

* Uses series index pattern when override_index_pattern is selected and an index pattern is provided

* Removes empty object as alternative to localStorage

* Removes handelQueryChange from where it is not needed

* extracts retrieval of the default query language from uiSettings into a helper method

* Resolves some PR comments

* Handles Query Error from an invalid syntax query

* Converts string queries into objects with kuery as the language in saved_objects data for ecommerce, flights and logs TSVB visualizations

* Deletes unused translation items

* Adds optional id prop to the query_bar_input and makes the screenTitle optional

* Updates [eCommerce] Sold Products per Day

* Removes screenTitle from component QueryBarInput

* Wraps index pattern strings in a double quote to allow for names such as 'logstash-*'
jfsiii pushed a commit that referenced this pull request Jun 11, 2019
* skip Code History functional tests on Firefox (#37954)

* [Logs UI] Include correct fields in "entries after" query (#37881)

This fixes #37704 by correcting the fields list used in the second part of the `getLogEntriesBetween` library function.

* [ML] Reverting incorrectly removed scope parameters (#37873)

* [ML] Reverting incorrectly removed scope parameters

* removing  no-unused-vars comments

* [Watcher] Reverting incorrectly removed scope parameters (#37875)

* [Watcher] Reverting incorrectly removed scope parameters

* removing  no-unused-vars comments

* [Vis: Default editor] EUIficate IP Ranges (#36896)

* Create IpRangeType and IpRanges controls

* Add validation

* Refactoring

* Add behavior when discarding changes

* Refactoring: create common input list

* Remove old template

* Move add btn to input_list, add placeholder

* Remove unused directives

* Remove unused translations

* Refactoring

* Use EuiButtonGroup instead of toggle button

* Update options ids, add aria-labels

* Remove unused translations

* Update mask model, update TS, update aria labels

* Add validation for CIRD mask

* Security - display message when logging out of kibana (#37234)

* display message when logging out of kibana

* update provider tests

* fix token logout test

* remove newline

* Feature Controls - update base privilege tooltip (#37868)

* Feature Controls - automatically grant access to short urls (#37532)

* automatically grant access to short urls

* adds API integration tests

* Update x-pack/test/api_integration/apis/short_urls/index.ts

Co-Authored-By: Brandon Kobel <brandon.kobel@gmail.com>

* [i18n] [docs] Update docs to encourage static i18n import (#37858)

* update documentation

* Update docs/development/plugin/development-plugin-localization.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update packages/kbn-i18n/GUIDELINE.md

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update packages/kbn-i18n/GUIDELINE.md

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update packages/kbn-i18n/GUIDELINE.md

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update packages/kbn-i18n/GUIDELINE.md

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update packages/kbn-i18n/GUIDELINE.md

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update packages/kbn-i18n/GUIDELINE.md

* Update packages/kbn-i18n/GUIDELINE.md

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update packages/kbn-i18n/README.md

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update packages/kbn-i18n/README.md

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Add section about OpenID Connect in docs (#37525)

* Add functional test to cover heartbeat location data. (#37891)

* Fix bug when you delete column (#37946)

* remove unneeded eslint-disable directives (#37922)

* remove unneeded eslint-disable directives

* [Canvas] Fix workpad list overflow (#37345)

* fix workpad list overflow

* make file picker full width on small devices

* fix modal height, add comments

* Add repository-azure autocompletion settings to Console (#37935)

Add repository-azure as an option when creating a repository.

* Add 1/2 second sleep to fix test (#37903)

* [SIEM] Fix IP Overview query to query for most recent Host (#37723)

## Summary

As outlined in https://github.com/elastic/ingest-dev/issues/453, this PR fixes the `IP Overview` query to query for the most recent Host.

Now the Host Data shown will be the most recent host for the given IP regardless of whether `Source` or `Destination` is selected in the FlowTargetSelect.

![image](https://user-images.githubusercontent.com/2946766/58731558-46fb5200-83ac-11e9-97d5-7db5dd8ac84e.png)


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

* [SIEM] Host Details Page Updates (#37769)

* toggle to exclude host ID links on host details pg

* first attempt at hiding host column

* switch to conditionally splicing array of columns

* exclude dest from auth table on host details pg

* minor overview style touchups

* rm some extranous EuiFlexGroup; more need removal

* snapshots update

* Revert "snapshots update"

This reverts commit bdd6b8e3165b7488ade99a349d1a181f4abd17f9.

* update siem snapshots

* remove unused arg

* change uncommon process column order per #503

* simplify if condition, per steph

* update tests, per steph

* simplify `hostIdRenderer` per xavier

* update snapshots

* fix/improve unit tests, per xavier

* Revert "update snapshots"

This reverts commit dc0f79606bb508c657cf380eaa9028f1c3e0c845.

* add host links in uncommon processes table

* update uncommon process test, thx to xavier

* [SIEM] Authentication fixes for winlogbeat and ordering (#37718)

## Summary
  * Enabled winlogbeat to work with workaround for authentication_failed (until that is fixed)
  * Fixed ordering to be successes first, failures second
  * https://github.com/elastic/ingest-dev/issues/491
  * https://github.com/elastic/ingest-dev/issues/469

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

* [Code]: add ui.enabled flag and fix uneccessary usage of enabled flag (#38018)

* Make plugins/reporting config snapshot deterministic (#38019)

* [Canvas] Fixes broken elements in web logs sample data workpad (#37931)

* Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element

* Removed return characters at the beginning of expressions

* Fixing isMigrated bug, when migrations failed we incorrectly ignored it. (#37674)

Prior to this change, when migrations failed (for example when a
.kibana_1 index already exists and no alias does) the awaitMigration
promise would resolve incorrectly. This allowed subsequent plugins,
including Spaces, to proceed using the SavedObjectsClient/Repository
to create documents. This commonly caused a .kibana index to be created,
which would then block the creation of a .kibana alias, and everything
would grind to a halt.

* [Code] update percentage (#38003)

* [Code] Filter out binary files for indexer (#37945)

* Fix bad type import from interpreter. (#37741)

* [Code] use empty placeholder when search filters returns empty results (#38006)

* Optimized content to be more vertical for resizing consistancy (#37120)

* Optimized content to be more vertical for resizing consistancy

* Fixed snapshots

* Feedback changes

* Update _summary_status.scss

* Fixed column order for testing

* [Code] fix hover in monaco-editor 0.17 (#37964)

* [Code]: Use more robust way to handle url (#38060)

* [Code] fix url and encoding for java langserver on Windows (#38064)

* fix(code/frontend): catch structure generating error in saga (#37957)

* Add error handling to expression runner (#37968)

* fix(code/frontend): improve regexp that matches the container of a symbol (#37856)

* fix(code/frontend): should not polling status if import repo not succeed (#37955)

* [apm] update index pattern (#37866)

related to https://github.com/elastic/apm-server/pull/2239

* [ML] Fixes loading of Single Metric Viewer if partition field is text (#37975)

* [ML] Fixes loading of Single Metric Viewer if partition field is text

* [ML] Fix failing test and edit translations for cardinality check

* [ML] Edits to fields_service.js following review

* Fix export saved objects API docs (#37991)

* Update import saved objects API docs to use curl examples (#37997)

* Remove copy as curl

* Update import docs to use curl examples

* Remove deprecated feature from elasticsearch queries. (#37995)

* [Uptime] [Bug] Disable integration links for apps that are not present (#37284)

* Add tests and checks for disabled/enabled integration link.

* Add empty state if all integrations are unavailable.

* Fix broken type.

* [ML] Fix for constant polling of deleting job tasks (#38013)

* [ML] Fix for constant polling of deleting job tasks

* fixing comment

* Fix URLs from displaying too long in saved objects management UI (#37987)

* Fix URLs from displaying too long

* Add encodeURIComponent

* Updating mixin-deep to 1.3.1 (#38057)

* Relative cache loader (#36131)

* chore(NA): first efforts to enable cache-loader relative paths and disable babel-register cache. chore(NA): allow to use cache-loader results everywhere as a persistent cache.

* chore(NA): last change to support cache loader across envs.

* fix(NA): cache-loader config generator function scope.

* refact(NA): static cache config for dll compiler.

* chore(NA): support for force writable cache flag. use built assets for cache on distributable.

* chore(NA): update cache-loader to last version. fix(NA): logic bug with force writable cache flag.

* chore(NA): move optimize cache to built_assets.

* chore(NA): relative paths for sourcemap configurations.

* chore(NA): remove redudant check for process.env var.

* refact(NA): simplify double negated expression.

* chore(NA): remove webpack prefix from devtoolModuleFilenameTemplate.

* chore(NA): rename cache write force flag to KBN_CACHE_LOADER_WRITABLE.

* chore(NA): readd babel register cache.

* chore(NA): change .cache to .ui_bundles_cache

* chore(NA): change .ui_bundles_cache to cache/ui_bundles

* chore(NA): update gitignore with .babel_register_cache.json

* chore(NA): rollback devtool module filename template to asbolute resource path.

* chore(NA): apply cache-loader patch.

* [Canvas] Interpreter type conversion (#37300)

* Move Expression types to OSS.

* Add interfaces for KibanaContext and KibanaDatatable types.

* Convert esaggs expression function to TypeScript.

* Clean up KibanaDatatable and KibanaContext types.

* Convert functions to use new Interpreter types

* Update ArgumentString-related types to simply be TypeString.

* Rename types.ts to index.ts so types can be imported at the top level.

* Update ArgumentString-related types to simply be TypeString.

* Rename types.ts to index.ts so types can be imported at the top level.

* Remove unused code from arguments types.

* Convert x-pack imports of OSS plugins from relative to absolute.

* Fix esaggs import.

* Addressing self feedback

* default shape aspect ratio to false (#38030)

* functional tests/firefox wait for loading after page refresh (#38082)

* Use production EMS manifest (#38050)

* [TSVB] [AT] implement new test cases for time series formatter (#37506)

* implement new test cases for time series formatter

* Remove "common" options from SDP that have a 0ms difference between end and start time. (#37395)

* Fix broken filtering on metric visualizations. (#38029)

* Allow headers config to propagate in `callAsCurrentUser` (#34610)

* add telemetry query source when hitting monitoring indexes

* allow headers to pass through

* Update src/core/server/elasticsearch/scoped_cluster_client.ts

* fixes from bill code review

* split test cases

* fix functional test

* check if issue from intersect function

* more debug

* check for duplicate values instead

* code review updates

* remove mockClear

* [Maps] replace FormattedText with FormattedMessage (#38016)

* [Maps] replace FormattedText with FormattedMessage

* fix Capitalization

* Move shimming of workpad CSS to only happen on fetch (#38117)

* Fix discover not using an index pattern when 2 are created (#38053)

* [Code]: unassociate html with typescript langserver (#38150)

* Skip Index Manamgent API integration tests that are inapplicable to Cloud, when they are run on Cloud. (#38045)

* Updating stringstream to 0.0.6 (#38155)

* ui settings mocks: mock observables' return values. (#37584)

* [new-platform] Simplify the frontend integration with the legacy platform (#37734)

* KQL in TSVB (#36784)

* Squashed commit of the following:

commit 0cff8243a99ff23421c3cbb15d62b26332a31e21
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Mon May 20 16:16:15 2019 -0700

    Adds ignore_lobal_filter YesNo component back

    Deletes fixtures file

commit e54e1690c9c46e2de5e747d14030a7e27e74c138
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Mon May 20 14:39:21 2019 -0700

    squash-merges adding KQL with the full QueryBar and SavedObject migrations

Debugging

Adds filter defaults

Updates index pattern for the QueryBar on componentDidUpdate

squash-merges adding KQL with the full QueryBar and SavedObject migrations required

Adds ignore_lobal_filter YesNo component back

Deletes fixtures file

Updates migration test number

* Changes QueryBar to QueryBarInput in TimeseriesPanelConfigUi

Replaces QueryBar with QueryBarInput in Timeseries

Changes QueryBar to QueryBarInput in TSVB Metric

Changes QueryBar to QueryBarInput in other TSVB visualisation editors

Removes async from componentWillMount

changes indexPattern to indexPatternObject in series and table query request processors

* Squashed commit of the following:

commit 2c3107963cff20b2d24323fddfaf80c848b86848
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 15:15:06 2019 -0700

    Cleans up comments

commit 943150d4b9b71183e9d5b26c95449ea4519aad4c
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 14:09:53 2019 -0700

    Cleans up parser check more

commit d31de88525595720556440ae71515f5772774eaa
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 14:01:02 2019 -0700

    Cleans up parser check

commit b592071b1d939ec2df9b9c921d57a22dac54e703
Author: Christiane Heiligers <christiane.heiligers@elastic.co>
Date:   Thu May 23 13:16:55 2019 -0700

    skips server call on invalid kuery queries

Cleans up

Deletes duplicate migration function

Adds 's' to split_by_filters method

Resolves issues after rebase

* Removes quotes around index pattern strings passed into fetch_index_patterns, adds comments on reasoning

* queryBar to queryBarInput

Adds transformFilterStringToQueryObject back to visualizations migrations that was lost during rebase

* Deletes unused code

* Fixes migrations test

* compiles visualizations migrations for version 7.3.0

* temporary change to query_bar_input fetch_index_patterns file

formatting

Includes code from PR#37413

Clean up

* Formatting

* Uses series index pattern when override_index_pattern is selected and an index pattern is provided

* Removes empty object as alternative to localStorage

* Removes handelQueryChange from where it is not needed

* extracts retrieval of the default query language from uiSettings into a helper method

* Resolves some PR comments

* Handles Query Error from an invalid syntax query

* Converts string queries into objects with kuery as the language in saved_objects data for ecommerce, flights and logs TSVB visualizations

* Deletes unused translation items

* Adds optional id prop to the query_bar_input and makes the screenTitle optional

* Updates [eCommerce] Sold Products per Day

* Removes screenTitle from component QueryBarInput

* Wraps index pattern strings in a double quote to allow for names such as 'logstash-*'

* [Code] search functional test to cover file typeahead query case insensitive (#38012)

* [Code] Improve the document search highlights for non-english query (#38154)

* Fix i18n issues (#38169)

* [SIEM] Beta badge on overview page (#38161)

* add beta badge to overview header

* update test

* updates snapshot

* Fix sample data functional test (#38184)

* [Code] fix another path problem on windows (#38072)

* [SIEM] Additional Overview Network & Hosts metrics (#38005)

[SIEM] Additional Overview Network & Hosts metrics (#38005)

* chore(NA): declare kbn-babel-preset as peer dependency for kbn plugin helpers. (#37710)

* [Canvas] Localize Function Errors (#37381)

* [Canvas] Localize Function Errors

* Update test

* Fix enum usage

* [Code] improve setup guide (#38218)

* [SIEM] Changes out event.severity for message in timeline and fixes sorting bug (#38158)

## Summary

  * Change out event.severity for message in timeline
  * Fixed critical crash where you should not be able to sort on timeline columns that are not aggregatable
  * https://github.com/elastic/ingest-dev/issues/513
  * https://github.com/elastic/ingest-dev/issues/496

Error toaster fixes:
<img width="348" alt="Screen Shot 2019-06-05 at 1 59 01 PM" src="https://user-images.githubusercontent.com/1151048/58986428-97065a00-879a-11e9-8ff9-003ac29f6d9e.png">

What the timeline looks like with severity replaced with message:
<img width="883" alt="Screen Shot 2019-06-05 at 1 55 19 PM" src="https://user-images.githubusercontent.com/1151048/58986459-a71e3980-879a-11e9-8144-f16f055bd53d.png">

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

* [SIEM] Removing draggability from message field (#38166)

## Summary

Currently, searching the `message` field within Timeline will not function properly, so in effort to prevent the user from searching with it, this PR removes the areas where `message` is draggable, which includes:

* Host Events Table
* Host Details Events Table
* Timeline Renderers
* Timeline Event Details

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

* ## [SIEM] Disables Timeline Provider Mutations While Loading Data (#38185)

## Summary

* Fix: disables dropping a new data provider provider on the timeline, deleting an existing data provider, or choosing an action from the data provider context menu while the timeline is loading data to prevent draggable errors, like the one pictured in the screenshot below:

![draggable-error](https://user-images.githubusercontent.com/4459398/58996789-ebb7ce00-87b6-11e9-9490-47a0df6f89ab.png)

* Fix: the timeline settings icon appears too close to the `Refresh` button:
### Before (Chrome)

![timeline-gear-before](https://user-images.githubusercontent.com/4459398/58997030-e6a74e80-87b7-11e9-86df-cb67592e63a7.png)

### After (Chrome)

<img width="1679" alt="timeline-gear-after-chrome" src="https://user-images.githubusercontent.com/4459398/58997064-1ce4ce00-87b8-11e9-9ffb-0f412e0018ad.png">

### After (Firefox)

<img width="1672" alt="timeline-gear-after-firefox" src="https://user-images.githubusercontent.com/4459398/58997113-4f8ec680-87b8-11e9-9b52-dc8a13d51361.png">

### After (Safari)

<img width="1680" alt="timeline-gear-after-safari" src="https://user-images.githubusercontent.com/4459398/58997169-911f7180-87b8-11e9-8186-0ff31e41ad53.png">

### After (IE 11)

<img width="1354" alt="timeline-gear-after-ie11" src="https://user-images.githubusercontent.com/4459398/58997306-40f4df00-87b9-11e9-844d-b12c7e16f7cb.png">

* Fix: the `Open Timeline` modal is showing bulk-delete actions

### Before (Chrome)

![open-timeline-before](https://user-images.githubusercontent.com/4459398/58997349-700b5080-87b9-11e9-8299-7dbeccbd8ff9.png)

### After (Chrome)

<img width="1008" alt="open-timeline-after" src="https://user-images.githubusercontent.com/4459398/58997381-9af5a480-87b9-11e9-9909-2d68bd5ff2c3.png">

* Fix: action icons on the `Timelines` page and `Open Timelines` modal are not aligned with the counts

### Before (Chrome)

<img width="1552" alt="all-timelines-before" src="https://user-images.githubusercontent.com/4459398/58997554-659d8680-87ba-11e9-868c-d92ad72f44b8.png">

### After (Chrome)

<img width="1550" alt="all-timelines-after" src="https://user-images.githubusercontent.com/4459398/58997656-d8a6fd00-87ba-11e9-9038-c0ca464f8c4d.png">

* Fix: Changed the title text of the fields browser from `Select Fields` to `Customize Columns`

### Before (Chrome)

<img width="910" alt="fields-browser-before" src="https://user-images.githubusercontent.com/4459398/58997616-a4334100-87ba-11e9-9cd8-02ed9d265bf2.png">

### After (Chrome)

<img width="910" alt="fields-browser-after" src="https://user-images.githubusercontent.com/4459398/58997691-fa07e900-87ba-11e9-8cd9-6412d2cef8f0.png">

https://github.com/elastic/ingest-dev/issues/471

* [APM] Moves the APM index creation from server startup (#37965)

* [APM] Closes #37499 by moving the APM index creation from server startup
to savedObject request for the index pattern. It first checks if the
index pattern is saved, if not it creates it.

* [APM] provide more meaninful status codes in the default error handler

* [Core] Rewrite saved objects in typescript (#36829)

* Convert simple files to TS

* Fix jest tests

* Rename saved_objects_client{.js => .ts}

* WIP saved_objects_client

* saved_objects repository{.js => .ts}

* includedFields support string[] for type paramater

* Repository/saved_objects_client -> TS

* Fix tests and dependencies

* Fix saved objects type errors and simplify

* saved_objects/index saved_objects/service/index -> ts

* Fix saved objects export test after switching to typed mock

* Workaround type error

* Revert "Workaround type error"

This reverts commit de3252267eb2e6bf56a5584d271b55a7afdc1c53.

* Correctly type Server.savedObjects.SaveObjectsClient constructor

* saved_objects/service/lib/index.{js -> ts}

* saved_objects/service/lib/scoped_client_provider{js -> ts}

* Typescriptify scoped_client_provider

* Fix x-pack jest imports

* Add lodash/internal/toPath typings to xpath

* Introduce SavedObjectsClientContract

We need a way to specify that injected dependencies should adhere to the
SavedObjectsClient "contract". We can't use the SavedObjectsClient class
itself since it contains the private _repository property which in TS is
included in the type signature of a class.

* Cleanup and simplify types

* Fix repository#delete should return {}

* Add SavedObjects repository test for uncovered bug

Test for a bug in our previous js implementation that can lead to data
corruption and data loss.

If a bulkGet request is made where one of the objects to fetch is of a type
that isn't allowed, the returned result will include documents which have the
incorrect id and type assigned. E.g. the data of an object with id '1' is
returned with id '2'. Saving '2' will incorrectly override it's data with that
of the data of object '1'.

* SavedObject.updated_at: string and unify saved_object / serializer types

* Cleanup

* Address code review feedback

* Don't mock errors helpers in SavedObjectsClient Mock

* Address CR feedback

* CR Feedback #2

* Add kibana-platform as code owners of Saved Objects

* Better typings for SavedObjectsClient.errors

* Use unknown as default for generic type request paramater

* Bump @types/elasticsearch

* Fix types for isForbiddenError

* Bump x-pack @types/elasticsearch

* fix math (#38132)

* fix math

* add unit test

* review I

* Typescript dashboard app code. (#37527)

* Typescript dashboard app code. Pulls out part of the massive embeddable API PR.

I typscripted this code as part of that PR because it helped me find errors, but really unnecessarily blew up the size of that PR. So pulling out.

* User filter types from kbn-es-query

* Address code review feedback

* Replace require with import

* Route tags (#37344)

* expose route info in KibanaRequest

* update mocks in test

* make tags readonly, getRouteInfo is private method

* add mocks for hapi internals

* mode deepFreeze to core utils level as it env agnostic

* freeze route props

* fix typo

* add tests for route options

* fix integration tests. deep_freeze was moved under core utils

* add comments, expose public types and regenerate docs

* address comment. remove unnecessary async in route handlers

* make routeSchema optional instead of union with undefined

* @skaapgif improvements

* update docs

* [ML] Close job after forecast errors if starting from closed (#38253)

* [ML] Close job after forecast errors if starting from closed

* [ML] Pass closeJob flag to error handler if forecast ID undefined

* [ML] Only add ML links for sample data sets if full license (#38120)

* [ML] Only add ML links for sample data sets if full license

* [ML] Update following review

* [docs][skip ci] Read only access for @elastic/kibana-app applications  (#35560)

* Adding read-only mode section to Discover

* No more "mode" or "badge" terminology

* Putting newline back

* Adding "Saving" section for visualize

* Adding dashboard read only access section

* Timelion gets read-only documentation

* Adding read only access section to index patterns and advanced settings

* Adding graph read only access section

* revert dragselect version (#38183)

* fix: 🐛 stop showing spinner only on error (#38289)

* [dev/license_checker][dev/npm] reactor, ts-ify, de-grunt (#37807)

* [dev/failed_tests] try to ignore irrelevant failures (#37902)

* [dev/failed_tests] try to ignore irrelevant failures

* fix typo

* Undo setting of $scope.refreshInterval at dashboard (#37175)

* Add test for passing on dashboard url params to timepicker values

* Revert unnecessary setting of $scope.refreshInterval

refreshInterval is set at $scope.model, no need to set it directly at $scope like in discover and vis

* Updating tar to 2.2.2 (#38182)

* Updating underscore.string to 3.3.5 (#38180)

* Updating axios to 0.18.1 (#38179)

* Updating js-yaml to 3.13.1 for more dependencies (#38160)

Renovate recently updated js-yaml in
https://github.com/elastic/kibana/pull/37809. However, a few
indirect dependencies weren't upgraded to use this new version.

* [Infra UI] Fixes #37999 - Reset error when IP address changes to valid entry (#38022)

* [Infra UI] Fixes #37999 - Reset error when IP address changes to something valid

* movnig the setError above try/catch

* [Maps] fix tooltip text overlap and text overflow (#38271)

* [Maps] Use table to display tooltip properties

* Design cleanup

- Added dropshadow
- Cleaned SASS
- Removed unnecessary wrappers around close button and centered it
- Change loading state to be centered
- Fixed z-index so tooltip is on top of controls
- Condensed padding/spacing

* Fix overlays in IE

* revert yarn.lock changes

* [SIEM] fix ipv6 bug and write tests for ip details page (#37528)

fix ipv6 bug and write tests for ip details page

* [Code]: remove hard code node heapsize (#38304)

* [ci] disable firefox tests

* update yarn.lock

* [SIEM] Update links to docs and website (#38313)

* Update links to docs and website in the SIEM app

* Update also link text

* Capitalize solution

* Add link to 7.2 ems landing page (#38284)

* Fixed cyclic dependencies (#38321)

## Summary

Fixes cyclic dependencies

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

* Add language codes in comment (#37635)

It would be good to see a list here, as long as we will add more languages. 
A user will not have to look into any other document to find a language code.
That will be more easier for any one who configure this file.

* [jest] don't be crazy, run with caching enabled (#38332)

* [SIEM] Fix overlapping timestamp tooltip in expanded Event Details (#38328)

## Summary

Fixes issue where multiple tooltips are shown on `date` and `duration` fields within the expanded Event Details UI (https://github.com/elastic/ingest-dev/issues/481).

### Before:
<img src="https://user-images.githubusercontent.com/2946766/59068176-b8397a00-8870-11e9-9b04-ee16d89ac7d4.png" width=400>

<img src="https://user-images.githubusercontent.com/2946766/59068283-00f13300-8871-11e9-989d-986e9ae00e2a.png" width=400>


### After:
<img src="https://user-images.githubusercontent.com/2946766/59068223-d901cf80-8870-11e9-9a28-1322adcfe570.png" width=400>

<img src="https://user-images.githubusercontent.com/2946766/59068321-15353000-8871-11e9-8e33-2ffaa0b0c9c2.png" width=400>

<img src="https://user-images.githubusercontent.com/2946766/59068621-d653aa00-8871-11e9-8803-8be01a20e585.png" width=400>



### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

* Fixing crash when collapsing a second event details (#38303)

* [Code] adjust clone progress and not found rendering in source view page (#38213)

* Update dependency history to v4.9.0 (#37799)

* Update dependency history to v4.9.0

* importing submodules is deprecated, import root package

* chore: bump history-extra to 5.0.1

compatible with history@^4.9.0

* re-enable yarn.lock validation checks

* [scripts/update_prs] implement script to merge base branch into prs (#38302)

* re-enable yarn.lock validation checks

* update kbn-pm dist

* Update dependency @microsoft/api-extractor to v7.1.6 (#37760)

* Update dependency @microsoft/api-extractor to v7.1.6

* regenerate docs

* OverlayService: Import react instead of relying on global

* [Maps] ensure labels extracted from WMS capabilities are unique (#38311)

* [Maps] ensure labels extracted from WMS capabilities are unique

* clean up

* clean up

* [Code] change the port number before respawn a new lang-server process (#38090)

* [SIEM] Kpi network enhancement (#36915)

* add histogram

* clean up with hooks

* fix types and inport

* update mock data

* fix barchart

* fix integration test

* wrapping hooks with functional component

* update snapshot

* remove active agents and network events histogram from kpi network

* amend chart height

* fix integration test

* update wording

* add readonly type

* add references

* update translations and add constants

* clean up types for kpi host

* clean up types for kpinetwork

* remove a redundant type

* fix tests

* replace react memo with recompose pure

* add unit test and update mock data

* remove redundant type

* Update webpack related packages (major) (#37552)

* Update webpack related packages

* raw-loader@2 uses esm, so we must import

* Revert "[Code] change the port number before respawn a new lang-server process (#38090)"

This reverts commit 05947fed0c367403fff0f5a6be68682e7bb8bc68.

* Update dependency leaflet to v1.5.1 (#37811)

* Update dependency leaflet to v1.5.1

* update baseline image

* Fix map draw controls

* Update CSS overrides to match updated package

* Update dependency pdfmake to v0.1.56 (#37887)

* Update dependency pegjs to v0.10.0 (#37889)

* Update dependency pegjs to v0.10.0

* PEG.buildParser() => PEG.generate()

* Update dependency pngjs to v3.4.0 (#37890)

* Update dependency @microsoft/api-extractor to v7.1.8 (#38364)

* removing provider (#38221)

* removing provider (#38223)

* update docs how to add typs for config (#38224)

* Session storage refactoring (#37992)

* Kibana request keep a reference to raw request. used to bind hapi-cookie

* CookieSessionStorage should work with KibanaRequest

as soon as registerAuth refactored to restrict access to hapi Request, CookieSessionStorage won't work with hapi request directly

* change registerAuth public api

* adopt auth lifecycle tests

* move lifecycle auth tests from integration to unit and adopt to new api.

* mark toRawRequest as internal to prevent exposure

* generate docs

* reword test cases

* mark Request internals in tsdoc

* Fix broken Vega context menu (#38095)

* Fix broken Vega context menu

* Remove debug output

* Improve code comment

* Convert Markdown components to TS (#38081)

* Convert Markdown components to TS

* Fix jest snapshots

* Fetch options for input control child select boxes (#38148)

* Update dependency geckodriver to v1.16.2 (#37798)

* Update webpack related packages (major) (#38372)

* Update dependency proxyquire to v1.8.0 (#37913)

* Vislib private removal part2 (#37850)

* [Uptime] [Bug] Support KQL "OR" filters (#37564)

* Fix typo in variable name.

* Add support for kql-rendered output from filter bar.

* Support nested status query output.

* Expand complicated mock data.

* Add comments, clean up code.

* Improve naming, comments, simplify function bodies.

* Update dependency nock to v10.0.6 (#37886)

* Document mock convention (#37888)

* add docs how to use config in NP

* do not encourage storing initializer context in plugin

* add mock convention docs

* address comments

* address Josh comments

* disable flaky test

* disable renovate for developer doc generators. (#38239)

* disable renovate for doc generators. we have to regenerate docs on a version update

* use packageNames for static values

* Switch from old error messages to toast notifications (#38116)

* Replace notifier.error by toast notifications

* Fix incomplete mock

* Improve pipeline error title

* Fix typo in failure filtering (#38374)

* include a default value for failure string

* test the failure filtering

* oops, reverted too many changes

* [Infra UI] Fixes Uptime link to display for pod and containers (#38125)

* Fixes uptime link to display for pod and containers

* Making code more readable

* Another round of readability changes

* removing extra truthy check

* [Infra UI] Fixing Metrics Explorer chart title overlapping (#38059)

* [Infra UI] Fixing Metrics Explorer chart title overlapping

* Adding tooltip to title

* remove accidentally committed stats file from repo

* Enable use of KQL and autocomplete in filters agg editor (#37287)

This PR updates the filters agg editor to use the full QueryBar component, enabling use of KQL and autocomplete inside the editor for this aggregation in Visualize.

* Vislib private removal part3 (#37852)

* removing Private

* Fixing padding issues in the toolbar (#38315)

* Cursor on symbol hover. (#38062)

* Reapply custom element telemetry (#37113)

* Revert "Revert "[Canvas] Adds telemetry info for custom elements (#36177)" (#37100)"

This reverts commit 3f4c2c89ecba9aeb6e77b88044b39cd2b371dcbd.

* Cast fromExpression unknown type

* PR Feedback

* [Uptime] [Bug] Fix spaces in filters (#38320)

* Fix typo in variable name.

* Add support for kql-rendered output from filter bar.

* Support nested status query output.

* Expand complicated mock data.

* Add comments, clean up code.

* Improve naming, comments, simplify function bodies.

* Refactor filter selection method to handle arbitrary input that is unrelated to status.

* Embeddable API V2 (#37510)

* Embeddable API plugin

* Expose new embeddableActions uiExport endpoint

* Add missing getInjectedUIAppVars to Server type

* Add jest tests

* Most basic skeleton of the sample plugin to see if it still kills ci

* strip even more out to see if it passes ci

* It passed, put back init fn

* add back in a uiExport to see if that is what is killing ci

* Passed again, add back embeddableActions uiExports and require kibana line

* Add everything back but the sass import

* Found two bugs with customize panel title action, added jest test coverage and fixes

* Functionally test embeddable explorer plugin

* Addressing review feedback part 1

* Simplify action context menu - remove support for nested actions/child panels, which was never exposed anyway.

* More review feedback

* Spread out orders to let developers inject their own actions in the middle.

* Remove check for overwriting ApplyFilterAction

* use createRegistry for EmbeddableFactoryRegistry

* Add comment for getInheritedInput

* Use kbn-es-query Filter types

* Fix missed file after createRegistry switch over for EmbeddableFactoryRegistry

* Use delete instead of setting to undefined

* upgrade EUI to match kibana version

* Add getIsContainer on base embeddable class

* Run functional tests of sample plugin

* move all tests classes outside __test__ and inside test_samples folder so not to potentially create issues with mocha

* fix: 🐛 remove unused imports

* fix: 🐛 set to undefined explicitly

* chore: refactored getRoot functionality

* fix: refactor miss from folder rename __test__ -> test_samples

* fix: add eui switch to let the user indicate “hide this title” to improve ux.

* fix: customize panel flout test

* Try to fix issue with multiple rxjs bundles I hit before.

See https://github.com/ReactiveX/rxjs/issues/3828

* Use an rxjs polyfill to work around the issue of multiple rxjs bundles

* chore: change customize panel flyout to modal post design feedback

* capitalize Reset

* fix: type errors in customize panel modal

* fix: remove extra line added to prevent EUICallout overflow from spilling over panel edges

The bug this was intended to fix doesn’t appear yet because dashboard isn’t using this, and it causes other issues, so for now, just remove.

* Clean up some classes and SASS

* Inline styles needed to get the containers to take up the full height of the app.

* Use the same old style of error messaging in panels

* chore: add untilEmbeddableLoaded tests, expose on interface, and use in embeddable_child_panel

* Remove unused styles, add padding

* Verify trigger Context containers an array of Filters for apply filter action

* Remove panel.embeddableId param, use panel.explicitInput.id instead

* Check `isCompatible` as well as the type guard needed for typescript.

* executeTriggerActions should account for getHref

* Remove unnecessary check for context being defined

* use npStart instead of getNewPlatform

* Conform to latest NP changes

* Use new np_mocks in all the tests

* Address review feedback on rxjs polyfill

* Updating chownr to 1.1.1 (#38177)

* [DOCS] Adds docs for snapshot repositories UI (#38159)

* [DOCS] Adds docs for snapshot repositories UI

* [DOCS] Incorporates review comments into snapshot docs

* Update dependency apollo-cache-inmemory to v1.6.2 (#38435)

* Update dependency puid to v1.0.7 (#38436)

* Update dependency regression to v2.0.1 (#38437)

* Update dependency rimraf to v2.6.3 (#38438)

* [Code] better limit the size of indexed files (#38327)

* [Code] better limit the size of indexed files

* [Code] separate the batch index helper for document and symbols

* Security - remove usage of legacy notifier (#38260)

* remove usage of legacy notifier

* fix superfluous whitespace changes

* fix redirection on role management screen

* extract session expiration warning into its own component

* Issue 28875:  Using i18n instead of injectI18n (#37845)

* Using i18n instead of injectI18n

* Update x-pack/plugins/monitoring/public/components/apm/instance/status.js

Co-Authored-By: Ahmad Bamieh <ahmadbamieh@gmail.com>

* Update x-pack/plugins/monitoring/public/components/table/table.js

Co-Authored-By: Maryia Lapata <mary.lopato@gmail.com>

* Addressed PR code review feedback

* Issue 27126: Added a link to License Management (#37771)

* Added a link to License Management

* Added textAlign to EuiText instead

* Implement renovate config generator (#38369)

* reformat renovate.json5 with json5 cli, add header

* add scripts for rengerating renovate config from ts files

* regenerate renovate config

* verify renovate.json5 is up to date in CI

* add description to the build_renovate_config script

* auto-group types packages

* fix typo

* mention version pinning in doc block

* support disabling renovate for package groups

* scan all package paths for @-types deps

* regenerate renovate config

* regenerate renovate config

* name scoped package regexp

* move some of the new logic out of package_groups.ts

* flatMap in one pass

* [SIEM] Add build step to find cyclic deps in SIEM project (#38329)

## Summary

* Adds a build step to find cyclic deps and error out in the SIEM project when found as part of a build step.

* Fixes typescript files that have cycles with their constants and types.

You run this like so:

```
cd kibana/x-pack/plugins/siem
node scripts/check_circular_deps.js
```

And get this message:
<img width="846" alt="Screen Shot 2019-06-07 at 11 22 24 AM" src="https://user-images.githubusercontent.com/1151048/59121970-b629f680-8916-11e9-8683-326a881c4725.png">

Or you will get an error with a listing of deps that need to be updated which have cycles in them.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

* Update dependency simple-git to v1.113.0 (#38456)

* Update dependency rsync to v0.6.1 (#38454)

* [Canvas] Clean up expression function definitions (#37305)

* Cleaned up common function defs

    fixed broken tests

    Remove boolean and null as context/arg valid types in lt, lte, gt, and gte

    Added 'function' alias

    Updated comparator tests

    Added neq to options in compare function

    null audit

* Deleted obsolete 'browser' and 'server' functions

* More clean up

* Removed server and browser function i18n strings

* Fixed broken tests

* Addressing feedback

* Removed browser and server from function_help

* Added ts-ignore for constant import

* Fixed help text label

* Fixed font

* [Infra UI] Link to node detail page from Metrics Explorer (#37136)

* [Infra UI] Link to Metrics Detail page from Metrics Explorer for compatible group bys

* Adding test for incompatible group bys

* renaming for clearity

* Changing out SourceQuery for SourceConfiguration

* Fixing tests to ensure link it validated

* Make tests more robust

* Update x-pack/plugins/infra/public/components/metrics_explorer/chart_context_menu.tsx

Co-Authored-By: Felix Stürmer <weltenwort@users.noreply.github.com>

* Adding definite assingment operattors

* Fixing flaky test

* disable flaky tests

* [build][quick-fix] don't clean eui (#38483)

* [Canvas][Easy] Fix EUI Issue in Storybook; standardize locations (#38222)

* Fix Storybook

* Organizing folders a bit

* Update snapshots

* [Code] change the port number before respawn a new lang-server process (#38090) (#38375)

* Use actual listing limit in vis listing (#38246)

* Vislib private removal part4 (#37857)

* removing Private

* disable failing test (#38492)

* Remove unused injected dependencies 3b (#36899)

* removing more unused injected dependencies

* remove unused injected dependencies (#38504)

* remove unused injected dependencies (3rd in a series) (#37947)

* remove unused injected dependencies

* Remove Private usage from XPackInfoSignatureProvider (#38507)

* remove Private usage, remove mock session storage usage

* [Code] fix Code multinode mode can't work when security is enabled (#37597)

* fix(code/frontend): remove load project configs (#38264)

* fix(code/frontend): should not have empty array as query (#38257)

* Fix typo in top hit fields filter (#38391)

* [ML] Adds check that forecast duration is no more than 3650 days (#38408)

* [Accessibility] Reload saved search link on Discover replaced with <EuiButton> component (#37621)

* Reload saved search link replaced with <EuiButton> components: keyboard accessible and looks like a button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:KQL KQL release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.3.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants