Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Group by Terms functionality not working propertly #39580

Closed
alexwizp opened this issue Jun 25, 2019 · 4 comments · Fixed by #39723
Closed

[TSVB] Group by Terms functionality not working propertly #39580

alexwizp opened this issue Jun 25, 2019 · 4 comments · Fixed by #39723
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) regression Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.3.0 v8.0.0

Comments

@alexwizp
Copy link
Contributor

alexwizp commented Jun 25, 2019

Regression of #36784

Kibana version:
master branch

Steps to reproduce:

  1. Create new TSVB visualization or open existing one (index pattern should be empty)
  2. Set 'Terms' value for Group By combobox
  3. Try to expand 'By' combobox

Expected behavior:
'By' combobox should allow us select fields related to the default index pattern.

Current behavior:
Combobox is empty
image

Root cause:
image

@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) regression Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@alexwizp alexwizp added bug Fixes for quality problems that affect the customer experience v7.3.0 v8.0.0 labels Jun 25, 2019
@TinaHeiligers
Copy link
Contributor

@alexwizp, if using the default_index_pattern in the render method is a problem, what index pattern should we be using, if any at all? i.e., should we be using:
const indexPattern = (model.override_index_pattern && model.series_index_pattern) || panel.index_pattern only?

@alexwizp
Copy link
Contributor Author

I think we should use value of the 'default index pattern' only for one case, it's a showing this value in a placeholder for 'Index Pattern' input. In other cases we should work with empty string value.

@TinaHeiligers
Copy link
Contributor

@alexwizp: The bug is fixed in PR 39723.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) regression Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.3.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants