[siem/ui] avoid importing server code in ui #37103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/secops |
spalger
added
the
release_note:skip
mistic
approved these changes
May 24, 2019
💚 Build Succeeded |
This was referenced May 24, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 24, 2019
* [siem/ui] avoid importing server code in ui * covert a couple extra imports
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 24, 2019
* [siem/ui] avoid importing server code in ui * covert a couple extra imports
spalger
pushed a commit
that referenced
this pull request
May 24, 2019
spalger
pushed a commit
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37016
We have an issue in IE11 caused by server code being imported into the UI unnecessarily. The culprit seems to the the siem app which is importing the index file from the plugin, which causes all of the server code including Hapi to be imported into the UI. To avoid this we need to make sure and put data that should be imported from both the server and UI into
commondirectories and be careful when importing from the UI to not include more than necessary.We have ideas for how we can evolve our tooling to make this mistake harder to make, but for now it's just an unfortunate reality that it's a pretty easy mistake to make.
Major thanks to @mistic for tracking down the imports of the index.ts file in the UI!!