Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SIEM] Fixes timeline notes overflowing the modal (#37134) #37244

Merged
merged 2 commits into from
May 28, 2019

Commits on May 28, 2019

  1. [SIEM] Fixes timeline notes overflowing the modal (elastic#37134)

    ## [SIEM] Fixes timeline notes overflowing the modal (elastic#37134)
    
    Beginning in Chrome 74 (see elastic/eui#1902), the timeline notes modal can overflow in some browsers, per the _Before_ gif below.
    
    This fix uses `EuiModal` and other `EUI` components to address the overflow issue across all the browsers tested in the gifs below:
    
    ### Before (Chrome `74.0`)
    
    ![01-before-chrome](https://user-images.githubusercontent.com/4459398/58355997-4d7d4d00-7e33-11e9-864b-7e77d0635116.gif)
    
    ### After (Chrome `74.0`)
    
    ![02-after-chrome-74 0](https://user-images.githubusercontent.com/4459398/58356028-6128b380-7e33-11e9-8c7d-3022e45b1f41.gif)
    
    ### After (Firefox `67.0`)
    
    ![03-after-firefox-67 0](https://user-images.githubusercontent.com/4459398/58356056-6ede3900-7e33-11e9-92ca-a6dd8e0b804b.gif)
    
    ### After (Safari `12.1.1`)
    
    ![04-after-safari-12 1 1](https://user-images.githubusercontent.com/4459398/58356123-a947d600-7e33-11e9-80ab-d6b3d3c601c0.gif)
    
    ### After (IE`11.0.9600`)
    
    ![05-after-ie-11](https://user-images.githubusercontent.com/4459398/58356131-aea52080-7e33-11e9-989e-51aab7c4e9da.gif)
    
    https://github.com/elastic/ingest-dev/issues/442
    andrew-goldstein committed May 28, 2019
    Configuration menu
    Copy the full SHA
    1ada4b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d70c98 View commit details
    Browse the repository at this point in the history