Support for date_nanos type timestamps in context view #38023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
force-pushed
the
pr-31424-date_nanos-context
branch
from
d90fc25
to
ffb3345
Compare
kertal
changed the title
- too much shared code
- merge fetchPredecessorRows & fetchSuccessorRows - new function fetchSurroundingRows - less code duplication
kertal
force-pushed
the
pr-31424-date_nanos-context
branch
from
d7cd763
to
a1e5d10
Compare
💚 Build Succeeded |
kertal
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
|
I'm currently improving code, moving to typescript, but I think it's wiser to review that in a different PR. So this PR is focused on fixing the rounding issue of |
kertal
commented
Jun 7, 2019
flash1293
reviewed
Jun 11, 2019
flash1293
reviewed
Jun 11, 2019
src/legacy/core_plugins/kibana/public/context/api/__tests__/successors.js
Outdated
Show resolved
Hide resolved
flash1293
approved these changes
Jun 11, 2019
thank you so much for reviewing, I'll continue then finishing the typescript version, which will be a separate PR |
Now using the the right iso timestamp in every test case
Now using the right ISO timestamp in every test case
💔 Build Failed |
💚 Build Succeeded |
This was referenced Jun 11, 2019
💚 Build Succeeded |
|
Note: this wasn't backported, what was backported was #38735, the typescript converted version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide ES
date_nanossupport in context view. This is part of #31424.In #36111 date_nanos support was implemented, but the context view was disabled, due to issues with rounded sort values.
Testing
You can provision date_nanos data by:
Or you can convert demo test data to date nanos with the following instruction:
#36111 (comment)
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately