Date nanos context typescript conversion #38735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- too much shared code
- merge fetchPredecessorRows & fetchSuccessorRows - new function fetchSurroundingRows - less code duplication
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
kertal
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
kertal
added
release_note:skip
…_nanos-context-typescript
💚 Build Succeeded |
flash1293
approved these changes
Jun 14, 2019
|
I've got no idea, why suddenly there's a request by Kibana-Design necessary?? |
|
@kertal Because you changed https://github.com/elastic/kibana/pull/38735/files#diff-6a10bcd18378ed330fcf2b897d13493eL138 - every change in scss files triggers this review |
kertal
force-pushed
the
pr-31424-date_nanos-context-typescript
branch
from
25f47a3
to
8971b9c
Compare
|
@flash1293 thx, already found and fixed it, commit didn't belong here |
💚 Build Succeeded |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jun 17, 2019
kertal
added a commit
that referenced
this pull request
Jun 17, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert parts of the discover context view to TypeScript, Follow up of #38023
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately