Corrects index pattern for fields in split_by_terms #39723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
release_note:fix
Feature:TSVB
💔 Build Failed |
|
Jenkins, please test this |
💚 Build Succeeded |
alexwizp
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
…rms_by_functionality
💔 Build Failed |
|
Jenkins test this please |
|
Jenkins test |
|
Jenkins, please test this |
|
retest |
…rms_by_functionality
💔 Build Failed |
|
retest |
|
@alexwizp CI was giving endless trouble, I'm trying to get these tests to pass (the only changes were linting problems in files I didn't even touch!). |
💔 Build Failed |
|
Retest |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39580
This PR is a fix for a bug in TSVB where the fields were not showing up in a TSVB split_by_terms aggregation. The bug was a result of not using the correct index pattern to extract the fields that can be selected as an option to split by.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately