[Reporting/Logging] truncate base64 urls in logs #41304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:enhancement
review
(Deprecated) Feature:Reporting
kobelb
approved these changes
Jul 16, 2019
💚 Build Succeeded |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jul 17, 2019
tsullivan
added a commit
that referenced
this pull request
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Helping folks diagnose Reporting for Canvas came with a headache of looking at logs: Canvas images are added by the user as uploads, and those images are represented as base64 in the browser. The Reporting verbose logger logs every request made as a result of loading a page, and the log is containing long strings of text that slow down the process of copying, pasting and finding things in the log text.
Closes #41297
Result:
Release note:
Added an enhancement that truncates long
data:URLs in Kibana Reporting's verbose logs.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibility