Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Logs UI] Make column configurations reorderable (#41035) #41697

Merged
merged 1 commit into from
Jul 23, 2019
Merged

[7.x] [Logs UI] Make column configurations reorderable (#41035) #41697

merged 1 commit into from
Jul 23, 2019

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jul 22, 2019

Backports the following commits to 7.x:

@Zacqary
[Logs UI] Make column configurations reorderable (elastic#41035)
cc762df 
* [Logs UI] Make column configurations reorderable

* Improve typing aand memoize callback

* Guard against index bounds and rename reorderLogColumns

* Fix useCallback memoization

* Add functional test for reordering log columns

* Use browser.keys instead of Key in functional test
@elasticmachine
Copy link
Contributor

💔 Build Failed

@Zacqary
Copy link
Contributor Author

Zacqary commented Jul 22, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Zacqary Zacqary merged commit 2f31e58 into elastic:7.x Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zacqary @elasticmachine