[APM] Remove dependency on ui/chrome in favor of newer core APIs #41868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogupte
added
the
release_note:skip
💔 Build Failed |
sorenlouv
reviewed
Jul 24, 2019
|
|
||
| const CoreContext = createContext<InternalCoreStart>({} as InternalCoreStart); | ||
| const CoreProvider: React.SFC<{ core: InternalCoreStart }> = props => { | ||
| const { core, ...restProps } = props; |
There was a problem hiding this comment.
I think we should omit ...restProps until we need.
There was a problem hiding this comment.
Oh, it's used for children? Maybe make that explicit?
sorenlouv
reviewed
Jul 24, 2019
| @@ -6,9 +6,9 @@ | |||
|
|
|||
| import { npStart } from 'ui/new_platform'; | |||
There was a problem hiding this comment.
the hack pattern will go away eventually, but the npStart import is valid until we get to that point. This is how legacy plugins import the new platform core at the top-level.
sorenlouv
reviewed
Jul 24, 2019
| import { CoreProvider } from './context/CoreContext'; | ||
|
|
||
| const { core } = npStart; | ||
| // console.log(npStart); |
ogupte
force-pushed
the
apm-34444-new-platform-migration-ui-chrome-di
branch
from
6f4bf36
to
dccb5cf
Compare
💔 Build Failed |
|
retest |
💚 Build Succeeded |
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jul 25, 2019
…stic#41868) * [APM] Remove dependency on ui/chrome in favor of newer core APIs * [APM] fix broken tests by mocking useCore hook
ogupte
added a commit
that referenced
this pull request
Jul 25, 2019
) (#41947) * [APM] Remove dependency on ui/chrome in favor of newer core APIs * [APM] fix broken tests by mocking useCore hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34444
Created
useCore/CoreContextto pass down a single instance ofcoreto components which were previously usingui/chrome. Those components were updated to usecoreAPIs instead ofui/chrome.