Migrate legacy sort arrays on saved searches #43038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bargs
added
Team:Visualizations
|
Pinging @elastic/kibana-app |
💔 Build Failed |
Bargs
commented
Aug 9, 2019
| @@ -29,24 +29,25 @@ function createSortObject(sortPair, indexPattern) { | |||
| const [ field, direction ] = sortPair; | |||
| return { [field]: direction }; | |||
| } | |||
| else if (_.isPlainObject(sortPair) && isSortable(Object.keys(sortPair)[0], indexPattern)) { | |||
There was a problem hiding this comment.
I noticed a bug where getSort.array was being used with an Elasticsearch formatted sort object but we weren't actually handling that in the getSort code. So I updated this method to handle that case and added tests to make it more clear what all getSort.array is expected to do.
💔 Build Failed |
💚 Build Succeeded |
bmcconaghy
reviewed
Aug 12, 2019
There was a problem hiding this comment.
This looks good. Unless I'm missing something, if someone fires up 7.4.0 and then uses one of the add sample data wizards, they will wind up with a saved search that has a sort that is only a 1 dimensional array. We should probably fix those as part of this PR too.
|
@bmcconaghy that should already be fixed, I updated the sample data files: https://github.com/elastic/kibana/pull/43038/files#diff-23e156bef21eddb8b1b0ea745bea791a Is there one I missed? |
|
@Bargs nope I just missed your changes. |
💚 Build Succeeded |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 13, 2019
With my multi sort PR I changed the sort property on saved searches to contain a nested array. Discover and Dashboard were backwards compatible with the old format but it turns out the nested array caused issues for CSV export. Instead of trying to support single and two dimension arrays everywhere, this PR simply adds a migration for saved searches in 7.4 and updates our sample data sets so that we can always expect sort objects to be two dimensional arrays. I also cleaned up the backwards compatibility code in Discover and Dashboard.
This was referenced Aug 14, 2019
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Aug 15, 2019
With my multi sort PR I changed the sort property on saved searches to contain a nested array. Discover and Dashboard were backwards compatible with the old format but it turns out the nested array caused issues for CSV export. Instead of trying to support single and two dimension arrays everywhere, this PR simply adds a migration for saved searches in 7.4 and updates our sample data sets so that we can always expect sort objects to be two dimensional arrays. I also cleaned up the backwards compatibility code in Discover and Dashboard.
Bargs
added a commit
that referenced
this pull request
Aug 15, 2019
With my multi sort PR I changed the sort property on saved searches to contain a nested array. Discover and Dashboard were backwards compatible with the old format but it turns out the nested array caused issues for CSV export. Instead of trying to support single and two dimension arrays everywhere, this PR simply adds a migration for saved searches in 7.4 and updates our sample data sets so that we can always expect sort objects to be two dimensional arrays. I also cleaned up the backwards compatibility code in Discover and Dashboard.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42982
With my multi sort PR I changed the sort property on saved searches to contain a nested array. Discover and Dashboard were backwards compatible with the old format but it turns out the nested array caused issues for CSV export. Instead of trying to support single and two dimension arrays everywhere, this PR simply adds a migration for saved searches in 7.4 and updates our sample data sets so that we can always expect sort objects to be two dimensional arrays. I also cleaned up the backwards compatibility code in Discover and Dashboard.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately