[Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable #44359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove handling of nssError$, fontError$, noUsableSandbox$
tsullivan
added
release_note:enhancement
review
Feature:Reporting
|
Pinging @elastic/kibana-stack-services |
tsullivan
commented
Aug 29, 2019
| ); | ||
| logger.error(error); |
There was a problem hiding this comment.
This fixes an unrelated problem where an error object was getting concatenated with a string, making it unreadable
💔 Build Failed |
…-browser-console-logging
7 tasks
💚 Build Succeeded |
tsullivan
changed the title
💔 Build Failed |
tsullivan
commented
Sep 5, 2019
|
|
||
| const [consoleMessage$, message$] = partition( | ||
| (msg: string) => !!msg.match(/\[\d+\/\d+.\d+:\w+:CONSOLE\(\d+\)\]/) | ||
| )(stderr$); |
There was a problem hiding this comment.
Removing this code as it does not work with the puppeteer driver. I believe this was written at a time when we launched Chromium directly, without a helper. As of now, we no longer have a way to scan the browser's stdin / stderr as a stream.
There was a problem hiding this comment.
I believe this only works if you use dumpio in puppeteer launch: https://pptr.dev/#?product=Puppeteer&version=v1.19.0&show=api-puppeteerlaunchoptions. We don't expose an option to do this, so I'm cool with removing this
There was a problem hiding this comment.
Same here. As we have explored using dumpio before and found that it doesn't provide a stream of helpful info for us.
💚 Build Succeeded |
tsullivan
changed the title
|
@joelgriffith and I have discussed the risk of removing the |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Sep 5, 2019
…r observable (elastic#44359) * Add browserLogger$, processLogger$ Remove handling of nssError$, fontError$, noUsableSandbox$ * clean up messy logs being forwarded
This was referenced Sep 5, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 6, 2019
…ete-for-distance_feature * 'master' of github.com:elastic/kibana: (89 commits) Replace TSVB timeseries charts with elastic-charts (elastic#33558) [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581) [alerting] Adds Action Type configuration support and whitelisting (elastic#44483) FTR: fix WebDriver Actions calls (elastic#44605) [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677) [skip-ci][Maps] Improve Maps intro page (elastic#44721) [Maps] Update titles and descriptions for data sources (elastic#44833) Types + Extract Integration Util (elastic#44433) Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933) [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359) Update Jest script to output coverage (elastic#44447) [ftr] support --kibana-install-dir flag (elastic#44552) [WATCHER] Allow user to set a threshold value of 0 (elastic#44810) Remove injectI18n in dashboard plugin. (elastic#44580) [Graph] Save modal (elastic#44261) Use external script for the OIDC Implicit flow handler page. (elastic#44866) disable router prefixing with pluginId (elastic#44855) [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671) [ML] File data viz limiting uploaded doc chunk size (elastic#44768) [code] Append go env variable 'GOCACHE' to go lsp spawn command. (elastic#44864) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 6, 2019
…plate * 'master' of github.com:elastic/kibana: (91 commits) [APM] Make number of x ticks responsive to the plot width (elastic#44870) [ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860) Replace TSVB timeseries charts with elastic-charts (elastic#33558) [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581) [alerting] Adds Action Type configuration support and whitelisting (elastic#44483) FTR: fix WebDriver Actions calls (elastic#44605) [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677) [skip-ci][Maps] Improve Maps intro page (elastic#44721) [Maps] Update titles and descriptions for data sources (elastic#44833) Types + Extract Integration Util (elastic#44433) Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933) [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359) Update Jest script to output coverage (elastic#44447) [ftr] support --kibana-install-dir flag (elastic#44552) [WATCHER] Allow user to set a threshold value of 0 (elastic#44810) Remove injectI18n in dashboard plugin. (elastic#44580) [Graph] Save modal (elastic#44261) Use external script for the OIDC Implicit flow handler page. (elastic#44866) disable router prefixing with pluginId (elastic#44855) [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previous code was not successfully capturing browser messages from the web inspector console, or for stdout/stderr of the Chromium process.
This PR fixes the log forwarding of the headless browser, wherever I found it to be possible. Any message tagged as
erroris tagged as anerrorin the Kibana logs. Any other message is tagged asdebug.This PR also completely removes the old handling of text data stream handling that were available prior to integrating Puppeteer:
nssError$,fontError$,noUsableSandbox$. We can file an issue in Puppeteer to get an investigation of why we can't check for stdout messages.The additional logging is tagged as
headless-browser-console. Here are some samples:Replaces: #44056