Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Single metric viewer: Fix top nav refresh behaviour. #44860

Merged
merged 5 commits into from
Sep 6, 2019
Merged

[ML] Single metric viewer: Fix top nav refresh behaviour. #44860

merged 5 commits into from
Sep 6, 2019

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Sep 5, 2019 •
edited
Loading

Summary

Follow up to #43779.

Part of #42909.

To reproduce on master:

  • On the anomaly jobs list, set refresh from 30s to something shorter like 5s
  • Then click on a single metric icon for one of the jobs in the list
  • On the single metric viewer page, the super date picker will say 0 and refresh disabled, but the page will still refresh every 5s

This PR fixes a regression which didn't stop the date picker refresh when switching from the anomaly detection jobs list to single metric viewer. Includes unit tests which would fail without the fix.

This should fix the behaviour for 7.4. For 7.5, EUI itself will include the fix elastic/eui#2298

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@walterra walterra added bug Fixes for quality problems that affect the customer experience regression :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.5.0 labels Sep 5, 2019
@walterra walterra requested a review from a team as a code owner September 5, 2019 09:01
@walterra walterra self-assigned this Sep 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra mentioned this pull request Sep 5, 2019
Closed
7 tasks
alvarezmelissa87
alvarezmelissa87 approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️
Gave this a local test as well and issue seems to be fixed 👌

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jgowdyelastic
jgowdyelastic approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. I no longer see the issue where auto refresh is happening when coming in to the view from the Jobs List.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra merged commit 5c42492 into elastic:master Sep 6, 2019
@walterra walterra deleted the ml-fix-single-metric-viewer-refresh branch September 6, 2019 11:41
@walterra walterra mentioned this pull request Sep 6, 2019
Merged
walterra added a commit to walterra/kibana that referenced this pull request Sep 6, 2019
@walterra
[ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860
3b2e094 
)

This PR fixes a regression which didn't stop the date picker refresh when switching from the anomaly detection jobs list to single metric viewer. Includes unit tests which would fail without the fix.
@walterra walterra mentioned this pull request Sep 6, 2019
Merged
walterra added a commit to walterra/kibana that referenced this pull request Sep 6, 2019
@walterra
[ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860
0abf748 
)

This PR fixes a regression which didn't stop the date picker refresh when switching from the anomaly detection jobs list to single metric viewer. Includes unit tests which would fail without the fix.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 6, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into basic_sql_tem…
5d85255 
…plate

* 'master' of github.com:elastic/kibana: (91 commits)
  [APM] Make number of x ticks responsive to the plot width (elastic#44870)
  [ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860)
  Replace TSVB timeseries charts with elastic-charts (elastic#33558)
  [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581)
  [alerting] Adds Action Type configuration support and whitelisting (elastic#44483)
  FTR: fix WebDriver Actions calls (elastic#44605)
  [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677)
  [skip-ci][Maps] Improve Maps intro page (elastic#44721)
  [Maps] Update titles and descriptions for data sources (elastic#44833)
  Types + Extract Integration Util (elastic#44433)
  Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933)
  [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359)
  Update Jest script to output coverage (elastic#44447)
  [ftr] support --kibana-install-dir flag (elastic#44552)
  [WATCHER] Allow user to set a threshold value of 0 (elastic#44810)
  Remove injectI18n in dashboard plugin. (elastic#44580)
  [Graph] Save modal (elastic#44261)
  Use external script for the OIDC Implicit flow handler page. (elastic#44866)
  disable router prefixing with pluginId (elastic#44855)
  [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 6, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/autocompl…
b6a35c5 
…ete-for-distance_feature

* 'master' of github.com:elastic/kibana:
  [SIEM] Fixes escape bug for filterQuery  (elastic#43030)
  Export saved objects based on search criteria (elastic#44723)
  refactor(webhook-whitelisting): Removed unneeded schema config (elastic#44974)
  [APM] Make number of x ticks responsive to the plot width (elastic#44870)
  [ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860)
walterra added a commit that referenced this pull request Sep 7, 2019
@walterra
[ML] Single metric viewer: Fix top nav refresh behaviour. (#44860) (#…
2d837fa 
…44989)

This PR fixes a regression which didn't stop the date picker refresh when switching from the anomaly detection jobs list to single metric viewer. Includes unit tests which would fail without the fix.
walterra added a commit that referenced this pull request Sep 7, 2019
@walterra
[ML] Single metric viewer: Fix top nav refresh behaviour. (#44860) (#…
289d34d 
…44986)

This PR fixes a regression which didn't stop the date picker refresh when switching from the anomaly detection jobs list to single metric viewer. Includes unit tests which would fail without the fix.
@walterra walterra mentioned this pull request Sep 10, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@walterra walterra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml regression release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@walterra @elasticmachine @alvarezmelissa87 @peteharverson @jgowdyelastic