[ML] Ensure chart interval is not smaller than bucket span #44895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
review
non-issue
jgowdyelastic
requested review from
walterra,
darnautov,
alvarezmelissa87 and
peteharverson
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
darnautov
reviewed
Sep 5, 2019
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| import { SavedSearch } from 'src/legacy/core_plugins/kibana/public/discover/types'; | |||
| import { IndexPattern } from 'ui/index_patterns'; | |||
| import { parseInterval } from 'ui/utils/parse_interval'; | |||
| import { parseInterval } from '../../../../../common/util/parse_interval'; | |||
There was a problem hiding this comment.
I think a change like this would be outside the scope of this PR but is definitely something worth investigating to avoid these horrible relative paths.
peteharverson
approved these changes
Sep 6, 2019
jgowdyelastic
added
the
bug
jgowdyelastic
deleted the
ensure-chart-interval-is-not-smaller-than-bucket-span
branch
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Sep 7, 2019
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Sep 7, 2019
jgowdyelastic
added a commit
that referenced
this pull request
Sep 7, 2019
jgowdyelastic
added a commit
that referenced
this pull request
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interval used to draw each chart in the new job wizards should not be smaller than the bucket span.
When the bucket span changes, the chart intervals are now checked and updated if needed.
Also fixes issue where jobs created by a saved search should not be clonable through the wizards and therefore should not contain
created_bymeta data. This is how the old job wizards worked.