Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logstash] Remove formatted message component in favor of i18n translate function #45658

Merged
merged 3 commits into from
Sep 23, 2019
Merged

[Logstash] Remove formatted message component in favor of i18n translate function #45658

merged 3 commits into from
Sep 23, 2019

Conversation

justinkambic
Copy link
Contributor

Summary

The Logstash pipelines page is generating console warnings because JSX is injected to EuiInMemoryTable's search prop where only a string is valid. The JSX was added to provide internationalization of the page's controls, which is working, but has caused other problems in addition to the dirty console.

Testing this PR

  1. Run Elasticsearch with security enabled, and start a trial
  2. Navigate to Management/Logstash Pipelines
  3. Check the console log, make sure that there are no errors/warnings related to the page

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@justinkambic justinkambic self-assigned this Sep 13, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@justinkambic justinkambic changed the title [Uptime] Remove formatted message component in favor for i18n translate function [Logstash] Remove formatted message component in favor for i18n translate function Sep 19, 2019
@justinkambic justinkambic marked this pull request as ready for review September 19, 2019 21:28
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic changed the title [Logstash] Remove formatted message component in favor for i18n translate function [Logstash] Remove formatted message component in favor of i18n translate function Sep 20, 2019
ycombinator
ycombinator approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Saw errors on master. Confirmed that those errors are gone with this PR. Thanks @justinkambic!

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic merged commit 24e9bc3 into elastic:master Sep 23, 2019
@justinkambic justinkambic mentioned this pull request Sep 23, 2019
Merged
justinkambic added a commit to justinkambic/kibana that referenced this pull request Sep 23, 2019
@justinkambic
[Logstash] Remove formatted message component in favor of i18n transl…
19a267e 
…ate function (elastic#45658)

* Remove formatted message component in favor for i18n translate function.

* Update broken test snapshot.
justinkambic added a commit that referenced this pull request Sep 24, 2019
@justinkambic
[Logstash] Remove formatted message component in favor of i18n transl…
65217c0 
…ate function (#45658) (#46392)

* Remove formatted message component in favor for i18n translate function.

* Update broken test snapshot.
@justinkambic
Copy link
Contributor Author

Backported to:
7.x/7.5.0 65217c0
#46392

@justinkambic justinkambic deleted the logstash_pipeline-search-error branch September 24, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@justinkambic justinkambic

Labels
Feature:Logstash Pipelines Logstash Pipeline UI related release_note:fix v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinkambic @elasticmachine @ycombinator